Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135699/?format=api
{ "id": 135699, "url": "http://patches.dpdk.org/api/patches/135699/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240103074721.832061-2-zhichaox.zeng@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240103074721.832061-2-zhichaox.zeng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240103074721.832061-2-zhichaox.zeng@intel.com", "date": "2024-01-03T07:47:19", "name": "[v6,1/3] net/iavf: support Tx LLDP on scalar", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "39551bfd76b98e4939f5b7bd2be308e78faac9d6", "submitter": { "id": 2644, "url": "http://patches.dpdk.org/api/people/2644/?format=api", "name": "Zhichao Zeng", "email": "zhichaox.zeng@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240103074721.832061-2-zhichaox.zeng@intel.com/mbox/", "series": [ { "id": 30708, "url": "http://patches.dpdk.org/api/series/30708/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30708", "date": "2024-01-03T07:47:18", "name": "net/iavf: support Tx LLDP on scalar and AVX512", "version": 6, "mbox": "http://patches.dpdk.org/series/30708/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135699/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135699/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ACFAB43807;\n\tWed, 3 Jan 2024 08:37:29 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9B4F940608;\n\tWed, 3 Jan 2024 08:37:29 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 52A714013F\n for <dev@dpdk.org>; Wed, 3 Jan 2024 08:37:27 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Jan 2024 23:37:27 -0800", "from unknown (HELO zhichao-dpdk..) ([10.239.252.103])\n by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Jan 2024 23:37:24 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1704267447; x=1735803447;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=O6icR4NmJhWWrpJdREwTzRTCEmdI7uzczdebWWRNdt8=;\n b=AddbbJFLvpWUOAjQAXsrBGIEvnWj+p3WRuqI3T2/Z9lcQc0RYjCHgrz+\n tf6/LHn2wncSjiBYihOc0UA2Y6K4xP1oCDCJ22q6lLuuyyzSR2xn5aReW\n G8Vafmcq//mjZj2JJpMZiCDmeNX9ckECR/YvddK/9PdWUr9+UXA/tlqFq\n SiFHB5BJbKSnAzEBBaePpOmODKYfvt7IyI4rKGinL/VsgDj7V7O2OkrnW\n +Ola0UCU8pw252PZF86srFcJpaMn6wsswLzFN7lF5+pTvQ74MnPQuwPqA\n rGAILCOe7ECcgMaryGjRYaXlwUO3EiiwtTj4uojSCMRLV9s+IxtDTaDTI w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10941\"; a=\"387428603\"", "E=Sophos;i=\"6.04,327,1695711600\"; d=\"scan'208\";a=\"387428603\"", "E=McAfee;i=\"6600,9927,10941\"; a=\"779913022\"", "E=Sophos;i=\"6.04,327,1695711600\"; d=\"scan'208\";a=\"779913022\"" ], "X-ExtLoop1": "1", "From": "Zhichao Zeng <zhichaox.zeng@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Zhichao Zeng <zhichaox.zeng@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v6 1/3] net/iavf: support Tx LLDP on scalar", "Date": "Wed, 3 Jan 2024 15:47:19 +0800", "Message-Id": "<20240103074721.832061-2-zhichaox.zeng@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240103074721.832061-1-zhichaox.zeng@intel.com>", "References": "<20231228032211.1127554-1-zhichaox.zeng@intel.com>\n <20240103074721.832061-1-zhichaox.zeng@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds an mbuf dynfield IAVF_TX_LLDP_DYNFIELD to determine\nwhether or not to fill the SWTCH_UPLINK bit in the Tx context descriptor\nto transmit LLDP packet.\n\nSigned-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 5 +++++\n drivers/net/iavf/iavf_rxtx.c | 13 +++++++++++--\n drivers/net/iavf/iavf_rxtx.h | 8 ++++++++\n 3 files changed, 24 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex d1edb0dd5c..ef34246d36 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -41,6 +41,7 @@\n #define IAVF_NO_POLL_ON_LINK_DOWN_ARG \"no-poll-on-link-down\"\n uint64_t iavf_timestamp_dynflag;\n int iavf_timestamp_dynfield_offset = -1;\n+int rte_pmd_iavf_tx_lldp_dynfield_offset = -1;\n \n static const char * const iavf_valid_args[] = {\n \tIAVF_PROTO_XTR_ARG,\n@@ -1017,6 +1018,10 @@ iavf_dev_start(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n+\t/* Check Tx LLDP dynfield */\n+\trte_pmd_iavf_tx_lldp_dynfield_offset =\n+\t\trte_mbuf_dynfield_lookup(IAVF_TX_LLDP_DYNFIELD, NULL);\n+\n \tif (iavf_init_queues(dev) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"failed to do Queue init\");\n \t\treturn -1;\ndiff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex f19aa14646..4329809d1d 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -2418,8 +2418,9 @@ iavf_xmit_cleanup(struct iavf_tx_queue *txq)\n \n /* Check if the context descriptor is needed for TX offloading */\n static inline uint16_t\n-iavf_calc_context_desc(uint64_t flags, uint8_t vlan_flag)\n+iavf_calc_context_desc(struct rte_mbuf *mb, uint8_t vlan_flag)\n {\n+\tuint64_t flags = mb->ol_flags;\n \tif (flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG |\n \t RTE_MBUF_F_TX_TUNNEL_MASK | RTE_MBUF_F_TX_OUTER_IP_CKSUM |\n \t RTE_MBUF_F_TX_OUTER_UDP_CKSUM))\n@@ -2427,6 +2428,10 @@ iavf_calc_context_desc(uint64_t flags, uint8_t vlan_flag)\n \tif (flags & RTE_MBUF_F_TX_VLAN &&\n \t vlan_flag & IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)\n \t\treturn 1;\n+\n+\tif (IAVF_CHECK_TX_LLDP(mb))\n+\t\treturn 1;\n+\n \treturn 0;\n }\n \n@@ -2446,6 +2451,10 @@ iavf_fill_ctx_desc_cmd_field(volatile uint64_t *field, struct rte_mbuf *m,\n \t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n \t}\n \n+\tif (IAVF_CHECK_TX_LLDP(m))\n+\t\tcmd |= IAVF_TX_CTX_DESC_SWTCH_UPLINK\n+\t\t\t<< IAVF_TXD_CTX_QW1_CMD_SHIFT;\n+\n \t*field |= cmd;\n }\n \n@@ -2826,7 +2835,7 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \n \t\tnb_desc_data = mb->nb_segs;\n \t\tnb_desc_ctx =\n-\t\t\tiavf_calc_context_desc(mb->ol_flags, txq->vlan_flag);\n+\t\t\tiavf_calc_context_desc(mb, txq->vlan_flag);\n \t\tnb_desc_ipsec = !!(mb->ol_flags & RTE_MBUF_F_TX_SEC_OFFLOAD);\n \n \t\t/**\ndiff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h\nindex f432f9d956..25df517bc6 100644\n--- a/drivers/net/iavf/iavf_rxtx.h\n+++ b/drivers/net/iavf/iavf_rxtx.h\n@@ -107,8 +107,16 @@\n #define IAVF_MAX_DATA_PER_TXD \\\n \t(IAVF_TXD_QW1_TX_BUF_SZ_MASK >> IAVF_TXD_QW1_TX_BUF_SZ_SHIFT)\n \n+#define IAVF_TX_LLDP_DYNFIELD \"intel_pmd_dynfield_tx_lldp\"\n+#define IAVF_CHECK_TX_LLDP(m) \\\n+\t((rte_pmd_iavf_tx_lldp_dynfield_offset > 0) && \\\n+\t(*RTE_MBUF_DYNFIELD((m), \\\n+\t\t\trte_pmd_iavf_tx_lldp_dynfield_offset, \\\n+\t\t\tuint8_t *)))\n+\n extern uint64_t iavf_timestamp_dynflag;\n extern int iavf_timestamp_dynfield_offset;\n+extern int rte_pmd_iavf_tx_lldp_dynfield_offset;\n \n /**\n * Rx Flex Descriptors\n", "prefixes": [ "v6", "1/3" ] }