Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135696/?format=api
{ "id": 135696, "url": "http://patches.dpdk.org/api/patches/135696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240103035605.720256-2-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240103035605.720256-2-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240103035605.720256-2-suanmingm@nvidia.com", "date": "2024-01-03T03:56:05", "name": "[2/2] app/test-crypto-perf: fix encrypt operation verify", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b2f336d0d1d901e014985c23d6cc5af30007965", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240103035605.720256-2-suanmingm@nvidia.com/mbox/", "series": [ { "id": 30706, "url": "http://patches.dpdk.org/api/series/30706/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30706", "date": "2024-01-03T03:56:04", "name": "[1/2] app/test-crypto-perf: fix invalid memcmp results", "version": 1, "mbox": "http://patches.dpdk.org/series/30706/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135696/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11B5A43804;\n\tWed, 3 Jan 2024 04:56:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A1F840648;\n\tWed, 3 Jan 2024 04:56:48 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2053.outbound.protection.outlook.com [40.107.220.53])\n by mails.dpdk.org (Postfix) with ESMTP id 016BA40648\n for <dev@dpdk.org>; Wed, 3 Jan 2024 04:56:46 +0100 (CET)", "from BLAPR03CA0054.namprd03.prod.outlook.com (2603:10b6:208:32d::29)\n by SN7PR12MB7321.namprd12.prod.outlook.com (2603:10b6:806:298::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Wed, 3 Jan\n 2024 03:56:44 +0000", "from MN1PEPF0000ECD9.namprd02.prod.outlook.com\n (2603:10b6:208:32d:cafe::8c) by BLAPR03CA0054.outlook.office365.com\n (2603:10b6:208:32d::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25 via Frontend\n Transport; Wed, 3 Jan 2024 03:56:44 +0000", "from mail.nvidia.com (216.228.117.161) by\n MN1PEPF0000ECD9.mail.protection.outlook.com (10.167.242.138) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 03:56:44 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 2 Jan 2024\n 19:56:24 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 2 Jan 2024\n 19:56:22 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VoccPhvzonw9BazUh3wQnpO2K+QAoWXXL9KsjaACmloHz5OEefSOfzSP/ccCfMD4NCetWe4BTtDIauuE3MxKZIfpfd0bgY7r7ha66ErdPvtjPveCNudddHEzwmvTKseGn7BHRIlT5wRgfa1ewnua/8zCjRXlwTy8IM/WL0eEnj3AKE6kaA60589ERZO+fB39Z5OywUppu5wrwtTh/Eo9ati665CcKaKLNhxEJR2eInvvIUbDYfpLoPW6QrY3jSdO7xoYuUwfKlklFZ/uOhi+ygZZb0aO8gGnQ6qAl0/bgIkEyYumqAPd4ROTO5K8UsPlBl/8MURiX6TZE/tCq/+rcA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=iB4HvWoKgkiSPa/wFOoaiylbVzJXRIqdHj4ZtjjnauA=;\n b=bU9B4WseQunNEFyeQix9klEsNI53YiuuZs8Bdj7M71csK6yEO8sPi8be/kNaAx7316dCkTR9fNdgNWbBU7RV1CmxUQ+K1qr/fkKB8FvLGa/9RhYzDZEhBMuCcldo4bhXr5p/kbEC2j/1nX8Fo9KxrcorXbGXFI9qK1OfCbO4aHkGqqC3vc+buMbFf9ygTi7VNqZedUSkqj/lLJCDR3pq5Yc8JcfadBk4a8ZU7Nrxxvo9RESV9ndhwNdUgjkdyrAKxbWIxcHJMoiSC8pCfDx/ZdrjxvBiplktVokXIbrpOe4UdjQ3BXaYvZxK8BG8FVGIe4WjU/CUQHxnW2kUDzwqgg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iB4HvWoKgkiSPa/wFOoaiylbVzJXRIqdHj4ZtjjnauA=;\n b=Rqvi2ycKdBq+5NwqYf7ycYZj13/gQ21uNuAfST98OGHx8a+wXdAvCWsB+QbL6CSlKux2+aWp6kGsPDZA5PM0maQtyJJD3Szh1AyLk9VaP714IpFkhuWX39IC7LUdwhlGoqCzT1wvZl1UnQPtiiNEIsylkdc1HyddaPLbyBTFzFpntY3uh73990PcBOL/P5B2eHIggG/d4uOa2aitBX865/6jFkqmkF6gWsYVg45pmeR0jynIvr+mOwo6nEKTSQjOK9KmMNoyIJwSAU2wAGXZMOoarjKpebNkwv27nFRQTB9nJ4dWelHQz8M/nXLdraagDAl34zfgUXogpyPtPlfKrg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Ciara Power <ciara.power@intel.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 2/2] app/test-crypto-perf: fix encrypt operation verify", "Date": "Wed, 3 Jan 2024 11:56:05 +0800", "Message-ID": "<20240103035605.720256-2-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240103035605.720256-1-suanmingm@nvidia.com>", "References": "<20240103035605.720256-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MN1PEPF0000ECD9:EE_|SN7PR12MB7321:EE_", "X-MS-Office365-Filtering-Correlation-Id": "50bb40e1-23d1-4201-1b50-08dc0c100036", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ihyT14E4sOgNs87Y3merdx9QUkV5D+UEwkx5Y/FCG0BW5h12vXGJQtgWXz2prncY4u0edERZeEZRGvfI/703xqxhg3a9QW4culTMyLQLJuOylpFcMO33Y9R40pb2H/luG3nASAMbmKk7VIHn7PZemJ17DCSDicVHXsEeLJUHeUMgbu7zb6Luft3I0NgDT90/7/69BIV1bs4/I3i+oDaDKVnDbMLnX2KxGV5bFHQoXJQMmejRoEzi4hEQKIC8kRekkxyptl5v++LwDrizeUrfVBWit6/a10HyNlh6O/OLVzZjM2xq+9sc1+muKpApTh+4uNafzdemE+Q/AqLvCygzMSKyvqHlzXkGq/iNkMBIEtqnsYWBA8TtioQQXNjGcuc4zV2V9Ub1OXzbgDkYG6Hjl8Sp7JKLCphB8VAHpoet5R/HFsL9HkhTqDQ7OgEMN1QBCda8F0mAlBGb42t2V3sg6Z075VorhbgtZWv6WmYN8vs3wtiNux9yc5W6SND/YPtAXnC+CM9LEcCxEgJz0cf/zBeE15pYuzoneKcW49nO9iPb703SZizlHQHQ50xGO4cgYZmQlIwLPtxsVvB48whb+D6norgxTkFS7XGJRzRGtKAg7yimR5DfZ6D8EkOiaohwaibLVgkGbIWLt1ZPzqXTQBFQI7MvHwHAevvzCUuOvME09kfTsx4N0pzD91mOWc/gS44z3tfMkPHgkQOpCJBUiC0L3Jh9YZKacDETIKI+32OW9+8FxgPgdnH6Sz3XbxtCDUKu+c7TrUqosDbiEMqkyw==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(136003)(396003)(346002)(376002)(230922051799003)(82310400011)(451199024)(186009)(64100799003)(1800799012)(40470700004)(36840700001)(46966006)(7636003)(82740400003)(2906002)(15650500001)(36756003)(356005)(86362001)(41300700001)(6916009)(70206006)(316002)(40480700001)(16526019)(70586007)(83380400001)(6286002)(2616005)(7696005)(478600001)(26005)(55016003)(1076003)(8936002)(6666004)(336012)(40460700003)(426003)(8676002)(4326008)(47076005)(36860700001)(5660300002)(309714004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Jan 2024 03:56:44.0292 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 50bb40e1-23d1-4201-1b50-08dc0c100036", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MN1PEPF0000ECD9.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB7321", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "AEAD users RTE_CRYPTO_AEAD_OP_* with aead_op and CIPHER uses\nRTE_CRYPTO_CIPHER_OP_* with cipher_op in current code.\n\nThis commit aligns aead_op and cipher_op operation to fix\nincorrect AEAD verification.\n\nFixes: df52cb3b6e13 (\"app/crypto-perf: move verify as single test type\")\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\n---\n app/test-crypto-perf/cperf_test_verify.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c\nindex 8aa714b969..525a2b1373 100644\n--- a/app/test-crypto-perf/cperf_test_verify.c\n+++ b/app/test-crypto-perf/cperf_test_verify.c\n@@ -113,6 +113,7 @@ cperf_verify_op(struct rte_crypto_op *op,\n \tuint8_t *data;\n \tuint32_t cipher_offset, auth_offset;\n \tuint8_t\tcipher, auth;\n+\tbool is_encrypt = false;\n \tint res = 0;\n \n \tif (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS)\n@@ -154,12 +155,14 @@ cperf_verify_op(struct rte_crypto_op *op,\n \t\tcipher_offset = 0;\n \t\tauth = 0;\n \t\tauth_offset = 0;\n+\t\tis_encrypt = options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT;\n \t\tbreak;\n \tcase CPERF_CIPHER_THEN_AUTH:\n \t\tcipher = 1;\n \t\tcipher_offset = 0;\n \t\tauth = 1;\n \t\tauth_offset = options->test_buffer_size;\n+\t\tis_encrypt = options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT;\n \t\tbreak;\n \tcase CPERF_AUTH_ONLY:\n \t\tcipher = 0;\n@@ -172,12 +175,14 @@ cperf_verify_op(struct rte_crypto_op *op,\n \t\tcipher_offset = 0;\n \t\tauth = 1;\n \t\tauth_offset = options->test_buffer_size;\n+\t\tis_encrypt = options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT;\n \t\tbreak;\n \tcase CPERF_AEAD:\n \t\tcipher = 1;\n \t\tcipher_offset = 0;\n-\t\tauth = 1;\n+\t\tauth = options->aead_op == RTE_CRYPTO_AEAD_OP_ENCRYPT;\n \t\tauth_offset = options->test_buffer_size;\n+\t\tis_encrypt = !!auth;\n \t\tbreak;\n \tdefault:\n \t\tres = 1;\n@@ -185,7 +190,7 @@ cperf_verify_op(struct rte_crypto_op *op,\n \t}\n \n \tif (cipher == 1) {\n-\t\tif (options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT)\n+\t\tif (is_encrypt)\n \t\t\tres += !!memcmp(data + cipher_offset,\n \t\t\t\t\tvector->ciphertext.data,\n \t\t\t\t\toptions->test_buffer_size);\n", "prefixes": [ "2/2" ] }