Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135580/?format=api
{ "id": 135580, "url": "http://patches.dpdk.org/api/patches/135580/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231226072824.3163121-12-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231226072824.3163121-12-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231226072824.3163121-12-chaoyong.he@corigine.com", "date": "2023-12-26T07:28:21", "name": "[v6,11/14] net/nfp: support bond member notification", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b8a0ae24d08307f26162a9a7c87750a31f2d0f02", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231226072824.3163121-12-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30668, "url": "http://patches.dpdk.org/api/series/30668/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30668", "date": "2023-12-26T07:28:10", "name": "Enhance the bond framework to support offload", "version": 6, "mbox": "http://patches.dpdk.org/series/30668/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135580/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135580/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 154C643795;\n\tTue, 26 Dec 2023 08:30:13 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E367240A72;\n\tTue, 26 Dec 2023 08:29:07 +0100 (CET)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2096.outbound.protection.outlook.com [40.107.212.96])\n by mails.dpdk.org (Postfix) with ESMTP id E0F1440DCA\n for <dev@dpdk.org>; Tue, 26 Dec 2023 08:29:06 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by CH3PR13MB6506.namprd13.prod.outlook.com (2603:10b6:610:1a3::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec\n 2023 07:29:05 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7113.027; Tue, 26 Dec 2023\n 07:29:05 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UnG3qEiiYPWS/sC0hAfIdTzYOqbRJl7vufD7lq1lAXocDIPVEkpAlLOLIawO2yEKuWfti2GUkpJTA2KM9DG7lnU+aqPhckaoyBV7jU77ITTVOoWr48dRh8LcP9Q7Wz+rNuGUmxxYCf6Op2OIXhxI7Rd2FNFoGcsfBAf2aqKHqWeBfTRxANnV7YNig44ruQtH5YrLSUBgtuSJyPbzX1ZU9nuLejMmPyXxmldIM+/o2Ndla1+tlOJjreoy58WCiFEuN/DxYG2nB4i29QEDgrHKVMcVhPj7jSccXpwDgBvJY6Wbgbic1OU59ZgZu7FymjA4btz2t/e3Q4scjL0D9hozEQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ij8QBNgBP72k6ZRgpa33f2G29FEr1Y+m+yfbZ+QHxBk=;\n b=EE1JdFL5yrjk4gC7MQdrjxGxrW7vR857S2mYkQaDUbz6b0CrPUj20YLPc97m4fwAqi2MTonabj7Q14Ygpq+DbsVgEY6Ze+FBVg7r0sJjnSxQ7w5hR2LkceefD343PJrckoduyewG2kdqtQU6bZVeZDKCWJuS5KdondMSeBDPpZFrtZ3WLmaNoVaDa8IjuEHkuag764dplk9vpYVf/sy+benfwjP1xkrldPvtlizqQiAnHhHpgadto3BSd9HIcPY3eG3JE5SaIW9h0n05rB+/tdTbG+DwTXaSuDvZ+neMUmwWdE5/cpisWkV/DI7iF/kckJRhtNw/E892ohWMSTOHRg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ij8QBNgBP72k6ZRgpa33f2G29FEr1Y+m+yfbZ+QHxBk=;\n b=AJU0c5UpGAhyf+44gEUNCieCrW+4aS71qn3aWT2HzSm6uBWEhrCuK1lzMSNJAnwbxp+VuzPVQexMicfrWSpqbFVEGd6vNL0VyMXJTE1mrUD3h01MVDfS4EAnAP7k1YhSht3l4iiw9WRNJYenh2gZr/W1IUzjMheJ4WOgOLo317g=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v6 11/14] net/nfp: support bond member notification", "Date": "Tue, 26 Dec 2023 15:28:21 +0800", "Message-Id": "<20231226072824.3163121-12-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231226072824.3163121-1-chaoyong.he@corigine.com>", "References": "<20231226023745.3144143-1-chaoyong.he@corigine.com>\n <20231226072824.3163121-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR03CA0239.namprd03.prod.outlook.com\n (2603:10b6:a03:39f::34) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|CH3PR13MB6506:EE_", "X-MS-Office365-Filtering-Correlation-Id": "343d4728-9b52-4608-9a57-08dc05e45703", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n Zbo85fK/+lymgJBBp3XYt53bu/lXoQUjUy6jFUvjgzR47WORVy5LDaUPeZi7b/Es0cwbi7vx8vGEFG/wmo4kB+MjuqiOPnS1v+wi7u3ArvKrmLVeqzIvuMQMGlM73yc9W5se6vYTA2FEWUZKSqhxG6+pbq907TVuVPcm4BIQVQxel9HpvK7OVkJQ4cMGaQcmX11Na9COsikKdXlVkOIBahcv8I19gl9hwpGb7/WirczlgQIWcyKaLCHfgADQA7KBLeXj7Fq+3PzzRTTfgVo3WZ+TXEeOkszHH4m+1CqLAaBWJCrh6f9ttnpAi6rKrIGAYsep1ulf93lik74edlDRU0Obl+lZk4U2GUTV5K4WmQuAGIOIdhD9hsBWNuVMpPLkbrwEJPZHUmp/1YiY7VpMVlcyhyH9fdQQ+oDt2woNqn2ABjsLfGgx38v7+7M4qsk4sL/X7tLYJBJbXstxUzoKiAeLH/HeS1eN7UMuPBOyDUX88lV3xW9DJR6/yVQie0GTCQqE7f8VPIc3/8Dy6s6z+iG0/SZFOEL0M3WL8tDZSc6nWYAu3zHxW6V0byV7SnyXq0+20dNLlbovnLuow0GA2mYYwDgzU0Qj7LKNbO7KJBlxpzPfxE9h1NnPQ5TTT6wKK1pVVgKOLxE8Q11eQuz8TNTYXXNL9DS6i98G4kngeKMw/4Ebr+7IadNYmHA7gn5MJSi4gs7NezXQTurXq7uTwA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(376002)(346002)(136003)(396003)(366004)(39840400004)(230273577357003)(230173577357003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(107886003)(26005)(1076003)(52116002)(6666004)(2616005)(6512007)(83380400001)(5660300002)(44832011)(15650500001)(4326008)(8676002)(41300700001)(2906002)(8936002)(6486002)(478600001)(316002)(6916009)(54906003)(66476007)(66556008)(66946007)(6506007)(86362001)(36756003)(38100700002)(38350700005);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 5sN8SXacNfxPc3NoAvYaRVjaIDaB+QI/GhZzfaZx/LIqoShvoZF7PSWaWtoR/WMLE/8Zw5orzVMqUF8eOiS6p10orumiyHBEtR8VCTU6ZSd+n5RM8XjkzksLGlLXEmiiAE6iKNk/mVOOj6dJhMYkQhZdtPdDye5r+F45kXUmzsyn4IqYyywuJsQZSTkA4KV3SpNBb52AHOVrA2EyQUAx9vcJt/kOlmraxi9dDrHF66ovgEhUDFXYwsAhCmdpbYYf9586iitlD1gOqEA1CRBMfdR++yjACnb06+adsaBr161sTS6VzFQL9L3nVbxYjbaE/xuo7JcLsaZwK2Qt9qNpx371TDVdTNnmqiaau2zUNMcnfRicl4nfTKGha97pY+/U4Y0bXIxrz8PJm5ZLvDDSjePUdqMLd/PluKXg+FULC4i640EXfBnP853+uCMBlSnfgdKwTbU9BTjYUIi7k9XqxBw0D2fXalmpbvtdBRwiLS81fkXlAzUIE2+UDDprT7GRp8F5OYuh7hlPuA1uxFn1aQgaYR58tujJUq9V+YfJoCkfO6d+llXn+HXAkCI67EyBJPKjJjJfykT+k+PtTZiYd+TBgWVeBdzLBr+ec4TF6/Vb5ykrlRi2LHLsxiOJiEMHNs6umGKyT5qLa9o7B0IOGGRFwu9gq9LltDWPgENwOp61trZlv7s0OtdGenUzjiDR3LdT/TzPW2TlEoT4hV/LVei88JizK5tRirFMnDzQEx9thcIlAGiTJIEWJOhFXy/UDDBeF+S+9bJNrM1Eji6fHerB+QpuIVOlZN36v7WI72v+7XPRU3inWGrIkexocQjuVoHTuko/7xr9DRNMk7JEf+AgOtVMy4I/jQ2LaGGJ9oxAZuv6dZgIFKwzKEYZMixTTXAKIyZrZX6k1cAeYCAlzff96cSJgTmjXe1h6lQH/dgDy2D8PKfXRVY3Z2sGaPxfOCYG1/iHuf4YgbK+MES8rROeds+sokFLhmwa8n1fvDbLCDu69XV0qwv0lJ8KBtZQ4n67AYvwO9rtv/PJPdRKPqLA8XTLc7X70N3CrbcPxJgGlXF+dr36+wiL+k5ElG6HhWITWdozTpWj8p8zI4HeYXNsFa94lxIQ+AhN4qY2Pzng5xtK7aw6O3JNb+s/DSNYdTqfBkLxqBcsJuzYo5L2QQt9abJRGFJFzPCJrw2O6tBUZxJHZ6iAHZbTu6IwL/ygeIY8ruvCMC4YEFLzSjhsTuY7L326Kd849cGKZz6ytPY8UO3ZHPkhXlzR0S1H3mGqEybgyIHsaiJTKqojmkQYQut8DYM0OSlpx6iDwBIXl12lF1TIzhDwy7XaZWk/T0aiTNiAZ4H7pnYsS2Q8ifhyw+lbpX5ayRQI9H+RF/AvNxoDCtrU5LNismEXHED4QU+MfJ1EsyGd1RlJ0A9xpCQ0m6wALA1jqugeBHJY2yUiA9aHPysb127u8cTVCPvjWJW/LsAh9qphgq4uhXiaLmyG2nosAxGi8zPr/+e4ySkgBZo8h49Tne4EMZGr2HWAFAKCEWCCLWe6p51aNXMmlYgG9ByapC3fIuo6iVFmYbJjW9PbsT32+5k7OnvAbxHzrW3TutQx80/Vv/Eg+lx5SU6bRA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 343d4728-9b52-4608-9a57-08dc05e45703", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Dec 2023 07:29:05.2933 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n i1WxO5B3CWeJ38oyMdjHe2jes3IJ/8JgOqQgLLBABSo39lsSV21tnBpwEnoBTxij9XvzHNbsSao/uQYqxgDLyhbRxCQSf6LwiIZZ0aEZrMI=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR13MB6506", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nA NFP representor port can receive a bond notification. Then driver\nwill parse this notification into one of these two events:\n1. Bonding port configuration may have changed.\nThis includes creation of a bonding port, removal/addition of\na member port, changing the bond mode, etc.\n2. Bonding port is deleted.\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower_bond.c | 183 +++++++++++++++++-\n drivers/net/nfp/flower/nfp_flower_bond.h | 2 +\n .../net/nfp/flower/nfp_flower_representor.c | 21 ++\n 3 files changed, 205 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower_bond.c b/drivers/net/nfp/flower/nfp_flower_bond.c\nindex c814c0d4ea..523e0025ad 100644\n--- a/drivers/net/nfp/flower/nfp_flower_bond.c\n+++ b/drivers/net/nfp/flower/nfp_flower_bond.c\n@@ -46,6 +46,39 @@ nfp_flower_bond_increment_version(struct nfp_flower_bond *nfp_bond)\n \t\tnfp_bond->batch_ver += 2;\n }\n \n+static void\n+nfp_flower_bond_group_id_clear(struct nfp_flower_bond *nfp_bond,\n+\t\tuint32_t id_clear)\n+{\n+\tbool *group_id_map = nfp_bond->group_id_map;\n+\n+\tif (id_clear >= NFP_FL_BOND_GROUP_MAX || id_clear < NFP_FL_BOND_GROUP_MIN) {\n+\t\tPMD_DRV_LOG(ERR, \"Try to clear invalid group id %u.\", id_clear);\n+\t\treturn;\n+\t}\n+\n+\tif (group_id_map[id_clear])\n+\t\tgroup_id_map[id_clear] = false;\n+}\n+\n+static int\n+nfp_flower_bond_group_id_get(struct nfp_flower_bond *nfp_bond,\n+\t\tuint32_t *id_ret)\n+{\n+\tuint32_t id;\n+\tbool *group_id_map = nfp_bond->group_id_map;\n+\n+\tfor (id = NFP_FL_BOND_GROUP_MIN; id < NFP_FL_BOND_GROUP_MAX; id++) {\n+\t\tif (!group_id_map[id]) {\n+\t\t\tgroup_id_map[id] = true;\n+\t\t\t*id_ret = id;\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\n+\treturn -ENOSPC;\n+}\n+\n static enum nfp_flower_bond_batch\n nfp_flower_bond_remove_node(struct nfp_flower_bond *nfp_bond,\n \t\tstruct nfp_bond_group *entry,\n@@ -65,6 +98,7 @@ nfp_flower_bond_remove_node(struct nfp_flower_bond *nfp_bond,\n \tentry->offloaded = false;\n \n \tif (entry->to_destroy) {\n+\t\tnfp_flower_bond_group_id_clear(nfp_bond, entry->group_id);\n \t\tLIST_REMOVE(entry, next);\n \t\trte_free(entry);\n \t}\n@@ -139,6 +173,7 @@ nfp_flower_bond_cleanup(struct nfp_app_fw_flower *app_fw_flower)\n \n \tpthread_mutex_lock(&nfp_bond->mutex);\n \tLIST_FOREACH(entry, &nfp_bond->group_list, next) {\n+\t\tnfp_flower_bond_group_id_clear(nfp_bond, entry->group_id);\n \t\tLIST_REMOVE(entry, next);\n \t\trte_free(entry);\n \t}\n@@ -271,16 +306,162 @@ nfp_flower_bond_change_linkstatus_event(struct nfp_flower_bond *nfp_bond,\n \t*bond_port_flags |= NFP_FL_BOND_PORT_CHANGED;\n }\n \n+static struct nfp_bond_group *\n+nfp_flower_bond_group_create(struct nfp_flower_bond *nfp_bond,\n+\t\tstruct rte_eth_dev *bond_dev)\n+{\n+\tuint32_t id;\n+\tunsigned int numa_node;\n+\tstruct nfp_bond_group *group = NULL;\n+\n+\tif (nfp_flower_bond_group_id_get(nfp_bond, &id) < 0)\n+\t\treturn NULL;\n+\n+\tnuma_node = rte_socket_id();\n+\n+\tgroup = rte_zmalloc_socket(NULL, sizeof(struct nfp_bond_group),\n+\t\t\tRTE_CACHE_LINE_SIZE, numa_node);\n+\tif (group == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"Unable malloc memory for nfp bond group\");\n+\t\tnfp_flower_bond_group_id_clear(nfp_bond, id);\n+\t\treturn NULL;\n+\t}\n+\n+\tgroup->group_id = id;\n+\tgroup->main_dev = bond_dev;\n+\tgroup->dirty = true;\n+\tgroup->offloaded = false;\n+\tgroup->to_remove = false;\n+\tgroup->to_destroy = false;\n+\tgroup->member_cnt = 0;\n+\tgroup->group_inst = ++nfp_bond->global_inst;\n+\tLIST_INSERT_HEAD(&nfp_bond->group_list, group, next);\n+\n+\treturn group;\n+}\n+\n+static int\n+nfp_flower_bond_changeupper_event(struct nfp_flower_bond *nfp_bond,\n+\t\tstruct rte_eth_dev *bond_dev)\n+{\n+\tuint32_t i;\n+\tuint16_t port_id;\n+\tbool can_offload = true;\n+\tuint16_t nfp_member_count;\n+\tstruct rte_eth_dev *eth_dev;\n+\tstruct nfp_bond_group *group;\n+\tstruct bond_dev_private *internals;\n+\tstruct nfp_flower_representor *repr;\n+\tstruct nfp_app_fw_flower *app_flower;\n+\n+\tinternals = bond_dev->data->dev_private;\n+\tapp_flower = nfp_bond->app_fw_flower;\n+\tnfp_member_count = 0;\n+\n+\tfor (i = 0; i < internals->member_count; i++) {\n+\t\tport_id = internals->members[i].port_id;\n+\t\teth_dev = &rte_eth_devices[port_id];\n+\t\tif (!nfp_flower_is_phy_repr(eth_dev)) {\n+\t\t\tcan_offload = false;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\trepr = eth_dev->data->dev_private;\n+\n+\t\tif (repr->app_fw_flower != app_flower) {\n+\t\t\tcan_offload = false;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tif (internals->current_primary_port == port_id ||\n+\t\t\t\tinternals->mode != BONDING_MODE_ACTIVE_BACKUP)\n+\t\t\tnfp_member_count++;\n+\t}\n+\n+\tif (internals != NULL &&\n+\t\t\tinternals->mode != BONDING_MODE_ACTIVE_BACKUP &&\n+\t\t\t((internals->mode != BONDING_MODE_BALANCE &&\n+\t\t\tinternals->mode != BONDING_MODE_8023AD) ||\n+\t\t\tinternals->balance_xmit_policy != BALANCE_XMIT_POLICY_LAYER34)) {\n+\t\tcan_offload = false;\n+\t\tPMD_DRV_LOG(WARNING, \"Unable to offload mode %u hash %u.\",\n+\t\t\t\tinternals->mode,\n+\t\t\t\tinternals->balance_xmit_policy);\n+\t}\n+\n+\tpthread_mutex_lock(&nfp_bond->mutex);\n+\n+\tgroup = nfp_flower_bond_find_group(nfp_bond, bond_dev);\n+\tif (nfp_member_count == 0 || !can_offload) {\n+\t\tif (group != NULL && group->offloaded)\n+\t\t\t/* Set remove flag */\n+\t\t\tgroup->to_remove = true;\n+\n+\t\tpthread_mutex_unlock(&nfp_bond->mutex);\n+\t\treturn 0;\n+\t}\n+\n+\tif (group == NULL) {\n+\t\tgroup = nfp_flower_bond_group_create(nfp_bond, bond_dev);\n+\t\tif (group == NULL) {\n+\t\t\tpthread_mutex_unlock(&nfp_bond->mutex);\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\n+\tgroup->dirty = true;\n+\tgroup->member_cnt = nfp_member_count;\n+\tgroup->to_remove = false;\n+\n+\tpthread_mutex_unlock(&nfp_bond->mutex);\n+\n+\treturn 0;\n+}\n+\n+static void\n+nfp_flower_bond_group_delete(struct nfp_flower_bond *nfp_bond,\n+\t\tstruct rte_eth_dev *bond_dev)\n+{\n+\tstruct nfp_bond_group *group;\n+\n+\tpthread_mutex_lock(&nfp_bond->mutex);\n+\n+\tgroup = nfp_flower_bond_find_group(nfp_bond, bond_dev);\n+\tif (group == NULL) {\n+\t\tpthread_mutex_unlock(&nfp_bond->mutex);\n+\t\tPMD_DRV_LOG(WARNING, \"Untracked bond got unregistered %s\",\n+\t\t\t\tbond_dev->device->name);\n+\t\treturn;\n+\t}\n+\n+\tgroup->to_remove = true;\n+\tgroup->to_destroy = true;\n+\n+\tpthread_mutex_unlock(&nfp_bond->mutex);\n+}\n+\n int\n nfp_flower_bond_event_handle(struct nfp_flower_bond *nfp_bond,\n \t\tstruct rte_eth_dev *bond_dev,\n \t\tstruct rte_eth_dev *nfp_dev,\n \t\tenum nfp_flower_bond_event event)\n {\n+\tint ret = 0;\n+\n \tswitch (event) {\n+\tcase NFP_FLOWER_CHANGEUPPER:\n+\t\tret = nfp_flower_bond_changeupper_event(nfp_bond, bond_dev);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Change upper event can not work.\");\n+\t\t\treturn ret;\n+\t\t}\n+\t\tbreak;\n \tcase NFP_FLOWER_CHANGELINKSTATUS:\n \t\tnfp_flower_bond_change_linkstatus_event(nfp_bond, bond_dev, nfp_dev);\n \t\tbreak;\n+\tcase NFP_FLOWER_UNREGISTER:\n+\t\tnfp_flower_bond_group_delete(nfp_bond, bond_dev);\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"Invalid bond offload event.\");\n \t\treturn -1;\n@@ -288,7 +469,7 @@ nfp_flower_bond_event_handle(struct nfp_flower_bond *nfp_bond,\n \n \tnfp_flower_bond_do_work(nfp_bond);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n enum nfp_flower_bond_batch\ndiff --git a/drivers/net/nfp/flower/nfp_flower_bond.h b/drivers/net/nfp/flower/nfp_flower_bond.h\nindex e4a09b3427..12e61ff1ce 100644\n--- a/drivers/net/nfp/flower/nfp_flower_bond.h\n+++ b/drivers/net/nfp/flower/nfp_flower_bond.h\n@@ -109,6 +109,8 @@ struct nfp_flower_bond {\n \tuint32_t global_inst;\n \t/** Incremented for each config packet sent */\n \tuint32_t pkt_num;\n+\t/** ID of bond group in driver, true is used */\n+\tbool group_id_map[NFP_FL_BOND_GROUP_MAX];\n \t/** Pointer to the flower app */\n \tstruct nfp_app_fw_flower *app_fw_flower;\n };\ndiff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c\nindex 2810a7a271..43106da90e 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.c\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.c\n@@ -390,6 +390,25 @@ nfp_flower_repr_dev_close(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+nfp_flower_repr_bond_notify_member(struct rte_eth_dev *dev,\n+\t\tstruct rte_eth_dev *bond_dev)\n+{\n+\tstruct nfp_flower_representor *repr;\n+\tenum nfp_flower_bond_event event = NFP_FLOWER_CHANGEUPPER;\n+\n+\tif (!nfp_flower_bond_all_member_are_phyrepr(bond_dev))\n+\t\tevent = NFP_FLOWER_UNREGISTER;\n+\n+\trepr = dev->data->dev_private;\n+\n+\tif (nfp_flower_support_bond_offload(repr->app_fw_flower))\n+\t\treturn nfp_flower_bond_event_handle(repr->app_fw_flower->nfp_bond,\n+\t\t\t\tbond_dev, dev, event);\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = {\n \t.dev_infos_get = nfp_flower_repr_dev_infos_get,\n \n@@ -437,6 +456,8 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {\n \n \t.flow_ops_get = nfp_flow_ops_get,\n \t.mtr_ops_get = nfp_net_mtr_ops_get,\n+\n+\t.bond_notify_member = nfp_flower_repr_bond_notify_member,\n };\n \n static uint32_t\n", "prefixes": [ "v6", "11/14" ] }