Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135470/?format=api
{ "id": 135470, "url": "http://patches.dpdk.org/api/patches/135470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231221164841.125006-16-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231221164841.125006-16-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231221164841.125006-16-stephen@networkplumber.org", "date": "2023-12-21T16:46:32", "name": "[v5,15/18] event/skeleton: replace logtype PMD with dynamic type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4b9769278b7254db4ebd4622c8785ccb6b7350ce", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231221164841.125006-16-stephen@networkplumber.org/mbox/", "series": [ { "id": 30648, "url": "http://patches.dpdk.org/api/series/30648/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30648", "date": "2023-12-21T16:46:17", "name": "Replace uses of PMD logtype", "version": 5, "mbox": "http://patches.dpdk.org/series/30648/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135470/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1358C43751;\n\tThu, 21 Dec 2023 17:50:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 103B642ED7;\n\tThu, 21 Dec 2023 17:49:21 +0100 (CET)", "from mail-pg1-f181.google.com (mail-pg1-f181.google.com\n [209.85.215.181])\n by mails.dpdk.org (Postfix) with ESMTP id 5251642ECA\n for <dev@dpdk.org>; Thu, 21 Dec 2023 17:49:19 +0100 (CET)", "by mail-pg1-f181.google.com with SMTP id\n 41be03b00d2f7-517ab9a4a13so773084a12.1\n for <dev@dpdk.org>; Thu, 21 Dec 2023 08:49:19 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n g20-20020a63e614000000b0058901200bbbsm1842456pgh.40.2023.12.21.08.49.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 21 Dec 2023 08:49:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1703177358;\n x=1703782158; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=;\n b=HmBW1bcp48/vchcECt06uFTG+0C1/GhgfKMt3FEiSWsw1jH9R3bP4CFwaPFOBR+i0c\n MhBRCEK1V5E58QMUcPKFZqyzo3nPOUQwSV/EScgT5myPlcQcHDoplgDzC3J7Mpr0DJXW\n iCiJpVz7PFpmg6kTE79yK1tDuFPGWn2HuFfa5/H35pPXBwrTE5wBwotooiBvo3zYKFBM\n Z0KYF5u43A9iKa+hTSPtXGi4b6RoFyrKq5yKvGqP1havw0w5k9FZTzpYlhKOHigUPnx5\n nvFMnhT/FAG1x98QRNhvAh2t9ato5x+azae3jBgRbiRc7bwO/lc+Wobd569aWWLS4+SO\n Xk3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1703177358; x=1703782158;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IliaEP2TEKKFe31xugoOmaiAaNmKUbc7ILbkzWi/uR4=;\n b=Ub7Cs9/JRM8c54PGTygT1cyld5hlk11rIVXKZ3w06YV1iieAUEz5UThOaX8W54iDs3\n MkHh9VyiRGkYjZ1jkggOrncSsPrcxqVbNnHNTOThdjzASGnVHQ0vO9Zc5M22rvpz6jz4\n VQBq5hHfno9t14/A0L/YhKly3F7lp6DzufUy1nBae3fhx3SUGaGtCd1RBvDMsX1mEuru\n SJqvxEVgm7bZ70kp1UjU5XDP8Wm7PZOX0aAug5A7MEr9XuZOmujdgTjVZXq8DAAhnz7i\n SFGIC10oGqqxK1j6J7tjfIjat1BhuwvHnIjihLVmt6zrGIIhRjl3sEUHLH1yzRKmuVr+\n r0KA==", "X-Gm-Message-State": "AOJu0YzeqJhTnH2dVcTmD4a/hkkE75db0Oa3BpbULFxq9u3Y66Q0nKME\n 8wU6JZPPnXiJjalK0WwDM6eNoVkoO651C1NZBak6Ug==", "X-Google-Smtp-Source": "\n AGHT+IHzRY2TP1fT8cYyIu/GGr8sClLki/Vl7Xsmy78Vr2W6jMqVblj+5+ahLRb7jOT6ynkgsSedVg==", "X-Received": "by 2002:a05:6a21:3284:b0:190:2ce8:dc87 with SMTP id\n yt4-20020a056a21328400b001902ce8dc87mr1944412pzb.60.1703177358518;\n Thu, 21 Dec 2023 08:49:18 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jerin Jacob <jerinj@marvell.com>", "Subject": "[PATCH v5 15/18] event/skeleton: replace logtype PMD with dynamic\n type", "Date": "Thu, 21 Dec 2023 08:46:32 -0800", "Message-ID": "<20231221164841.125006-16-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231221164841.125006-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20231221164841.125006-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The skeleton is supposed to match current best practices.\nChange it to use dynamic logtype.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/event/skeleton/skeleton_eventdev.c | 4 ++--\n drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++--\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c\nindex 7df032b7daa1..848b3be82c40 100644\n--- a/drivers/event/skeleton/skeleton_eventdev.c\n+++ b/drivers/event/skeleton/skeleton_eventdev.c\n@@ -457,8 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev)\n \tconst char *name;\n \n \tname = rte_vdev_device_name(vdev);\n-\tRTE_LOG(INFO, PMD, \"Initializing %s on NUMA node %d\\n\", name,\n-\t\t\trte_socket_id());\n+\tPMD_DRV_LOG(INFO, \"Initializing %s on NUMA node %d\", name, rte_socket_id());\n \treturn skeleton_eventdev_create(name, rte_socket_id(), vdev);\n }\n \n@@ -479,3 +478,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = {\n };\n \n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd);\n+RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO);\ndiff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h\nindex 9193f45f4782..9c1ed4ec5755 100644\n--- a/drivers/event/skeleton/skeleton_eventdev.h\n+++ b/drivers/event/skeleton/skeleton_eventdev.h\n@@ -8,9 +8,12 @@\n #include <eventdev_pmd_pci.h>\n #include <eventdev_pmd_vdev.h>\n \n+extern int skeleton_eventdev_logtype;\n+\n #ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG\n #define PMD_DRV_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+\trte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, \">>\")\n #else\n #define PMD_DRV_LOG(level, fmt, args...) do { } while (0)\n@@ -18,7 +21,8 @@\n #endif\n \n #define PMD_DRV_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+\trte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n \n struct skeleton_eventdev {\n \tuintptr_t reg_base;\n", "prefixes": [ "v5", "15/18" ] }