Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135400/?format=api
{ "id": 135400, "url": "http://patches.dpdk.org/api/patches/135400/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231220142152.492556-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231220142152.492556-4-bruce.richardson@intel.com", "date": "2023-12-20T14:21:52", "name": "[v3,3/3] build: RFC - add support for optional dependencies", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "66d0a132eddcf1921b82870754773028ceae8349", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30631, "url": "http://patches.dpdk.org/api/series/30631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30631", "date": "2023-12-20T14:21:49", "name": "Improve optional lib support", "version": 3, "mbox": "http://patches.dpdk.org/series/30631/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135400/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 317934374A;\n\tWed, 20 Dec 2023 15:22:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC75842E6B;\n\tWed, 20 Dec 2023 15:22:16 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 2E66242E6B\n for <dev@dpdk.org>; Wed, 20 Dec 2023 15:22:15 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Dec 2023 06:22:14 -0800", "from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.148])\n by orsmga004.jf.intel.com with ESMTP; 20 Dec 2023 06:22:13 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1703082135; x=1734618135;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ci4PhxlxAU3bj39lK6pqx7OyOmfp3aLWwzz9aH0MXNs=;\n b=O+GtHeW19H6wXqYtwql1fMcXlOJrAiO1PS3lBDyIKt31dMi8Hy2ZH5mM\n Fg2h/PbRDn/yITJq4HpyN58RJOu+V5TazDAxHd4+919IafNBY6yK5g7DX\n 9qZOaBDQ8qEpr8cT0ayYVD+CqAerl16hvN83fV8I13+5OZWS+5Mg1pkU6\n Y9oV10ZS6WT5Bt+dDCGwSzEVMZiJR38H6snSpIlNbulpUw/FnLYA2SBPg\n 9V5F4aBdUGs23GxoSBCuEWdZdOXnkt8QmCGU56BJn0UeVqujNvEgnAP+1\n iFk7JYdnCiEPo69rcsCeA18lWeLwev02ZosMGYRhttqT7LdtabayGYqPe Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10930\"; a=\"375974406\"", "E=Sophos;i=\"6.04,291,1695711600\"; d=\"scan'208\";a=\"375974406\"", "E=McAfee;i=\"6600,9927,10930\"; a=\"899730864\"", "E=Sophos;i=\"6.04,291,1695711600\"; d=\"scan'208\";a=\"899730864\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "mb@smartsharesystems.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 3/3] build: RFC - add support for optional dependencies", "Date": "Wed, 20 Dec 2023 14:21:52 +0000", "Message-Id": "<20231220142152.492556-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20231220142152.492556-1-bruce.richardson@intel.com>", "References": "<20231103162830.593702-1-bruce.richardson@intel.com>\n <20231220142152.492556-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In order to remove more libraries from the mandatory list, we need to\nhave support for optionally having a dependency from a driver or library\nto another driver or lib. This patch adds this support by adding a new\noptional_deps variable, the contents of which are added to the deps list\nif those optional dependencies are present in the build.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 7 +++++++\n lib/meson.build | 7 +++++++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex 5ba534049a..af2d8da5a8 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -127,6 +127,7 @@ foreach subpath:subdirs\n includes = [include_directories(drv_path)]\n # set up internal deps. Drivers can append/override as necessary\n deps = std_deps\n+ optional_deps = []\n # ext_deps: Stores external library dependency got\n # using dependency() (preferred) or find_library().\n # For the find_library() case (but not with dependency()) we also\n@@ -168,6 +169,12 @@ foreach subpath:subdirs\n # get dependency objs from strings\n shared_deps = ext_deps\n static_deps = ext_deps\n+ foreach d:optional_deps\n+ #if optional dep exists, add it to the deps list\n+ if is_variable('shared_rte_' + d)\n+ deps += d\n+ endif\n+ endforeach\n foreach d:deps\n if not build\n break\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 72e9138d14..733412c276 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -140,6 +140,7 @@ foreach l:libraries\n # external package/library requirements\n ext_deps = []\n deps = []\n+ optional_deps = []\n # eal is standard dependency once built\n if dpdk_conf.has('RTE_LIB_EAL')\n deps += ['eal']\n@@ -177,6 +178,12 @@ foreach l:libraries\n \n shared_deps = ext_deps\n static_deps = ext_deps\n+ foreach d:optional_deps\n+ #if optional dep exists, add it to the deps list\n+ if is_variable('shared_rte_' + d)\n+ deps += d\n+ endif\n+ endforeach\n foreach d:deps\n if not build\n break\n", "prefixes": [ "v3", "3/3" ] }