Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135398/?format=api
{ "id": 135398, "url": "http://patches.dpdk.org/api/patches/135398/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231220142152.492556-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231220142152.492556-2-bruce.richardson@intel.com", "date": "2023-12-20T14:21:50", "name": "[v3,1/3] build: track mandatory rather than optional libs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "545bf9d8720e4c26e0097d62702d61edfd21a8ed", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30631, "url": "http://patches.dpdk.org/api/series/30631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30631", "date": "2023-12-20T14:21:49", "name": "Improve optional lib support", "version": 3, "mbox": "http://patches.dpdk.org/series/30631/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135398/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135398/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B41054374A;\n\tWed, 20 Dec 2023 15:22:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3624B410E4;\n\tWed, 20 Dec 2023 15:22:10 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id D33A040EE4\n for <dev@dpdk.org>; Wed, 20 Dec 2023 15:22:08 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Dec 2023 06:22:08 -0800", "from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.148])\n by orsmga004.jf.intel.com with ESMTP; 20 Dec 2023 06:22:07 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1703082129; x=1734618129;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=L/8iQkGJxehxmmE1+JQelzs2Elo8OI74gyaFId/sFmY=;\n b=h/9Fj0I8DQP17GfS2QrqGmRYjIJQrIIzR9siYHt34V3Yq1om+rh31Lqh\n R7Qe4AasJAoJOwJrpy8h70pb4PFeUNj+6HGDSxlWpI8I+BJSXmnXWk3FJ\n h3w8KycrXQQHkyX85ZFDa0bGdORTDQggM2rJbwbgF23RFJBp3dXPalZXq\n yTZ6sOU2/HiQ6t7qpyRIn57w6Xw//bghWtjDfDbPAD1rhoz9fadRmPcrP\n VL08M+h9V65/0nVGTuYh+KOHTyrbyKqiGHQGCgy03u7O5VT3AzkatC2gT\n 5ZQUhJnKA8Z3/Toi/WMfibjGxJPPIas/Mg5EzE+gZyuFvJWB9tu62WbrQ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10930\"; a=\"375974396\"", "E=Sophos;i=\"6.04,291,1695711600\"; d=\"scan'208\";a=\"375974396\"", "E=McAfee;i=\"6600,9927,10930\"; a=\"899730849\"", "E=Sophos;i=\"6.04,291,1695711600\"; d=\"scan'208\";a=\"899730849\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "mb@smartsharesystems.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 1/3] build: track mandatory rather than optional libs", "Date": "Wed, 20 Dec 2023 14:21:50 +0000", "Message-Id": "<20231220142152.492556-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20231220142152.492556-1-bruce.richardson@intel.com>", "References": "<20231103162830.593702-1-bruce.richardson@intel.com>\n <20231220142152.492556-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "DPDK now has more optional libraries than mandatory ones, so invert the\nlist stored in the meson.build file from the optional ones to the\n\"always_enable\" ones. As well as being a shorter list:\n\n* we can remove the loop building up the \"always_enable\" list\n dynamically from the optional list\n* it better aligns with the drivers/meson.build file which maintains an\n always_enable list.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/meson.build | 70 +++++++++++++++++--------------------------------\n 1 file changed, 24 insertions(+), 46 deletions(-)", "diff": "diff --git a/lib/meson.build b/lib/meson.build\nindex 6c143ce5a6..8c922d3097 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -75,52 +75,29 @@ if is_ms_compiler\n ]\n endif\n \n-optional_libs = [\n- 'bbdev',\n- 'bitratestats',\n- 'bpf',\n- 'cfgfile',\n- 'compressdev',\n- 'cryptodev',\n- 'dispatcher',\n- 'distributor',\n- 'dmadev',\n- 'efd',\n- 'eventdev',\n- 'gpudev',\n- 'graph',\n- 'gro',\n- 'gso',\n- 'ip_frag',\n- 'ipsec',\n- 'jobstats',\n- 'latencystats',\n- 'member',\n- 'metrics',\n- 'mldev',\n- 'node',\n- 'pcapng',\n- 'pdcp',\n- 'pdump',\n- 'pipeline',\n- 'port',\n- 'power',\n- 'rawdev',\n- 'regexdev',\n- 'reorder',\n- 'sched',\n- 'security',\n- 'table',\n- 'vhost',\n+always_enable = [\n+ 'acl',\n+ 'cmdline',\n+ 'eal',\n+ 'ethdev',\n+ 'fib',\n+ 'hash',\n+ 'kvargs',\n+ 'log',\n+ 'lpm',\n+ 'mbuf',\n+ 'mempool',\n+ 'meter',\n+ 'net',\n+ 'pci',\n+ 'rcu',\n+ 'rib',\n+ 'ring',\n+ 'stack',\n+ 'telemetry',\n+ 'timer',\n ]\n \n-always_enable = []\n-foreach l:libraries\n- if not optional_libs.contains(l)\n- always_enable += l\n- endif\n-endforeach\n-\n enable_deprecated_libs = []\n foreach l:run_command(list_dir_globs, get_option('enable_deprecated_libs'),\n check: true).stdout().split()\n@@ -136,9 +113,10 @@ enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true\n require_libs = true\n if enable_libs.length() == 0\n require_libs = false\n- enable_libs += optional_libs\n+ enable_libs = libraries\n+else\n+ enable_libs += always_enable\n endif\n-enable_libs += always_enable\n \n default_cflags = machine_args\n default_cflags += ['-DALLOW_EXPERIMENTAL_API']\n", "prefixes": [ "v3", "1/3" ] }