Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135329/?format=api
{ "id": 135329, "url": "http://patches.dpdk.org/api/patches/135329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231219032826.4814-5-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231219032826.4814-5-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231219032826.4814-5-sivaprasad.tummala@amd.com", "date": "2023-12-19T03:28:23", "name": "[v2,4/6] examples/ipsec-secgw: fix lcore ID restriction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f9ad0cbd2777bc8119e0dd0a5b165d25f179439c", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231219032826.4814-5-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 30610, "url": "http://patches.dpdk.org/api/series/30610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30610", "date": "2023-12-19T03:28:19", "name": "fix lcore ID restriction", "version": 2, "mbox": "http://patches.dpdk.org/series/30610/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135329/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135329/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCB794373B;\n\tTue, 19 Dec 2023 04:29:53 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5EA3E42E15;\n\tTue, 19 Dec 2023 04:29:44 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67])\n by mails.dpdk.org (Postfix) with ESMTP id EFF764027B;\n Tue, 19 Dec 2023 04:29:39 +0100 (CET)", "from CY5P221CA0125.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:1f::31)\n by DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec\n 2023 03:29:35 +0000", "from CY4PEPF0000EE34.namprd05.prod.outlook.com\n (2603:10b6:930:1f:cafe::93) by CY5P221CA0125.outlook.office365.com\n (2603:10b6:930:1f::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend\n Transport; Tue, 19 Dec 2023 03:29:35 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CY4PEPF0000EE34.mail.protection.outlook.com (10.167.242.40) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:29:35 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.34; Mon, 18 Dec 2023 21:29:01 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Fq6oJLNw7ZUa2QTOzgGfTFLiVjhwYarqka91Lsy6g79iNIGGXuiS8cHxFQny74a1Y3nObeNehYw+xQ/muOzsMWFE8Eoc/jJdoWxd8la/KivtupSaAS8NI4/ncwdSR5xq8XGsTgUMSZPfVzQtXTqMF/GDfgqMtJ1EHWZ70WG2n5JgxXJbBihjRB8l8nRRbKcObHIN0TCUFS3Tcabt8xLvnXUMW203rzbURYFJ8kJWK2Uh4dY9cHcn5nLy7a4R5JDqzqRzK55Utt+X00SgM5+hxx9d6mrDz9pdBabkbovrIZ1juCMhoqD3Yt/NwHzTAkfgQ3JL1PtKyelVOVIri/DmLg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=7SlHXDPxt2WYHbhj7Rgx+Bub8Fy3GSxeEUL5rVh7qCI=;\n b=M82bqAS6gh5++LxP2t+hQrjNlj2UvTxiV62agB5XASETTRbQSDL9j0+slpPuNJMVTIR0qFTLaxhqWT5eqpmxC/mMcOyzKCwNsIiqGw9k69tPA5tDNSNuNE5c3EbpyLprKUrRGgUP3P8i73gK43RbE5vRKx5fsxUUK8mQN3oT/1PZpd5GmhjP4Ber8pitxlyQhqWrRkZjBFxqB2hrpy+vl2T5CTcW4JUHb48UpvF6w2WYFylHpUA7ibTR7lQ2eXtRyEKh0xsXr8T9Sm1mUy7d2EuEZu1sv+uM6MiSySaGEbkUsBBl06NbA9H3hlED1ev67IO0IHfcN9/ABYTbT1aiAA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7SlHXDPxt2WYHbhj7Rgx+Bub8Fy3GSxeEUL5rVh7qCI=;\n b=XoXP1TO308lfxwTjvR3aVV2kQMpa63iiVmWk694GHN/E4/uCAdgw4fI1IxcqG/BJuNNchWrE46IB7edTaM1WmEkVY7DpURQloeVLVLGJvNV1D6aKgA78Qai4hy35y139VeGnsfuP4kEu3wDrAPqViBwPSSiXvjdiZW/DKvXSVLk=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>", "CC": "<dev@dpdk.org>, <sergio.gonzalez.monroy@intel.com>, <stable@dpdk.org>", "Subject": "[PATCH v2 4/6] examples/ipsec-secgw: fix lcore ID restriction", "Date": "Tue, 19 Dec 2023 04:28:23 +0100", "Message-ID": "<20231219032826.4814-5-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231219032826.4814-1-sivaprasad.tummala@amd.com>", "References": "<20231218074905.42749-1-sivaprasad.tummala@amd.com>\n <20231219032826.4814-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000EE34:EE_|DS7PR12MB5744:EE_", "X-MS-Office365-Filtering-Correlation-Id": "055f760d-63de-4e5b-7c1e-08dc0042b91d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ueHgoEeiCv4+dk/fvI5vO7Z2fuf3BvXQDqMq8QOYyTfNocnvxhz+AzBOlLNJiVWQDJVn40pJX2ZxuoY21jpqxmq+zFF4wplaLVH/Xs2UI/M3MKIsJd/RplN7R030MxyXwf/G2tokU5J16rYSdk7MkILZE3/18Dxf1lMSxgZ6wi1J+DZQ29PX87nagoBP2l2NSPpcl6EMP1Jj2TNh0YIPdRt38nUTsbViUTqAE6fVkyjEErrbMgr94fl9ajBJ0TBcTGqNljwbGrjGLm0lfx33JmnVe1K1glji+x9dyKYj6t7o6JvbrVOAtMIJ+brjHIKdDYVcJDZambVpF5nhe10njuestdkgNWiL1yyRotG0yIxxfdMRd5vhQQKsdnIQjqg6zrCNGFHWszO0jeO8GecA0knkOVOlqQHQtvUq4WtC3y9bWQsUQfR9aI3kUBmG8EC/Zs3B98/6Ju2zbsKSrE4yHOCst1VgyohbRA9eYdV5148GHz+e2MKp8Uw0psl8+foq+I3YTIBWGGicVse/V/T7xA6IqLEPZtzxRfigZWMND+XFnGoQbTiHSUqixvjBSy3ALwPV+CL6NQWJ0mup5N7h4liyNvv82Ql0RHHQ3TXnVwa7y6mEbnlIkVnMFkkQ9kOxJDQL/DvEWv3tZSo5o/UCGe+WmVXM86xME7640danjlw6gd8fcXOGIHeVwGBCV9hds5mv/UDtyJAVYrT4587qsN7fMrpD1ZB6sfT4cgNnq+jCocpCCAwK7FyivvMmRXAiA+ZjQo6srpAcKxY1ki8c+gqfNqYO//nKmX/2n+3cvAoqy/4axQ2Z2fHlKbARrKWA", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(346002)(396003)(39860400002)(136003)(376002)(230273577357003)(230922051799003)(230173577357003)(1800799012)(451199024)(186009)(82310400011)(64100799003)(36840700001)(46966006)(40470700004)(40460700003)(6666004)(2616005)(16526019)(426003)(26005)(1076003)(336012)(36860700001)(8676002)(70586007)(4326008)(5660300002)(44832011)(83380400001)(41300700001)(7416002)(2906002)(478600001)(316002)(70206006)(81166007)(8936002)(54906003)(110136005)(356005)(47076005)(82740400003)(86362001)(36756003)(40480700001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Dec 2023 03:29:35.2389 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 055f760d-63de-4e5b-7c1e-08dc0042b91d", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000EE34.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS7PR12MB5744", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently the config option allows lcore IDs up to 255,\nirrespective of RTE_MAX_LCORES and needs to be fixed.\n\nThe patch allows config options based on DPDK config.\n\nFixes: d299106e8e31 (\"examples/ipsec-secgw: add IPsec sample application\")\nCc: sergio.gonzalez.monroy@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\n---\n examples/ipsec-secgw/event_helper.h | 2 +-\n examples/ipsec-secgw/ipsec-secgw.c | 16 +++++++++-------\n examples/ipsec-secgw/ipsec.c | 2 +-\n 3 files changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/event_helper.h b/examples/ipsec-secgw/event_helper.h\nindex dfb81bfcf1..9923700f03 100644\n--- a/examples/ipsec-secgw/event_helper.h\n+++ b/examples/ipsec-secgw/event_helper.h\n@@ -102,7 +102,7 @@ struct eh_event_link_info {\n \t\t/**< Event port ID */\n \tuint8_t eventq_id;\n \t\t/**< Event queue to be linked to the port */\n-\tuint8_t lcore_id;\n+\tuint16_t lcore_id;\n \t\t/**< Lcore to be polling on this port */\n };\n \ndiff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex bf98d2618b..6f550db05c 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -221,7 +221,7 @@ static const char *cfgfile;\n struct lcore_params {\n \tuint16_t port_id;\n \tuint8_t queue_id;\n-\tuint8_t lcore_id;\n+\tuint16_t lcore_id;\n } __rte_cache_aligned;\n \n static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];\n@@ -810,7 +810,7 @@ check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)\n static int32_t\n check_poll_mode_params(struct eh_conf *eh_conf)\n {\n-\tuint8_t lcore;\n+\tuint16_t lcore;\n \tuint16_t portid;\n \tuint16_t i;\n \tint32_t socket_id;\n@@ -829,13 +829,13 @@ check_poll_mode_params(struct eh_conf *eh_conf)\n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n \t\tif (!rte_lcore_is_enabled(lcore)) {\n-\t\t\tprintf(\"error: lcore %hhu is not enabled in \"\n+\t\t\tprintf(\"error: lcore %hu is not enabled in \"\n \t\t\t\t\"lcore mask\\n\", lcore);\n \t\t\treturn -1;\n \t\t}\n \t\tsocket_id = rte_lcore_to_socket_id(lcore);\n \t\tif (socket_id != 0 && numa_on == 0) {\n-\t\t\tprintf(\"warning: lcore %hhu is on socket %d \"\n+\t\t\tprintf(\"warning: lcore %hu is on socket %d \"\n \t\t\t\t\"with numa off\\n\",\n \t\t\t\tlcore, socket_id);\n \t\t}\n@@ -870,7 +870,7 @@ static int32_t\n init_lcore_rx_queues(void)\n {\n \tuint16_t i, nb_rx_queue;\n-\tuint8_t lcore;\n+\tuint16_t lcore;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tlcore = lcore_params[i].lcore_id;\n@@ -1051,6 +1051,8 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint32_t i;\n \tuint32_t size;\n+\tunsigned int max_fld[_NUM_FLD] = {RTE_MAX_ETHPORTS,\n+\t\t\t\t\t255, RTE_MAX_LCORE};\n \n \tnb_lcore_params = 0;\n \n@@ -1071,7 +1073,7 @@ parse_config(const char *q_arg)\n \t\tfor (i = 0; i < _NUM_FLD; i++) {\n \t\t\terrno = 0;\n \t\t\tint_fld[i] = strtoul(str_fld[i], &end, 0);\n-\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > 255)\n+\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > max_fld[i])\n \t\t\t\treturn -1;\n \t\t}\n \t\tif (nb_lcore_params >= MAX_LCORE_PARAMS) {\n@@ -1084,7 +1086,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n \t\t\t(uint8_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n-\t\t\t(uint8_t)int_fld[FLD_LCORE];\n+\t\t\t(uint16_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\n \t}\n \tlcore_params = lcore_params_array;\ndiff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c\nindex f5cec4a928..5ebb71bb9a 100644\n--- a/examples/ipsec-secgw/ipsec.c\n+++ b/examples/ipsec-secgw/ipsec.c\n@@ -259,7 +259,7 @@ create_lookaside_session(struct ipsec_ctx *ipsec_ctx_lcore[],\n \t\t\tcontinue;\n \n \t\t/* Looking for cryptodev, which can handle this SA */\n-\t\tkey.lcore_id = (uint8_t)lcore_id;\n+\t\tkey.lcore_id = (uint16_t)lcore_id;\n \t\tkey.cipher_algo = (uint8_t)sa->cipher_algo;\n \t\tkey.auth_algo = (uint8_t)sa->auth_algo;\n \t\tkey.aead_algo = (uint8_t)sa->aead_algo;\n", "prefixes": [ "v2", "4/6" ] }