Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135289/?format=api
{ "id": 135289, "url": "http://patches.dpdk.org/api/patches/135289/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231218172206.8488-5-jspewock@iol.unh.edu/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231218172206.8488-5-jspewock@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20231218172206.8488-5-jspewock@iol.unh.edu", "date": "2023-12-18T17:22:03", "name": "[v4,3/7] dts: add optional packet filtering to scapy sniffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "25c171ff794dd3f1d7409bc9f8a0bd23a380eafb", "submitter": { "id": 2772, "url": "http://patches.dpdk.org/api/people/2772/?format=api", "name": "Jeremy Spewock", "email": "jspewock@iol.unh.edu" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231218172206.8488-5-jspewock@iol.unh.edu/mbox/", "series": [ { "id": 30598, "url": "http://patches.dpdk.org/api/series/30598/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30598", "date": "2023-12-18T17:22:03", "name": null, "version": 4, "mbox": "http://patches.dpdk.org/series/30598/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135289/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 490194373D;\n\tMon, 18 Dec 2023 18:23:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E250742DB6;\n\tMon, 18 Dec 2023 18:23:38 +0100 (CET)", "from mail-pl1-f228.google.com (mail-pl1-f228.google.com\n [209.85.214.228])\n by mails.dpdk.org (Postfix) with ESMTP id 4318A40E09\n for <dev@dpdk.org>; Mon, 18 Dec 2023 18:23:36 +0100 (CET)", "by mail-pl1-f228.google.com with SMTP id\n d9443c01a7336-1d3cfb1568eso5018065ad.1\n for <dev@dpdk.org>; Mon, 18 Dec 2023 09:23:36 -0800 (PST)", "from postal.iol.unh.edu (postal.iol.unh.edu.\n [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id\n 11-20020a170902c20b00b001bb988ac24fsm1148500pll.45.2023.12.18.09.23.35\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 18 Dec 2023 09:23:35 -0800 (PST)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f])\n by postal.iol.unh.edu (Postfix) with ESMTP id 5A6C8605C313;\n Mon, 18 Dec 2023 12:23:34 -0500 (EST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1702920215; x=1703525015; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=giA95QdZIp5kv7JDJIqN6lm5NqseqZ941YBXykN+cJE=;\n b=Y2KCNCJ7emV7IBMinabMX15LbyRBZS7E8NisjkDVWHZgDceQ2kD3pkIQmvLhCm6abB\n GeSUvr83tT/OVJpzHUaNk2CAORr4c5dCRhuhJHKgXcRROB2sgA8zFLEpb+uEAoe4l27R\n QkI4WU7nalaNpyWb1eXIU66R7akB+nClmyQ8E=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702920215; x=1703525015;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=giA95QdZIp5kv7JDJIqN6lm5NqseqZ941YBXykN+cJE=;\n b=vffxbABWT8+JCSFLeUUXAa9Fxab0zsIWw6OYpu+A6AFxQOKc8jcwLKxTIkXSreUYhA\n sEyClmTxJy0RRWcf2htQ2bSApySohMf8xvUd1iFzCapsi/hDARhweryk2k3ewuOIHkT4\n GjQsHZUJT8bNDDa3lpB98joF7b2PptVhCLZOYGXqrqqFJBPGyGTflcfMgKX/TDBzsh6o\n qqysHZL0d35RKClIDLNANmja0z9WT1RD1a8C32EnEOAY2KEIMumDsq9gy1Lja7V4u0yI\n 0Jijit4oLS/VbnPf1VLY7I/gco7VEOyB594ICi4B1YQscie71ncHD/5MyIhFdpY7VG6y\n X7dg==", "X-Gm-Message-State": "AOJu0Yw399UN9+lHNr1q26GJfNLDEF5m60DCbLEMfEBDIVsu/WJY8AJX\n m/bxJRf3k1ysXFBVzPLser+hRaLeldT13gneBYJr+vAD7DnpMcUP+qEQ3Pc0YSPc7A==", "X-Google-Smtp-Source": "\n AGHT+IFFpuiRb2GwUHiJd7dKYABHdAMcuH8RWPW6LgbyjJg42vj5H6yKd+MtuZgFAxgoE0TQgzKj+KQ5nN5Q", "X-Received": "by 2002:a17:902:6544:b0:1d3:797f:fceb with SMTP id\n d4-20020a170902654400b001d3797ffcebmr5834897pln.126.1702920215377;\n Mon, 18 Dec 2023 09:23:35 -0800 (PST)", "X-Relaying-Domain": "iol.unh.edu", "From": "jspewock@iol.unh.edu", "To": "Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu,\n paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com,\n andrew.rybchenko@oktetlabs.ru", "Cc": "dev@dpdk.org,\n\tJeremy Spewock <jspewock@iol.unh.edu>", "Subject": "[PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer", "Date": "Mon, 18 Dec 2023 12:22:03 -0500", "Message-ID": "<20231218172206.8488-5-jspewock@iol.unh.edu>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231113202833.12900-1-jspewock@iol.unh.edu>", "References": "<20231113202833.12900-1-jspewock@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jeremy Spewock <jspewock@iol.unh.edu>\n\nAdded the options to filter out LLDP and ARP packets when\nsniffing for packets with scapy. This was done using BPF filters to\nensure that the noise these packets provide does not interfere with test\ncases.\n\nSigned-off-by: Jeremy Spewock <jspewock@iol.unh.edu>\n---\n dts/framework/test_suite.py | 14 ++++++++--\n .../capturing_traffic_generator.py | 22 ++++++++++++++-\n dts/framework/testbed_model/scapy.py | 28 ++++++++++++++++++-\n dts/framework/testbed_model/tg_node.py | 12 ++++++--\n 4 files changed, 70 insertions(+), 6 deletions(-)", "diff": "diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py\nindex 4a7907ec33..6dfa570041 100644\n--- a/dts/framework/test_suite.py\n+++ b/dts/framework/test_suite.py\n@@ -27,6 +27,7 @@\n from .settings import SETTINGS\n from .test_result import BuildTargetResult, Result, TestCaseResult, TestSuiteResult\n from .testbed_model import SutNode, TGNode\n+from .testbed_model.capturing_traffic_generator import PacketFilteringConfig\n from .testbed_model.hw.port import Port, PortLink\n from .utils import get_packet_summaries\n \n@@ -149,7 +150,12 @@ def configure_testbed_ipv4(self, restore: bool = False) -> None:\n def _configure_ipv4_forwarding(self, enable: bool) -> None:\n self.sut_node.configure_ipv4_forwarding(enable)\n \n- def send_packet_and_capture(self, packet: Packet, duration: float = 1) -> list[Packet]:\n+ def send_packet_and_capture(\n+ self,\n+ packet: Packet,\n+ filter_config: PacketFilteringConfig = PacketFilteringConfig(),\n+ duration: float = 1,\n+ ) -> list[Packet]:\n \"\"\"\n Send a packet through the appropriate interface and\n receive on the appropriate interface.\n@@ -158,7 +164,11 @@ def send_packet_and_capture(self, packet: Packet, duration: float = 1) -> list[P\n \"\"\"\n packet = self._adjust_addresses(packet)\n return self.tg_node.send_packet_and_capture(\n- packet, self._tg_port_egress, self._tg_port_ingress, duration\n+ packet,\n+ self._tg_port_egress,\n+ self._tg_port_ingress,\n+ filter_config,\n+ duration,\n )\n \n def get_expected_packet(self, packet: Packet) -> Packet:\ndiff --git a/dts/framework/testbed_model/capturing_traffic_generator.py b/dts/framework/testbed_model/capturing_traffic_generator.py\nindex e6512061d7..c40b030fe4 100644\n--- a/dts/framework/testbed_model/capturing_traffic_generator.py\n+++ b/dts/framework/testbed_model/capturing_traffic_generator.py\n@@ -11,6 +11,7 @@\n \n import uuid\n from abc import abstractmethod\n+from dataclasses import dataclass\n \n import scapy.utils # type: ignore[import]\n from scapy.packet import Packet # type: ignore[import]\n@@ -29,6 +30,19 @@ def _get_default_capture_name() -> str:\n return str(uuid.uuid4())\n \n \n+@dataclass(slots=True)\n+class PacketFilteringConfig:\n+ \"\"\"The supported filtering options for :class:`CapturingTrafficGenerator`.\n+\n+ Attributes:\n+ no_lldp: If :data:`True`, LLDP packets will be filtered out when capturing.\n+ no_arp: If :data:`True`, ARP packets will be filtered out when capturing.\n+ \"\"\"\n+\n+ no_lldp: bool = True\n+ no_arp: bool = True\n+\n+\n class CapturingTrafficGenerator(TrafficGenerator):\n \"\"\"Capture packets after sending traffic.\n \n@@ -51,6 +65,7 @@ def send_packet_and_capture(\n packet: Packet,\n send_port: Port,\n receive_port: Port,\n+ filter_config: PacketFilteringConfig,\n duration: float,\n capture_name: str = _get_default_capture_name(),\n ) -> list[Packet]:\n@@ -64,6 +79,7 @@ def send_packet_and_capture(\n packet: The packet to send.\n send_port: The egress port on the TG node.\n receive_port: The ingress port in the TG node.\n+ filter_config: Filters to apply when capturing packets.\n duration: Capture traffic for this amount of time after sending the packet.\n capture_name: The name of the .pcap file where to store the capture.\n \n@@ -71,7 +87,7 @@ def send_packet_and_capture(\n A list of received packets. May be empty if no packets are captured.\n \"\"\"\n return self.send_packets_and_capture(\n- [packet], send_port, receive_port, duration, capture_name\n+ [packet], send_port, receive_port, filter_config, duration, capture_name\n )\n \n def send_packets_and_capture(\n@@ -79,6 +95,7 @@ def send_packets_and_capture(\n packets: list[Packet],\n send_port: Port,\n receive_port: Port,\n+ filter_config: PacketFilteringConfig,\n duration: float,\n capture_name: str = _get_default_capture_name(),\n ) -> list[Packet]:\n@@ -92,6 +109,7 @@ def send_packets_and_capture(\n packets: The packets to send.\n send_port: The egress port on the TG node.\n receive_port: The ingress port in the TG node.\n+ filter_config: Filters to apply when capturing packets.\n duration: Capture traffic for this amount of time after sending the packets.\n capture_name: The name of the .pcap file where to store the capture.\n \n@@ -106,6 +124,7 @@ def send_packets_and_capture(\n packets,\n send_port,\n receive_port,\n+ filter_config,\n duration,\n )\n \n@@ -119,6 +138,7 @@ def _send_packets_and_capture(\n packets: list[Packet],\n send_port: Port,\n receive_port: Port,\n+ filter_config: PacketFilteringConfig,\n duration: float,\n ) -> list[Packet]:\n \"\"\"\ndiff --git a/dts/framework/testbed_model/scapy.py b/dts/framework/testbed_model/scapy.py\nindex 9083e92b3d..94b0af7c6f 100644\n--- a/dts/framework/testbed_model/scapy.py\n+++ b/dts/framework/testbed_model/scapy.py\n@@ -30,6 +30,7 @@\n \n from .capturing_traffic_generator import (\n CapturingTrafficGenerator,\n+ PacketFilteringConfig,\n _get_default_capture_name,\n )\n from .hw.port import Port\n@@ -69,6 +70,7 @@ def scapy_send_packets_and_capture(\n send_iface: str,\n recv_iface: str,\n duration: float,\n+ sniff_filter: str,\n ) -> list[bytes]:\n \"\"\"RPC function to send and capture packets.\n \n@@ -90,6 +92,7 @@ def scapy_send_packets_and_capture(\n iface=recv_iface,\n store=True,\n started_callback=lambda *args: scapy.all.sendp(scapy_packets, iface=send_iface),\n+ filter=sniff_filter,\n )\n sniffer.start()\n time.sleep(duration)\n@@ -249,16 +252,38 @@ def _send_packets(self, packets: list[Packet], port: Port) -> None:\n packets = [packet.build() for packet in packets]\n self.rpc_server_proxy.scapy_send_packets(packets, port.logical_name)\n \n+ def _create_packet_filter(self, filter_config: PacketFilteringConfig) -> str:\n+ \"\"\"Combines filter settings from `filter_config` into a BPF that scapy can use.\n+\n+ Scapy allows for the use of Berkeley Packet Filters (BPFs) to filter what packets are\n+ collected based on various attributes of the packet.\n+\n+ Args:\n+ filter_config: Config class that specifies which filters should be applied.\n+\n+ Returns:\n+ A string representing the combination of BPF filters to be passed to scapy. For\n+ example:\n+\n+ \"ether[12:2] != 0x88cc && ether[12:2] != 0x0806\"\n+ \"\"\"\n+ bpf_filter: list[str] = []\n+ if filter_config.no_arp:\n+ bpf_filter.append(\"ether[12:2] != 0x0806\")\n+ if filter_config.no_lldp:\n+ bpf_filter.append(\"ether[12:2] != 0x88cc\")\n+ return \" && \".join(bpf_filter)\n+\n def _send_packets_and_capture(\n self,\n packets: list[Packet],\n send_port: Port,\n receive_port: Port,\n+ filter_config: PacketFilteringConfig,\n duration: float,\n capture_name: str = _get_default_capture_name(),\n ) -> list[Packet]:\n binary_packets = [packet.build() for packet in packets]\n-\n xmlrpc_packets: list[\n xmlrpc.client.Binary\n ] = self.rpc_server_proxy.scapy_send_packets_and_capture(\n@@ -266,6 +291,7 @@ def _send_packets_and_capture(\n send_port.logical_name,\n receive_port.logical_name,\n duration,\n+ self._create_packet_filter(filter_config),\n ) # type: ignore[assignment]\n \n scapy_packets = [Ether(packet.data) for packet in xmlrpc_packets]\ndiff --git a/dts/framework/testbed_model/tg_node.py b/dts/framework/testbed_model/tg_node.py\nindex 79a55663b5..475dc2968d 100644\n--- a/dts/framework/testbed_model/tg_node.py\n+++ b/dts/framework/testbed_model/tg_node.py\n@@ -23,7 +23,10 @@\n )\n from framework.exception import ConfigurationError\n \n-from .capturing_traffic_generator import CapturingTrafficGenerator\n+from .capturing_traffic_generator import (\n+ CapturingTrafficGenerator,\n+ PacketFilteringConfig,\n+)\n from .hw.port import Port\n from .node import Node\n \n@@ -53,6 +56,7 @@ def send_packet_and_capture(\n packet: Packet,\n send_port: Port,\n receive_port: Port,\n+ filter_config: PacketFilteringConfig = PacketFilteringConfig(),\n duration: float = 1,\n ) -> list[Packet]:\n \"\"\"Send a packet, return received traffic.\n@@ -71,7 +75,11 @@ def send_packet_and_capture(\n A list of received packets. May be empty if no packets are captured.\n \"\"\"\n return self.traffic_generator.send_packet_and_capture(\n- packet, send_port, receive_port, duration\n+ packet,\n+ send_port,\n+ receive_port,\n+ filter_config,\n+ duration,\n )\n \n def close(self) -> None:\n", "prefixes": [ "v4", "3/7" ] }