Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135273/?format=api
{ "id": 135273, "url": "http://patches.dpdk.org/api/patches/135273/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231218143805.1500121-9-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231218143805.1500121-9-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231218143805.1500121-9-david.marchand@redhat.com", "date": "2023-12-18T14:37:57", "name": "[v4,08/14] lib: simplify multilines log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd445f431858868b650aff6e781594370b852077", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231218143805.1500121-9-david.marchand@redhat.com/mbox/", "series": [ { "id": 30589, "url": "http://patches.dpdk.org/api/series/30589/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30589", "date": "2023-12-18T14:37:50", "name": "Detect superfluous newline in logs", "version": 4, "mbox": "http://patches.dpdk.org/series/30589/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135273/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135273/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A659743735;\n\tMon, 18 Dec 2023 15:39:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2F96F42D7D;\n\tMon, 18 Dec 2023 15:38:57 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id C20E342D87\n for <dev@dpdk.org>; Mon, 18 Dec 2023 15:38:53 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-557-Ti1uQ_78OQqoTFHJ8-Dosg-1; Mon, 18 Dec 2023 09:38:47 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC0A9833AE1;\n Mon, 18 Dec 2023 14:38:45 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.218])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 86BF3112131D;\n Mon, 18 Dec 2023 14:38:43 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1702910333;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MrIZVyohTZVMGcHVkxLqZoY+XxvpTjWw5fdss5PRQsw=;\n b=KoA0jLTQGIrznUz7ODU5UiqBqyRzvD6UZw2n3fOsRAXSqPi8J8XwkPEcb3cbIQR5fveum/\n d6xck+OkhyJz/LgLUeCdtMkayHC78rEuvXnBswmDj4sQW8EtX0Cjjd7kB8jjigANTXgenz\n lI7iVyROdpyy2mVHxwEPGdMTR3NDcWk=", "X-MC-Unique": "Ti1uQ_78OQqoTFHJ8-Dosg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v4 08/14] lib: simplify multilines log messages", "Date": "Mon, 18 Dec 2023 15:37:57 +0100", "Message-ID": "<20231218143805.1500121-9-david.marchand@redhat.com>", "In-Reply-To": "<20231218143805.1500121-1-david.marchand@redhat.com>", "References": "<20231117131824.1977792-1-david.marchand@redhat.com>\n <20231218143805.1500121-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Those error log messages don't need to span on multiple lines.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\nChanges since RFC v2:\n- fixed format string crossing line boundaries,\n\n---\n lib/acl/tb_mem.c | 4 ++--\n lib/bpf/bpf_stub.c | 6 ++----\n lib/eal/windows/eal_hugepages.c | 4 ++--\n lib/ethdev/rte_ethdev.c | 12 ++++--------\n 4 files changed, 10 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/acl/tb_mem.c b/lib/acl/tb_mem.c\nindex 6a9d96aaed..4ee65b23da 100644\n--- a/lib/acl/tb_mem.c\n+++ b/lib/acl/tb_mem.c\n@@ -26,8 +26,8 @@ tb_pool(struct tb_mem_pool *pool, size_t sz)\n \tsize = sz + pool->alignment - 1;\n \tblock = calloc(1, size + sizeof(*pool->block));\n \tif (block == NULL) {\n-\t\tRTE_LOG(ERR, ACL, \"%s(%zu)\\n failed, currently allocated \"\n-\t\t\t\"by pool: %zu bytes\\n\", __func__, sz, pool->alloc);\n+\t\tRTE_LOG(ERR, ACL, \"%s(%zu) failed, currently allocated by pool: %zu bytes\\n\",\n+\t\t\t__func__, sz, pool->alloc);\n \t\tsiglongjmp(pool->fail, -ENOMEM);\n \t\treturn NULL;\n \t}\ndiff --git a/lib/bpf/bpf_stub.c b/lib/bpf/bpf_stub.c\nindex ebc5343896..83c2203622 100644\n--- a/lib/bpf/bpf_stub.c\n+++ b/lib/bpf/bpf_stub.c\n@@ -19,8 +19,7 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,\n \t\treturn NULL;\n \t}\n \n-\tRTE_BPF_LOG(ERR, \"%s() is not supported with current config\\n\"\n-\t\t\"rebuild with libelf installed\\n\",\n+\tRTE_BPF_LOG(ERR, \"%s() is not supported, rebuild with libelf installed\\n\",\n \t\t__func__);\n \trte_errno = ENOTSUP;\n \treturn NULL;\n@@ -36,8 +35,7 @@ rte_bpf_convert(const struct bpf_program *prog)\n \t\treturn NULL;\n \t}\n \n-\tRTE_BPF_LOG(ERR, \"%s() is not supported with current config\\n\"\n-\t\t\"rebuild with libpcap installed\\n\",\n+\tRTE_BPF_LOG(ERR, \"%s() is not supported, rebuild with libpcap installed\\n\",\n \t\t__func__);\n \trte_errno = ENOTSUP;\n \treturn NULL;\ndiff --git a/lib/eal/windows/eal_hugepages.c b/lib/eal/windows/eal_hugepages.c\nindex b007dceb39..775c67e4c4 100644\n--- a/lib/eal/windows/eal_hugepages.c\n+++ b/lib/eal/windows/eal_hugepages.c\n@@ -105,8 +105,8 @@ int\n eal_hugepage_info_init(void)\n {\n \tif (hugepage_claim_privilege() < 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Cannot claim hugepage privilege\\n\"\n-\t\t\"Verify that large-page support privilege is assigned to the current user\\n\");\n+\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\"Cannot claim hugepage privilege, check large-page support privilege\\n\");\n \t\treturn -1;\n \t}\n \ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex b9d99ece15..9dd0efa9d8 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -6709,8 +6709,7 @@ rte_eth_ip_reassembly_capability_get(uint16_t port_id,\n \n \tif (dev->data->dev_configured == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Device with port_id=%u is not configured.\\n\"\n-\t\t\t\"Cannot get IP reassembly capability\\n\",\n+\t\t\t\"port_id=%u is not configured, cannot get IP reassembly capability\\n\",\n \t\t\tport_id);\n \t\treturn -EINVAL;\n \t}\n@@ -6745,8 +6744,7 @@ rte_eth_ip_reassembly_conf_get(uint16_t port_id,\n \n \tif (dev->data->dev_configured == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Device with port_id=%u is not configured.\\n\"\n-\t\t\t\"Cannot get IP reassembly configuration\\n\",\n+\t\t\t\"port_id=%u is not configured, cannot get IP reassembly configuration\\n\",\n \t\t\tport_id);\n \t\treturn -EINVAL;\n \t}\n@@ -6779,16 +6777,14 @@ rte_eth_ip_reassembly_conf_set(uint16_t port_id,\n \n \tif (dev->data->dev_configured == 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Device with port_id=%u is not configured.\\n\"\n-\t\t\t\"Cannot set IP reassembly configuration\\n\",\n+\t\t\t\"port_id=%u is not configured, cannot set IP reassembly configuration\\n\",\n \t\t\tport_id);\n \t\treturn -EINVAL;\n \t}\n \n \tif (dev->data->dev_started != 0) {\n \t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\"Device with port_id=%u started,\\n\"\n-\t\t\t\"cannot configure IP reassembly params.\\n\",\n+\t\t\t\"port_id=%u is started, cannot configure IP reassembly params.\\n\",\n \t\t\tport_id);\n \t\treturn -EINVAL;\n \t}\n", "prefixes": [ "v4", "08/14" ] }