Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135199/?format=api
{ "id": 135199, "url": "http://patches.dpdk.org/api/patches/135199/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231214113021.517622-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231214113021.517622-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231214113021.517622-1-bruce.richardson@intel.com", "date": "2023-12-14T11:30:21", "name": "app/test: remove ifdefs for cmdline library", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "56ccb431e214d9e983e6277302e59d5f18855e73", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231214113021.517622-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30554, "url": "http://patches.dpdk.org/api/series/30554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30554", "date": "2023-12-14T11:30:21", "name": "app/test: remove ifdefs for cmdline library", "version": 1, "mbox": "http://patches.dpdk.org/series/30554/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135199/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39429436EF;\n\tThu, 14 Dec 2023 12:30:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1DDFE43258;\n\tThu, 14 Dec 2023 12:30:34 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 0084543250\n for <dev@dpdk.org>; Thu, 14 Dec 2023 12:30:32 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Dec 2023 03:30:28 -0800", "from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.152])\n by orsmga003.jf.intel.com with ESMTP; 14 Dec 2023 03:30:26 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1702553433; x=1734089433;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=f9yHyg2z9Xdyk+qeJJUdgvy9ggbGZmHvBl97TvYWDos=;\n b=WGPY9aJfH1ra9qLIJLdXIJiMdoBuImff3SVxsU1bLtvZaE9KIF03IQ+7\n bp3EFMzBlm5rRIxJryadD8w2euvgnn72im3SzlltW5y88gUEFUBWYWE+i\n u2Es/MPhQL+fPjq50aa1FmomdZYaDd79RyBLKMGGYD3vI3MJRuDB7R/40\n Jk18fM0hb8QnwpNo3vXj6V4LDm4JUXxtrvfWskXhNTtHMS6Uty/KwYIB+\n EqeQYDEqK4841QB8JeLs18UQPykZpf2fA1Baj7f+NQUYB91V5k07xlHeV\n 1Bl56NwWBPC6VJ6NPccdMOie+gjgoUEl+dMYGzLQUwxWIVn6yitsNfxaD w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10923\"; a=\"393978181\"", "E=Sophos;i=\"6.04,275,1695711600\"; d=\"scan'208\";a=\"393978181\"", "E=McAfee;i=\"6600,9927,10923\"; a=\"724033603\"", "E=Sophos;i=\"6.04,275,1695711600\"; d=\"scan'208\";a=\"724033603\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH] app/test: remove ifdefs for cmdline library", "Date": "Thu, 14 Dec 2023 11:30:21 +0000", "Message-Id": "<20231214113021.517622-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The DPDK unit test binary relies on cmdline library and cannot do\nanything without it being present. As it's a mandatory dependency we can\nremove the ifdefs for it from main.c\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/app/test/test.c b/app/test/test.c\nindex bfa9ea52e3..c818fda17b 100644\n--- a/app/test/test.c\n+++ b/app/test/test.c\n@@ -11,13 +11,11 @@\n #include <ctype.h>\n #include <sys/queue.h>\n \n-#ifdef RTE_LIB_CMDLINE\n #include <cmdline_rdline.h>\n #include <cmdline_parse.h>\n #include <cmdline_socket.h>\n #include <cmdline.h>\n extern cmdline_parse_ctx_t main_ctx[];\n-#endif\n \n #include <rte_memory.h>\n #include <rte_eal.h>\n@@ -106,12 +104,10 @@ int last_test_result;\n int\n main(int argc, char **argv)\n {\n-#ifdef RTE_LIB_CMDLINE\n \tstruct cmdline *cl;\n \tchar *tests[argc]; /* store an array of tests to run */\n \tint test_count = 0;\n \tint i;\n-#endif\n \tchar *extra_args;\n \tint ret;\n \n@@ -183,7 +179,6 @@ main(int argc, char **argv)\n \t\t\t\t\"HPET is not enabled, using TSC as default timer\\n\");\n \n \n-#ifdef RTE_LIB_CMDLINE\n \tchar *dpdk_test = getenv(\"DPDK_TEST\");\n \n \tif (dpdk_test && strlen(dpdk_test) > 0)\n@@ -259,7 +254,6 @@ main(int argc, char **argv)\n \t\tcmdline_interact(cl);\n \t\tcmdline_stdin_exit(cl);\n \t}\n-#endif\n \tret = 0;\n \n out:\n", "prefixes": [] }