Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135190/?format=api
{ "id": 135190, "url": "http://patches.dpdk.org/api/patches/135190/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231214102431.2091608-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231214102431.2091608-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231214102431.2091608-2-chaoyong.he@corigine.com", "date": "2023-12-14T10:24:29", "name": "[1/3] net/nfp: fix close representor problem", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1e2aec2cc8ac00d520474f1e4713b99bc81e4bf4", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231214102431.2091608-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30550, "url": "http://patches.dpdk.org/api/series/30550/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30550", "date": "2023-12-14T10:24:28", "name": "fix some problems of flower firmware", "version": 1, "mbox": "http://patches.dpdk.org/series/30550/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135190/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135190/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7D23436EE;\n\tThu, 14 Dec 2023 11:24:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F119342FEB;\n\tThu, 14 Dec 2023 11:24:52 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2128.outbound.protection.outlook.com [40.107.237.128])\n by mails.dpdk.org (Postfix) with ESMTP id 57612402E6;\n Thu, 14 Dec 2023 11:24:51 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW4PR13MB5460.namprd13.prod.outlook.com (2603:10b6:303:183::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec\n 2023 10:24:49 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023\n 10:24:49 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NIg3+udWcpTr8VMmBlmN1wPadpApVKVxFI4fjbmBuEqrVgmvPqE8JsCYiPMBRIeeTkLOBO8pKZqE66F/0zJCMa1nDvmjW7ziKpPpt8QU7cz8hhOk2iXI5gsfaQ6sceXOM82M4hdFzmaQUQ8XZ8hYaSJz1bh0iALUcLgM49+aGLnVJOekhFvuXyJ0jaxlsfNiTaFWvgkRhCseX+b66sbEKuh85fKoIiSk+lQgI7nZRxVOZ/f7bnUzffwuJ+e40ZFlxrBfaPMjL66CT4/VrHi7FGmNk5byaW2npvlG65bo9CJx8cL81xt6hUl4ZNQRxCS8bTDPO1zXOY3l3JBce/EA5g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=GCBCJyidjBy0kT+SAgHprVwSalEeuB2kIniVGLMPyxg=;\n b=SytmrF1j2t5qlPVoQIa5DW6v9IWVqok2OpObuJG2UsWzA4n379XKO41md4il21Vjt8AAkxq7y36bCA2s69RYYtieq++CLPGpNjJRIWMD5z1sSIxRwBK17MQOewA6ZEMXdW8X9RKlMoLdc26KO2fM4JEbjQjWdw5AeFmqbH0JjSKdpDFz4y+AztAlStH0e4KQe0M9L4jwsJR5gcKEtgeESNSQ/bNsn/LfmtLI9H3i+llCc4JuTPv4HMocOiK4vok+9QbkIT7ow/69natoVyuU2EI6L+h2WRs3JNQsYRq8rsTVVgHySTo5EDZsTAFTVZtCI8flHAVIsTV5PgwKbxpjLg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=GCBCJyidjBy0kT+SAgHprVwSalEeuB2kIniVGLMPyxg=;\n b=Yxq4XjyWjTnhtrTzmMYNYNqD9Wb+uBCpjF1p0eHn5nFzVxIySB5s2lBWO9ybeJr9hN8YHmQJL+WfJWkBKk1qQcK15ZKqDsA7XpBmoiR25gdAeh1QK0s12ksc1AzLW92iHqj7dHVM/ttEkgFoI2F3hdS4aPxYIhh9wF0d0dd4JCM=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n chaoyong.he@corigine.com, stable@dpdk.org,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 1/3] net/nfp: fix close representor problem", "Date": "Thu, 14 Dec 2023 18:24:29 +0800", "Message-Id": "<20231214102431.2091608-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231214102431.2091608-1-chaoyong.he@corigine.com>", "References": "<20231214102431.2091608-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR03CA0273.namprd03.prod.outlook.com\n (2603:10b6:a03:39e::8) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW4PR13MB5460:EE_", "X-MS-Office365-Filtering-Correlation-Id": "2ebb79ea-582b-46ae-b0d7-08dbfc8ee70d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n /TuIpcNdN+Ljec170UmBIB2DFbmbtTalkc3vQjPfcv6d2lBz2oaIQ5hP2N6eNj+jlv2t22G45W7XvkMSAVHbKQPk9yFrtrYRGTyMK/xZJ3tsPgR0N6uD6U9Y1cjSaAFmVIykIR39faNFgjXYosrb9F9+OWNe452jrzeHFVYDyDQCkZ2+13wxr2FNFZMmBtoT9QHvqxsvmOkSJKzJn2p7inylIw60vvsQIGAdBc1dVSYBT+3Y3p9x6o60Y3MQsJU6GYJVRa1EbepRoAHcTmrMqOfF0qK/JqzjV/jH/VrNs+HnlGIN4iY+py70Pd1+g5ZElXFajT+imu7GFxPR8hDjrXdwE2NZdukoPoJW4EzrrLu/vssKTeLVCOunSpk/CDboWyGOlz6EhnIBSfGJqSYSiVzVZpbC5tXroYFhBDOPesuCZeOyT0/08Klb6OGVPkwLqNcSR6rHkBfaEGqlpdTYsKMzMfl82/XNY0Ef464CNXx3xz2nQWz2aqZVsKwwSSb6kEGmrs4CgeZz21YLaKaBn2a2H+4qmal5Y7ouRUfmvSfYRlvN7YS5nis/T91t5JebUpAgjn6IbbVvTSKiuGMMsTUzVLU+WXvmTgnxfOjbPhn9ety0M1yxigv4H385vyxXJKo9zvwK8R4BmckDdbyIr+f+0goMxotaQYwJAHlLuiA=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39830400003)(376002)(366004)(396003)(346002)(136003)(230922051799003)(64100799003)(1800799012)(186009)(451199024)(2616005)(1076003)(107886003)(6486002)(478600001)(86362001)(41300700001)(6506007)(6666004)(26005)(52116002)(6512007)(66556008)(66476007)(66946007)(83380400001)(54906003)(6916009)(316002)(38100700002)(450100002)(4326008)(8676002)(8936002)(5660300002)(2906002)(44832011)(38350700005)(36756003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n hrgXrvP/i2ASx4+qARZ1PB+R4rOoKzjAd4A48BJk8UUBbKDAPFfwsL7vsG7oaQpOoqlHL9QbirtiqioA0nhhuukzmVwlqxjdPbKF1KrE8oXUGB/l6Bry2Z4pJzH1x6pyK+Mg9dX3LawWrL4EDyPj5lAHncOD1qOWcQPy59OtI/vcFOVzWU8xKhFtyVo7yLmm3moy2wJmDGR4jJfg1mR5jWS7YNYzUk2yKeb90EqpX6FW5zPGt/9+6qcl++K8YsXvMNjwFyqNHDHufscW7YC8f1qn9HPS5jMblAy+EYplshitLpSVeA409XqxxdrOyNtTMOog6Zxys1ydwbYoRnizXNIN0Fq08xIGDx7s7txTAIiZLlOlAc2quVF98XIMBcDHQJMO1AUpxsRe2Xo664JMidIXbfQgLxIRqHUUNxBvGrvwF3aMePiTNE6N7p3Wcg4cHR6W7zDcKMQ7y2vfxh8+yOo9nSnfBi7es+3/JKELom/faBxKXfyRBxAGBeBRWNzguNhR9+Is9NWwtHPRbRS2KC5l4wW3Ro5cBsAaXtjFTxtJetO8/YaKC3+DalnKNJIV8/aASfFcKAf6IpyqSRN61cqXYE5hPcUoXHxrlwBJfUoPSisrnjH9gZPbIV0gmPAijbNLaPacfgltAg0r0/h3K9YNQmN2oW63tFol9d1gNMXpMD0XgWGxveumjy+l8z+etSmWj0WY7c/Cxob4uv8yuj0qBf2rETc/fhB/QVylDHYY7SHlSLXBdZY1rzBCcpKjKaKsBB0UmFFb/xAmbPF0YYo8RW+JCbADftDHxzci5+WHN9pYFOqH7EOkgUjirn4OOgx7Z4C2g1epbXVoq+TWb43t7BoY2ttnYjdKzb/lyt9pRaVCPiipnHrqiFkbgvebepmwf96168lkHUvgL30mxQWODHdtDfdAWMMX5o4pkDisjO9arLMiAAvZw6ZY/8SPnukp5FjTDTe0b+emsableMSYe0h33KW7JoopUjJmthuIVU/xbEtZQKGQP8qBh5cfNfIu1lKy21wRvWDMMrA9mESf9iZIogPAicPo8hSNBgsh2c57epClrevEUPPu+2MXF0SW0WvQiON3cGX2u3RsI72HWdrVM7ZWhDYJNVm19ymqmHkT1QpHaP6TKV13Qlc/difV3pwfyQHda1NU/d5XcEDIS65IbsYW3MjHdGblI/6L8qc1K0pRdpZflSay32cgNPA8uxkXMDCXuEsmCoB8rALDOHSF2i9fXhN7nK9CKSdpLHidhp8qGu8WonCB98ZTl1bf1emZNjkz6qkRUr230TByOCNYwjcfIF2rnKUbTEcLohP/9amLjhCwPEHF1dHJPKfZGTyrjl+2B/xw+EFuCMXdJEmzLft00j6LUf/8sNt8SnXgWcsTmQKsYU0XqIeHvlrxIm9uVZVpZSXwrpaAmcZE/fP+fbk3DKh690b168t/sJ2fahI9g3oz8rxWOQTQhhC0QHPq/AfOB2tIw9+JdigBWvBKUPXvdwTO7HrPDo01bz4L/9ba42XwmJk5CBCVjsUvENwtuaiA1e3aLHRZOIDuVISs7OP8lSgyHCPyzDpCJpul7PuJCa3X/4QzjDyAUyua4yXMgSSqKK/fNgTwhQ==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2ebb79ea-582b-46ae-b0d7-08dbfc8ee70d", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Dec 2023 10:24:49.7715 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n tYpcCMTgi/mdWODKIDIf/0wuCbDi7UyXK7iaIKLEIqDv5WoK831z2fKtBzsRzVcPyRUw8eSBHfFJ8JSM+IAGhSPTPenB2qzypE27NLBWrdo=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR13MB5460", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nClose interface use \"rte_eth_dev_destroy()\" to destroy representor. The\n\"rte_eth_dev_destroy()\" will call \"rte_eth_dev_release_port()\" but the\n\"rte_eth_dev_close()\" also calls \"rte_eth_dev_release_port()\". This will\ncause Segmentation fault.\n\nRemove the \"rte_eth_dev_destroy()\" in nfp representor close interface.\n\nFixes: a135bc1644d6 (\"net/nfp: fix resource leak for flower firmware\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c\nindex 7d8c055b80..27ea3891bd 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.c\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.c\n@@ -314,13 +314,13 @@ nfp_flower_repr_free(struct nfp_flower_representor *repr,\n {\n \tswitch (repr_type) {\n \tcase NFP_REPR_TYPE_PHYS_PORT:\n-\t\trte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit);\n+\t\tnfp_flower_repr_uninit(repr->eth_dev);\n \t\tbreak;\n \tcase NFP_REPR_TYPE_PF:\n-\t\trte_eth_dev_destroy(repr->eth_dev, nfp_flower_pf_repr_uninit);\n+\t\tnfp_flower_pf_repr_uninit(repr->eth_dev);\n \t\tbreak;\n \tcase NFP_REPR_TYPE_VF:\n-\t\trte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit);\n+\t\tnfp_flower_repr_uninit(repr->eth_dev);\n \t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"Unsupported repr port type.\");\n", "prefixes": [ "1/3" ] }