Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135179/?format=api
{ "id": 135179, "url": "http://patches.dpdk.org/api/patches/135179/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231214030428.363471-5-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231214030428.363471-5-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231214030428.363471-5-suanmingm@nvidia.com", "date": "2023-12-14T03:04:27", "name": "[4/4] net/mlx5: add modify field action ADD fields validation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "17503489670528d19af4d06d3f7d6fcf42125bda", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231214030428.363471-5-suanmingm@nvidia.com/mbox/", "series": [ { "id": 30543, "url": "http://patches.dpdk.org/api/series/30543/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30543", "date": "2023-12-14T03:04:24", "name": "net/mlx5: add modify field ADD fields support", "version": 1, "mbox": "http://patches.dpdk.org/series/30543/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135179/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135179/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EBAFF436E9;\n\tThu, 14 Dec 2023 04:05:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F06542FC3;\n\tThu, 14 Dec 2023 04:05:19 +0100 (CET)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43])\n by mails.dpdk.org (Postfix) with ESMTP id 8B7C842FA1\n for <dev@dpdk.org>; Thu, 14 Dec 2023 04:05:17 +0100 (CET)", "from SA0PR11CA0128.namprd11.prod.outlook.com (2603:10b6:806:131::13)\n by SN7PR12MB7372.namprd12.prod.outlook.com (2603:10b6:806:29b::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec\n 2023 03:05:14 +0000", "from SN1PEPF0002BA4C.namprd03.prod.outlook.com\n (2603:10b6:806:131:cafe::fe) by SA0PR11CA0128.outlook.office365.com\n (2603:10b6:806:131::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26 via Frontend\n Transport; Thu, 14 Dec 2023 03:05:14 +0000", "from mail.nvidia.com (216.228.117.160) by\n SN1PEPF0002BA4C.mail.protection.outlook.com (10.167.242.69) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7091.26 via Frontend Transport; Thu, 14 Dec 2023 03:05:14 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 13 Dec\n 2023 19:04:59 -0800", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 13 Dec\n 2023 19:04:56 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=G/1LyGV29Ps+87EU07FDjceyHN/2FogMS4j9WxmGnphbEzXgXc5iAewWPoP5O3O8ZpCbgwSrT9Alqr6F9ee0r/Fkd7OuSmEtOwmya1CtKH+U5w1ghFM4m0a4KxN24LOEcMRekDtToK8+bko5O8zAJK6L57aS99RUq5wWSl3maoHC103vJmUdSB5J0M26qWleT47Tra0X9Y7q6jBXBqjTWH4ohMXWFAfx28ANxVP+ZavJvCxTXCfI/eg5TkOLNvfo774U9deHpyYkSaJ0nTT+bk4muC+DVG64Kzzo6Hs8WsOH67kqprxSvd93bc8uaqs3y/0g25fMCxM3wizKbVi4Mw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=NYfypAxp63p23biDtj5WlNB0/L84yhaecNDYciF2LPg=;\n b=DSuLjyTIHAIOIsnHz0/ZE+HSSLGNlkkkHIO8bqXrUzorLG1I2WVAsak8SdoC8aBPSEKueEs+QbWlIappEv67pilxFjJfzgn2neZuHCXCl1wihIttbiX3qfrD3STfQt5YUaTkc9Aru5BJixn6u2L3TWyOAJIRXQGEzdwSuBrf/Tk0i95Dm0MFSKpRinKyHHylsBrh/NQfhgxc7MypeYRWsiOLeMV+FXiquKJCG96HVDWzlJLubFFdE1B16PPqrYYUI76nazAqrkSEFBqafzSMJuFTK3Q1xNMIid+M5vcWVKUxuwZNL3FzKfuAUxB5GDvXZDRroIOd6d0h0r2Rfs8aZw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=NYfypAxp63p23biDtj5WlNB0/L84yhaecNDYciF2LPg=;\n b=R4fiZYQH23SHNLLcQYt6O//mkqd2nx5ccgwe09yeCzkIaxJVbqWtQo2oPVYZ6QAqtF3H2RTTIyZGaTdCydeVTf4j+H12v3iiT30MHF95CurK2GP5VqEduXAbmKmVXnGfFD/dXeE3Yea1LlZ8FXJ8t+Ye1uU7FBnvApQQB1BHwkHKX86qoX737wonAA5XExI6pY0zO5Odzp+9F4zLBs1Rnr7h+bFCFI8jpBxxhDuz/nIZK7Sadkzjgcl2T3++ARlmyMkveOFVPDr3c0Ximw9nKTPGR/C8CFcl9jmchy49koAKeHY1mLEEvk14zmEIZ8DfZlFUvNXsEo8FbfrosIDQLQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Dariusz Sosnowski <dsosnowski@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Matan Azrad\n <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>", "Subject": "[PATCH 4/4] net/mlx5: add modify field action ADD fields validation", "Date": "Thu, 14 Dec 2023 11:04:27 +0800", "Message-ID": "<20231214030428.363471-5-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231214030428.363471-1-suanmingm@nvidia.com>", "References": "<20231214030428.363471-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF0002BA4C:EE_|SN7PR12MB7372:EE_", "X-MS-Office365-Filtering-Correlation-Id": "27e24eee-859b-45a5-429e-08dbfc517e64", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ZECN3/Oxq0x6HpZVG7L7j1DGL5K2KXYRYnBrM27MSA4+RcvC8nEwA8/ztrNWC+bLbub5CenhmC4qyopA0jZH9t5IbBa9W2Z+P4zs2CSw5GrieijlDjhl6WWin6A33YTo28ZA07C26BTnBKael9JOQJ4ytaOmvrtOnDkhAWt1E/8RmRJwSzro3f9qpmg7TfPEzgWEgINcBLviBPbuxsaEaWygkOZOVG0c7aB0AHPlZeKeenWNhbii0E8K4NcdFaUAFa4KwjbLaXEVixXheDGjzSsY+Ce+2ZBsPz6cHXl3qZY+m5VoXTe2XABba+r302YZPMbFbt91L6YwoO8vaso7l6MFoiuFLF2bWR642h5UkN0MldIpBluHAVdmV+UL+hF2mXBdIpvPTSnvjrhofGi1Pp/Opa7khxuPLm4pzTaAKGsQQlq5P8bYQOPMz7F99e6VXSeDS5KxmRDhlYmv8V3HDz1IWzewU3qzwntPMmkZOVztwyT3O/uIwnjcSf4JLhTg+hM2CE5OwqhxETKKn4nidCjXkrKhp9a4u7/wN2tcfuvDXCtAytUEVfQhVpigf06+tyzSqFpPP54AMjCrsn1UKynLFHgflsUqht7QMqrWHdbtv+NYKWa1rOLL288nNrNu3N/ncOSqBHpjC2SxGE1Wrl5DR5n8XX9ywnr4K1uSZazXyqs3RjO3oedQDDDEw/NTG9T31zMJ4z0m+lqGjLFMGDr1sFoA7kL8sY0CUgUxfpY=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(396003)(346002)(376002)(39860400002)(230922051799003)(451199024)(1800799012)(82310400011)(64100799003)(186009)(40470700004)(46966006)(36840700001)(41300700001)(83380400001)(426003)(336012)(36860700001)(47076005)(7696005)(5660300002)(40480700001)(55016003)(478600001)(82740400003)(2906002)(6666004)(356005)(110136005)(54906003)(6636002)(316002)(70586007)(4326008)(8676002)(8936002)(70206006)(6286002)(16526019)(40460700003)(86362001)(107886003)(2616005)(7636003)(26005)(36756003)(1076003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Dec 2023 03:05:14.4545 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 27e24eee-859b-45a5-429e-08dbfc517e64", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF0002BA4C.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB7372", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Due to HW limitation, not all the fields are available as ADD_FIELD\ndestination.\n\nThis commit adds the validation to the destinations.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\n---\n doc/guides/rel_notes/release_24_03.rst | 4 ++++\n drivers/net/mlx5/mlx5_flow_hw.c | 32 ++++++++++++++++++++++++++\n 2 files changed, 36 insertions(+)", "diff": "diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst\nindex e9c9717706..2c0e2930cc 100644\n--- a/doc/guides/rel_notes/release_24_03.rst\n+++ b/doc/guides/rel_notes/release_24_03.rst\n@@ -55,6 +55,10 @@ New Features\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* **Updated NVIDIA mlx5 driver.**\n+\n+ * Added support for accumulating from src field to dst field.\n+\n \n Removed Items\n -------------\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex d224979ee8..c4a90a3690 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -4948,6 +4948,33 @@ flow_hw_modify_field_is_used(const struct rte_flow_action_modify_field *action,\n \treturn action->src.field == field || action->dst.field == field;\n }\n \n+static bool\n+flow_hw_modify_field_is_add_dst_valid(const struct rte_flow_action_modify_field *conf)\n+{\n+\tif (conf->operation != RTE_FLOW_MODIFY_ADD)\n+\t\treturn true;\n+\tif (conf->src.field == RTE_FLOW_FIELD_POINTER ||\n+\t conf->src.field == RTE_FLOW_FIELD_VALUE)\n+\t\treturn true;\n+\tswitch (conf->dst.field) {\n+\tcase RTE_FLOW_FIELD_IPV4_TTL:\n+\tcase RTE_FLOW_FIELD_IPV6_HOPLIMIT:\n+\tcase RTE_FLOW_FIELD_TCP_SEQ_NUM:\n+\tcase RTE_FLOW_FIELD_TCP_ACK_NUM:\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\tcase RTE_FLOW_FIELD_FLEX_ITEM:\n+\tcase RTE_FLOW_FIELD_TCP_DATA_OFFSET:\n+\tcase RTE_FLOW_FIELD_IPV4_IHL:\n+\tcase RTE_FLOW_FIELD_IPV4_TOTAL_LEN:\n+\tcase RTE_FLOW_FIELD_IPV6_PAYLOAD_LEN:\n+\t\treturn true;\n+\tdefault:\n+\t\tbreak;\n+\t}\n+\treturn false;\n+}\n+\n static int\n flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n \t\t\t\t const struct rte_flow_action *action,\n@@ -5060,6 +5087,11 @@ flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n \t\t\t\t\"MPLS cannot be used as destination\");\n+\t/* ADD_FIELD is not supported for all the fields. */\n+\tif (!flow_hw_modify_field_is_add_dst_valid(action_conf))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\"invalid add_field destination\");\n \treturn 0;\n }\n static int\n", "prefixes": [ "4/4" ] }