Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135168/?format=api
http://patches.dpdk.org/api/patches/135168/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231213163820.894987-34-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231213163820.894987-34-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231213163820.894987-34-stephen@networkplumber.org", "date": "2023-12-13T16:36:07", "name": "[v3,33/37] event/skeleton: replace logtype PMD with dynamic type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "223af5974ae16da9742ade9f7d7191bb98984f3e", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231213163820.894987-34-stephen@networkplumber.org/mbox/", "series": [ { "id": 30539, "url": "http://patches.dpdk.org/api/series/30539/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30539", "date": "2023-12-13T16:35:34", "name": "Replace uso of RTE_LOGTYPE_PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/30539/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135168/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135168/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5F8E436E3;\n\tWed, 13 Dec 2023 17:42:37 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 91DF442FF7;\n\tWed, 13 Dec 2023 17:40:33 +0100 (CET)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id 8BDA242F93\n for <dev@dpdk.org>; Wed, 13 Dec 2023 17:40:22 +0100 (CET)", "by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-1d06819a9cbso41707055ad.1\n for <dev@dpdk.org>; Wed, 13 Dec 2023 08:40:22 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 13 Dec 2023 08:40:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485622;\n x=1703090422; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=;\n b=UXZZZhmZi59FKolswzK7zv15sIexBCTjOmcL5lrxmnj/oyxAMjoUDKKpv3lKWX58yd\n WaF0zrAGycTUgq/MlqBUJyMA5zuEIWPmxgh0rDa+wCauFUoFISV7mbeBso4h1yA9qzba\n QrMSIGUbPY7FgfMJ2uCLtHUSvCuD0rztRH5/oIE3/N8bLvuX+mRHUzjIzcqXHiElhHcl\n u0JOeItNc3fG9Z4l4rMSt5KNX3/CSt5KIJ53hCFjtx0G43F1gfYWL2gDBqIIFjYK+nG7\n CNLLwMnBu1QMGv+X7VrhR5xdqRroN9/izDrHjlklMMEL/wTKtTmYjncS9dyAb0bqIsW+\n W4pQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702485622; x=1703090422;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IfEBZNx5o1grAD5H8WxbgdgKmhV0o98XWrLO5UjgMBA=;\n b=Z4K/GdA+IjMJg2p90iGea52Wl2iNQFni1AO1WVAIQ8lFB+zwdIK1GRcv/F8QDWLdVB\n ewZTszJ0xPdlltek+gYEuBzzGL/fA0uQUdkdq/mUkrcLYxHr9fp5yF8Enze8Lbsa4edF\n VKxC3vBArImVvUCogNdGgSCZYBFyyPb6wDeupQcVXUXCSIy5aCg1W2Z4gQ0Sab8C7Vnh\n VqRb8RkrF5QMzX2BQ8GnuTLRDgrdbHUHqukHBvE68JP4uzHznMlz6IckOGIXDAF9VQ8f\n /iW4DejwKzmlWGhkaTMfFRXMnC5i+lWAMkVmPLM6UYGKAhVpuQf/xxaMJ8pnJM5Y76GD\n ALfQ==", "X-Gm-Message-State": "AOJu0Yx4vmz9VAjPQes8Kx5FmHjCiJaPgfUGEzCRt7FEhiB4ZJxaE/Zx\n vR8gApVJx5XvxHk8YvalYYC2RYfuVrzscnsuF5o=", "X-Google-Smtp-Source": "\n AGHT+IGifu8FlMR4k+Ptfv1u9v6sOWsKDB92dF4e4Uffuh+OZIqsZhyxWCcpc7bQvUWMW7Lo3FTeGg==", "X-Received": "by 2002:a17:902:f690:b0:1d0:a663:20fe with SMTP id\n l16-20020a170902f69000b001d0a66320femr4217823plg.80.1702485621810;\n Wed, 13 Dec 2023 08:40:21 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jerin Jacob <jerinj@marvell.com>", "Subject": "[PATCH v3 33/37] event/skeleton: replace logtype PMD with dynamic\n type", "Date": "Wed, 13 Dec 2023 08:36:07 -0800", "Message-ID": "<20231213163820.894987-34-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231213163820.894987-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20231213163820.894987-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The skeleton is supposed to match current best practices.\nChange it to use dynamic logtype.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/event/skeleton/skeleton_eventdev.c | 3 ++-\n drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++--\n 2 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c\nindex 7df032b7daa1..df50d2e4e4ff 100644\n--- a/drivers/event/skeleton/skeleton_eventdev.c\n+++ b/drivers/event/skeleton/skeleton_eventdev.c\n@@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev)\n \tconst char *name;\n \n \tname = rte_vdev_device_name(vdev);\n-\tRTE_LOG(INFO, PMD, \"Initializing %s on NUMA node %d\\n\", name,\n+\tPMD_DRV_LOG(INFO, \"Initializing %s on NUMA node %d\\n\", name,\n \t\t\trte_socket_id());\n \treturn skeleton_eventdev_create(name, rte_socket_id(), vdev);\n }\n@@ -479,3 +479,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = {\n };\n \n RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd);\n+RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO);\ndiff --git a/drivers/event/skeleton/skeleton_eventdev.h b/drivers/event/skeleton/skeleton_eventdev.h\nindex 9193f45f4782..9c1ed4ec5755 100644\n--- a/drivers/event/skeleton/skeleton_eventdev.h\n+++ b/drivers/event/skeleton/skeleton_eventdev.h\n@@ -8,9 +8,12 @@\n #include <eventdev_pmd_pci.h>\n #include <eventdev_pmd_vdev.h>\n \n+extern int skeleton_eventdev_logtype;\n+\n #ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG\n #define PMD_DRV_LOG(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+\trte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, \">>\")\n #else\n #define PMD_DRV_LOG(level, fmt, args...) do { } while (0)\n@@ -18,7 +21,8 @@\n #endif\n \n #define PMD_DRV_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, PMD, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+\trte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n \n struct skeleton_eventdev {\n \tuintptr_t reg_base;\n", "prefixes": [ "v3", "33/37" ] }{ "id": 135168, "url": "