Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135162/?format=api
{ "id": 135162, "url": "http://patches.dpdk.org/api/patches/135162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231213163820.894987-28-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231213163820.894987-28-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231213163820.894987-28-stephen@networkplumber.org", "date": "2023-12-13T16:36:01", "name": "[v3,27/37] raw/cnxk_bphy: replace PMD logtype with dynamic type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70f7385367eee3ef2867c77930631dc0bfe68113", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231213163820.894987-28-stephen@networkplumber.org/mbox/", "series": [ { "id": 30539, "url": "http://patches.dpdk.org/api/series/30539/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30539", "date": "2023-12-13T16:35:34", "name": "Replace uso of RTE_LOGTYPE_PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/30539/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135162/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF3CE436E3;\n\tWed, 13 Dec 2023 17:41:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9276342FB7;\n\tWed, 13 Dec 2023 17:40:26 +0100 (CET)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 2F1D842F79\n for <dev@dpdk.org>; Wed, 13 Dec 2023 17:40:18 +0100 (CET)", "by mail-pl1-f177.google.com with SMTP id\n d9443c01a7336-1d331f12f45so14817325ad.2\n for <dev@dpdk.org>; Wed, 13 Dec 2023 08:40:18 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n 4-20020a170902c24400b001d0a6f31519sm10749593plg.188.2023.12.13.08.40.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 13 Dec 2023 08:40:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702485617;\n x=1703090417; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oazGRehyaV7lEhIuAA2jjOuXmN7/tVDcDYpfuj/uPes=;\n b=QAv7XduiRjLCV2LiLXMWaxabhRZUlTJUkx0pFo+Os76xrD3XV/3zm7usDlmPo1ibtq\n wNAilkmPtEHgj6SLF7zJvuT/cIbkXd0VTpO/S7ebm5KLHdD4JeHgoqocmHL6eRTAGjpf\n QHmlxeuBB7yzNliY93WVADzbEIIbvDItzB+mCnyMHNJkTt2dAwfhf3TxU15adGnviR2z\n 7hX7jS/9/aAK5++7GBM1NIrSMT2qPAvdB139+0qhinyUxiR+up/uU1ir5XcvrfgYNj5d\n q19I6eT2HRhFIi3D1OD4DcUV5NTZg4EqimP2TJaTomEyQ72TGN5rM7svTk1Xcn8nXkIw\n 1bwg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702485617; x=1703090417;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=oazGRehyaV7lEhIuAA2jjOuXmN7/tVDcDYpfuj/uPes=;\n b=un/jaOKSt4hrjiQIAIl+2sdCBYO4j+A+RsTwpNBE2OP9CdDxAr7DmolzFPtKslpNA4\n up9wSFBTA5urVFQzxoUg1d6vApQCM6QTG+MylPGK/UdgSvqqGNjoNEvrHuCHfTWd0MjC\n lp0u9uKY02WasF4tmswV/OburKRsxZgvAoOjuow1yPUqDkuYi30NWJvZh78qVlp7PKK8\n Xv6+KWCMCcbuzT0bJ7tumCeVpWRbjPJqh1gwx/TEhVjrNVYqzgKnXu01Z/PLgDdjLViP\n d4qRJUsprqajDZK31EpBHdD990d5xbp2kQ2+NcnQ10wxKuKfY3mPWqoy8Emv/Idctu0C\n RZ2w==", "X-Gm-Message-State": "AOJu0YxxzTx3jD9rPPlXsGNzHzATT9YeTtf77mKu4k933RniTTAeIiPs\n eszK7DoPBBVxLS7hq1BTjxoujn4aPvDTYpBqmeM=", "X-Google-Smtp-Source": "\n AGHT+IGgjjIeWtp6g9Dfmo0RhkeILn8ICgSqTstWsnr3yfZq8GAzlnkz40dzJ4Tp6V57TuETCX/yQQ==", "X-Received": "by 2002:a17:903:40c8:b0:1d3:49fc:b780 with SMTP id\n t8-20020a17090340c800b001d349fcb780mr949512pld.78.1702485617422;\n Wed, 13 Dec 2023 08:40:17 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jakub Palider <jpalider@marvell.com>,\n Tomasz Duszynski <tduszynski@marvell.com>", "Subject": "[PATCH v3 27/37] raw/cnxk_bphy: replace PMD logtype with dynamic type", "Date": "Wed, 13 Dec 2023 08:36:01 -0800", "Message-ID": "<20231213163820.894987-28-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231213163820.894987-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20231213163820.894987-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Driver should not be using PMD logtype, they should have their\nown logtype.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++-\n drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +-\n drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +++++++++++-----------\n drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 5 ++++\n 4 files changed, 23 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex 15dbc4c1a637..f1c14125d5c5 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -251,7 +251,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,\n \n \t/* get rid of last response if any */\n \tif (qp->rsp) {\n-\t\tRTE_LOG(WARNING, PMD, \"Previous response got overwritten\\n\");\n+\t\tBPHY_LOG(WARNING, \"Previous response got overwritten\");\n \t\trte_free(qp->rsp);\n \t}\n \tqp->rsp = rsp;\n@@ -410,3 +410,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = {\n RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map);\n RTE_PMD_REGISTER_KMOD_DEP(bphy_rawdev_pci_driver, \"vfio-pci\");\n+RTE_LOG_REGISTER_DEFAULT(bphy_logtype, INFO);\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\nindex 2d8466ef918b..b2e8fc0e5c6f 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c\n@@ -189,7 +189,7 @@ cnxk_bphy_cgx_process_buf(struct cnxk_bphy_cgx *cgx, unsigned int queue,\n \n \t/* get rid of last response if any */\n \tif (qp->rsp) {\n-\t\tRTE_LOG(WARNING, PMD, \"Previous response got overwritten\\n\");\n+\t\tBPHY_LOG(WARNING, \"Previous response got overwritten\");\n \t\trte_free(qp->rsp);\n \t}\n \tqp->rsp = rsp;\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\nindex a3021b4bb7db..148ee551ead1 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c\n@@ -57,62 +57,61 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)\n \t\tif (ret)\n \t\t\tbreak;\n \t\tif (descs != 1) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Wrong number of descs reported\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Wrong number of descs reported\");\n \t\t\tret = -ENODEV;\n \t\t\tbreak;\n \t\t}\n \n-\t\tRTE_LOG(INFO, PMD, \"Testing queue %d\\n\", i);\n+\t\tBPHY_LOG(INFO, \"Testing queue %d\", i);\n \n \t\tret = rte_pmd_bphy_cgx_stop_rxtx(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to stop rx/tx\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to stop rx/tx\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_start_rxtx(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to start rx/tx\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to start rx/tx\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, false);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set link down\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to set link down\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = cnxk_bphy_cgx_link_cond(dev_id, i, 0);\n \t\tif (ret != 0)\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Timed out waiting for a link down\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Timed out waiting for a link down\");\n \n \t\tret = rte_pmd_bphy_cgx_set_link_state(dev_id, i, true);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set link up\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to set link up\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = cnxk_bphy_cgx_link_cond(dev_id, i, 1);\n \t\tif (ret != 1)\n-\t\t\tRTE_LOG(ERR, PMD, \"Timed out waiting for a link up\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Timed out waiting for a link up\");\n \n \t\tret = rte_pmd_bphy_cgx_intlbk_enable(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to enable internal lbk\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to enable internal lbk\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_intlbk_disable(dev_id, i);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable internal lbk\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to disable internal lbk\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_ptp_rx_enable(dev_id, i);\n \t\t/* ptp not available on RPM */\n \t\tif (ret < 0 && ret != -ENOTSUP) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to enable ptp\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to enable ptp\");\n \t\t\tbreak;\n \t\t}\n \t\tret = 0;\n@@ -120,27 +119,27 @@ cnxk_bphy_cgx_dev_selftest(uint16_t dev_id)\n \t\tret = rte_pmd_bphy_cgx_ptp_rx_disable(dev_id, i);\n \t\t/* ptp not available on RPM */\n \t\tif (ret < 0 && ret != -ENOTSUP) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable ptp\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to disable ptp\");\n \t\t\tbreak;\n \t\t}\n \t\tret = 0;\n \n \t\tret = rte_pmd_bphy_cgx_get_supported_fec(dev_id, i, &fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to get supported FEC\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to get supported FEC\");\n \t\t\tbreak;\n \t\t}\n \n \t\tret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to set FEC to %d\\n\", fec);\n+\t\t\tBPHY_LOG(ERR, \"Failed to set FEC to %d\", fec);\n \t\t\tbreak;\n \t\t}\n \n \t\tfec = CNXK_BPHY_CGX_ETH_LINK_FEC_NONE;\n \t\tret = rte_pmd_bphy_cgx_set_fec(dev_id, i, fec);\n \t\tif (ret) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Failed to disable FEC\\n\");\n+\t\t\tBPHY_LOG(ERR, \"Failed to disable FEC\");\n \t\t\tbreak;\n \t\t}\n \t}\ndiff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\nindex 9d8d0285581b..5926adbcece9 100644\n--- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n+++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h\n@@ -26,6 +26,11 @@\n extern \"C\" {\n #endif\n \n+extern int bphy_logtype;\n+\n+#define BPHY_LOG(level, fmt, args...)\t\\\n+\trte_log(RTE_LOG_ ## level, bphy_logtype, \"%s(): \" fmt \"\\n\", __func__, ## args)\n+\n /** Available message types */\n enum cnxk_bphy_cgx_msg_type {\n \t/** Type used to obtain link information */\n", "prefixes": [ "v3", "27/37" ] }