Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135124/?format=api
{ "id": 135124, "url": "http://patches.dpdk.org/api/patches/135124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231213041920.729403-20-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231213041920.729403-20-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231213041920.729403-20-stephen@networkplumber.org", "date": "2023-12-13T04:16:46", "name": "[v2,19/25] common/sfc_efx: remove use of PMD logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fe77a4e9cb5f8a045acfe5ab86eafe29fd79dec", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231213041920.729403-20-stephen@networkplumber.org/mbox/", "series": [ { "id": 30533, "url": "http://patches.dpdk.org/api/series/30533/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30533", "date": "2023-12-13T04:16:27", "name": "Replace use of RTE_LOGTYPE_PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/30533/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135124/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135124/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 308E3436D9;\n\tWed, 13 Dec 2023 05:21:46 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6821742F1F;\n\tWed, 13 Dec 2023 05:19:46 +0100 (CET)", "from mail-yw1-f172.google.com (mail-yw1-f172.google.com\n [209.85.128.172])\n by mails.dpdk.org (Postfix) with ESMTP id 6B47042EFD\n for <dev@dpdk.org>; Wed, 13 Dec 2023 05:19:41 +0100 (CET)", "by mail-yw1-f172.google.com with SMTP id\n 00721157ae682-5d2d0661a8dso65964237b3.2\n for <dev@dpdk.org>; Tue, 12 Dec 2023 20:19:41 -0800 (PST)", "from hermes.lan (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n p12-20020a170902e74c00b001d077da4ac4sm9340888plf.212.2023.12.12.20.19.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 12 Dec 2023 20:19:40 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702441181;\n x=1703045981; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hxQxLoDS3vg/T2ba6PLlwpaRQ8BgmKF9iW2xv/u3hxM=;\n b=Vr34Yl7F53Ud6SmlQ7eloAWv/9UFI7LW4SYcwasNA4s+bJ83lDTQDVSnfOYYhrZdg6\n mivC3F/ox52d07risgqvmqlbSh2arJxzYYLPdGw18XzmhrhTkxnjfltu7xjO8MRzbel4\n pkbAZrTfEU87O4FEDnyRv0Vt1x7pdqag934F3fHMxEZCl5/ah4rXjkVqgUzwwzMJn3mK\n tcD4FPnvi1jN/BxdwbjwNcwj1JL1WZZ4rC22685KNVUN+WdXqS0QG7gFjKtfnULq9jIG\n A2CJdT4XriM4QRbdXH85T9iPMtlTfCzFjuBqpNUWjgdOP6VCvoEkFnN69xUOfg9pdnox\n BssQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702441181; x=1703045981;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hxQxLoDS3vg/T2ba6PLlwpaRQ8BgmKF9iW2xv/u3hxM=;\n b=EYsLjw7jsR6bpohA4whoH+tcFdKiNIc27FrfKhtreGb0U3GTwWWOS4pEVCvTTwZFQd\n XMsAixqGVZIYcs0N257NfQy1nOsOAxPJWXvImT+H1WEdZEDEIFN46sHeuyKzsQ7WyHfm\n Q332C9rYmlr5R0jEB3Rx/3h4pg9e5R0TDRRZXJZDs6lJTubLA6F4so5N5WURr7WV2en0\n fGWG3kuPvWoDWX3LtmvdhKaw1T6AJiqxJ0BBVf+9XbILspJzqsFZ5Uyy4qzrXSH9j7iD\n cUPEPBubRWkUXe+s0j3qVVVmSHwp3OCoIFKc9z3s41wQtcGA02q5h8y9hw29YdrhFVlf\n ZiRQ==", "X-Gm-Message-State": "AOJu0YyBpcQgqQU4R0M+z74dvREjlr8rqEvw0Xoh5vBrsL4PLl6LM0jt\n mVGLvIHXseJ59nm6fo2AT17KZzNK1aKVn3gIiuQ=", "X-Google-Smtp-Source": "\n AGHT+IFbJkxha8zn8MAlqNJ/mB5w2hi6ROYOUiXd3G+ld+Hn/INIOcIVOGzsLlHIr/0tCU145SK4kg==", "X-Received": "by 2002:a81:7156:0:b0:5d8:e267:78e5 with SMTP id\n m83-20020a817156000000b005d8e26778e5mr6605652ywc.61.1702441180784;\n Tue, 12 Dec 2023 20:19:40 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH v2 19/25] common/sfc_efx: remove use of PMD logtype", "Date": "Tue, 12 Dec 2023 20:16:46 -0800", "Message-ID": "<20231213041920.729403-20-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231213041920.729403-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20231213041920.729403-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This code was implemented in a slightly different manner\nthan all the other logging code (for no good reason).\nMake it the same and handle errors in same way as\nother drivers.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/sfc_efx/sfc_efx.c | 11 ++---------\n drivers/common/sfc_efx/sfc_efx_log.h | 2 +-\n 2 files changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c\nindex 2dc5545760b8..5eeffb065b0d 100644\n--- a/drivers/common/sfc_efx/sfc_efx.c\n+++ b/drivers/common/sfc_efx/sfc_efx.c\n@@ -15,7 +15,7 @@\n #include \"sfc_efx_log.h\"\n #include \"sfc_efx.h\"\n \n-uint32_t sfc_efx_logtype;\n+int sfc_efx_logtype;\n \n static int\n sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key,\n@@ -117,11 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev,\n \treturn rc;\n }\n \n-RTE_INIT(sfc_efx_register_logtype)\n-{\n-\tint ret;\n-\n-\tret = rte_log_register_type_and_pick_level(\"pmd.common.sfc_efx\",\n-\t\t\t\t\t\t RTE_LOG_NOTICE);\n-\tsfc_efx_logtype = (ret < 0) ? RTE_LOGTYPE_PMD : ret;\n-}\n+RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE);\ndiff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h\nindex 694455c1b14e..1519ebdc175f 100644\n--- a/drivers/common/sfc_efx/sfc_efx_log.h\n+++ b/drivers/common/sfc_efx/sfc_efx_log.h\n@@ -11,7 +11,7 @@\n #define _SFC_EFX_LOG_H_\n \n /** Generic driver log type */\n-extern uint32_t sfc_efx_logtype;\n+extern int sfc_efx_logtype;\n \n /** Log message, add a prefix and a line break */\n #define SFC_EFX_LOG(level, ...) \\\n", "prefixes": [ "v2", "19/25" ] }