Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135044/?format=api
http://patches.dpdk.org/api/patches/135044/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231211172437.61958-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231211172437.61958-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231211172437.61958-4-stephen@networkplumber.org", "date": "2023-12-11T17:23:25", "name": "[3/3] examples/vm_power_manager: do not use EAL logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7351ec9fbe1e7b0a8fd1a37cbe2a463f8582d1c6", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231211172437.61958-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 30512, "url": "http://patches.dpdk.org/api/series/30512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30512", "date": "2023-12-11T17:23:22", "name": "replace use of EAL logtype", "version": 1, "mbox": "http://patches.dpdk.org/series/30512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135044/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF4FE436C8;\n\tMon, 11 Dec 2023 18:25:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ACEA242DBE;\n\tMon, 11 Dec 2023 18:24:52 +0100 (CET)", "from mail-pg1-f171.google.com (mail-pg1-f171.google.com\n [209.85.215.171])\n by mails.dpdk.org (Postfix) with ESMTP id 80A5242D95\n for <dev@dpdk.org>; Mon, 11 Dec 2023 18:24:50 +0100 (CET)", "by mail-pg1-f171.google.com with SMTP id\n 41be03b00d2f7-5c701bd9a3cso759424a12.0\n for <dev@dpdk.org>; Mon, 11 Dec 2023 09:24:50 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n f16-20020aa782d0000000b006ce6878b274sm6494425pfn.216.2023.12.11.09.24.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 11 Dec 2023 09:24:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702315490;\n x=1702920290; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oMNS7zGLE/YNoxn7ndPcHRk5tzoRrQzhfWcHywJyY2s=;\n b=cnTtKYuRPNvO96Gi+GduPCFjWEf5k/2FPIAGVk+dZUnoZtbWjhzBuCgGZ1HRKMxdYH\n uKtYz2vwDgCLAnGqJcdREXlTBlybJ4ktdAk5OuTJKkmRPtneCZgmv13eqZwziFJXf+lq\n EbGt9uCSeu0QjqSHbTlOVswv3mTCHAzUjlf2GH0Tqpm5VltQvr5bOfIrIanzwA4djsAd\n LYeyU1uIsu5Md9yYcNBz/IfSA3egCtFPFM6UoEWaWVNbmAW5qLteLIPxfOBTynoVGJnF\n sTU5lXB8JtEjWrMgaXuaOF0VZdwbkQXQaar0wVLp5dpaNg3kb4SebrK/epMLpZ4/tte7\n R1fA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702315490; x=1702920290;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=oMNS7zGLE/YNoxn7ndPcHRk5tzoRrQzhfWcHywJyY2s=;\n b=q3z/shYOnzdRAy5V6z6r+IlwnxkLp8wMx7pD74Gvl478gpreEbY4hv+BFVqOa+7wCp\n LOjOutPgwN0mkb7zUrriG7zPU2c+oJnfEmra2ZZVKq4Rq1YiGO2ssdmP9fsIUC0YbpPP\n jlqAPuCQ8UVqBRQ/wl+mgdsXYCV2sGrcqjSJuxSgObvKMlrrxHnNGNmzStWElWZCwbs/\n DCusn3/2HEkw/pWTaFT/RJjBOcTq04N4lTOxsCaZ3KQ02EgmUP96QA6VZLiAl6nePSvK\n FGyim1NC6Jlg0kp64NOtws2GOYb4lGuSBrC4qegUIut180+0IBjdK4RKQtLcK33oMfZw\n NuGg==", "X-Gm-Message-State": "AOJu0Yyeuq/A3p6zbByHYWqIjMWFfC21QC1SpdbXux2JcqKdy0ftXgqR\n 6Th1jQcNVbgYnhmHLnV+GC6VZF4lnXAIWFpTxORMcg==", "X-Google-Smtp-Source": "\n AGHT+IFfqR4bMG5hNPVq1yWrhQXR3qNsEUkdzjvyNYZMO1LrOTi0MdYtENxNFQMQAvedEomKelHjJQ==", "X-Received": "by 2002:a05:6a20:6d9e:b0:190:665b:f789 with SMTP id\n gl30-20020a056a206d9e00b00190665bf789mr1869629pzb.83.1702315489739;\n Mon, 11 Dec 2023 09:24:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "Subject": "[PATCH 3/3] examples/vm_power_manager: do not use EAL logtype", "Date": "Mon, 11 Dec 2023 09:23:25 -0800", "Message-ID": "<20231211172437.61958-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231211172437.61958-1-stephen@networkplumber.org>", "References": "<20231211172437.61958-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Be consistent for all the error printouts and use fprintf().\nThe EAL logtype is reserved for internal use by EAL.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/vm_power_manager/main.c | 11 ++++-------\n 1 file changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c\nindex b159291d77ce..c14138202004 100644\n--- a/examples/vm_power_manager/main.c\n+++ b/examples/vm_power_manager/main.c\n@@ -17,7 +17,6 @@\n #include <rte_common.h>\n #include <rte_eal.h>\n #include <rte_launch.h>\n-#include <rte_log.h>\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_ethdev.h>\n@@ -425,8 +424,7 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(-1, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tprintf(\"Running channel monitor on lcore id %d\\n\", lcore_id);\n@@ -434,16 +432,15 @@ main(int argc, char **argv)\n \n \tlcore_id = rte_get_next_lcore(lcore_id, 1, 0);\n \tif (lcore_id == RTE_MAX_LCORE) {\n-\t\tRTE_LOG(ERR, EAL, \"A minimum of three cores are required to run \"\n-\t\t\t\t\"application\\n\");\n+\t\tfprintf(stderr, \"A minimum of three cores are required to run application\\n\");\n \t\treturn 0;\n \t}\n \tif (power_manager_init() < 0) {\n-\t\tprintf(\"Unable to initialize power manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize power manager\\n\");\n \t\treturn -1;\n \t}\n \tif (channel_manager_init(CHANNEL_MGR_DEFAULT_HV_PATH) < 0) {\n-\t\tprintf(\"Unable to initialize channel manager\\n\");\n+\t\tfprintf(stderr, \"Unable to initialize channel manager\\n\");\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "3/3" ] }{ "id": 135044, "url": "