Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135028/?format=api
{ "id": 135028, "url": "http://patches.dpdk.org/api/patches/135028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231211171109.89716-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231211171109.89716-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231211171109.89716-2-ajit.khaparde@broadcom.com", "date": "2023-12-11T17:10:56", "name": "[v3,01/14] net/bnxt: refactor epoch setting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "173cd65d15b4ad79b05bdb880807730072c4ce7b", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231211171109.89716-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 30511, "url": "http://patches.dpdk.org/api/series/30511/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30511", "date": "2023-12-11T17:10:55", "name": "support new 5760X P7 devices", "version": 3, "mbox": "http://patches.dpdk.org/series/30511/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135028/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0D517436C8;\n\tMon, 11 Dec 2023 18:11:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C221C42D7B;\n\tMon, 11 Dec 2023 18:11:21 +0100 (CET)", "from mail-qk1-f173.google.com (mail-qk1-f173.google.com\n [209.85.222.173])\n by mails.dpdk.org (Postfix) with ESMTP id 269D142D7A\n for <dev@dpdk.org>; Mon, 11 Dec 2023 18:11:21 +0100 (CET)", "by mail-qk1-f173.google.com with SMTP id\n af79cd13be357-77f552d4179so186233585a.1\n for <dev@dpdk.org>; Mon, 11 Dec 2023 09:11:21 -0800 (PST)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n qz16-20020a05620a8c1000b0077efdfbd730sm3094581qkn.34.2023.12.11.09.11.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 11 Dec 2023 09:11:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1702314680; x=1702919480; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=VF57EqXTgEW7ccyj6tFtKAzF+R7UkIkEkbd61aygsV8=;\n b=BlJTmWKRbUinNGXUv/aItg2pGyA74wDuTs6JwIIHn0Wmq3h87Ihp6/5/rtNyt1GrJg\n I7Vs9tGe64Xe9fl+9pdST059D9a/ZM4nMxK+Tr+ZmiLjw1hTf8CTkV/tfjmI4MpEPB2z\n 7P47d3s3vV3J7fyBWElyaZi4YEoSk9NptrkbY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702314680; x=1702919480;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=VF57EqXTgEW7ccyj6tFtKAzF+R7UkIkEkbd61aygsV8=;\n b=nArZBk4ZIrfdT0M57yyGfrA9dhi4h9+oO3pA4EXZTB1o8Xr2I7MMym8EdetaNTs3WE\n YTKKaHBhRsN2puL+RtdV45N/EvrwTQQQ41kNnqjO8duOxyad/hHn6k/9x20QnbCuFpaV\n WP6pxaxSOziN3IQb/US3rOGQeb2p4vhoR/XzdmBsGvGiKWc5udkZiB+2OTlfLV2gLgR5\n Erv1++FMCCdddJnbTx3FSjvjJGqOG5i4RL0JzfuHA4psljGQrq4+GpnZDHhlfsrZS0ek\n /LboGLOfpHjd9KRD3kd1O3luPDzNdH4sRteLeJdAOv7LP2BWtHqOcp1X4wpOBA15whkj\n O0qQ==", "X-Gm-Message-State": "AOJu0Yx0YwFQdvuc/uZLZTOXimnK2IBlSrFmpFGqAKdZSAZslOJfBndw\n vtpTpNbT9CQAl5htdHiOEt03CgEyX7tajEZYdZQPaj/CLeArdAvXUJgWUox6lSw9x+i/Hb2N1b5\n fOKDHc/cZkBLn77cMApxrWBcOcX2g4xTSMHiXfvWJsNKKoUbBHz1ET6k7CsU0jj9T4EaP", "X-Google-Smtp-Source": "\n AGHT+IEKTUPvjiDkY8tEskfZn2Z2nKCawFTKbMEKxQp3WFLjR3F9aMJiizvmWEQy73KrMlS5urPCAw==", "X-Received": "by 2002:a05:620a:3:b0:77f:37e7:bd6e with SMTP id\n j3-20020a05620a000300b0077f37e7bd6emr5790603qki.121.1702314680128;\n Mon, 11 Dec 2023 09:11:20 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>", "Subject": "[PATCH v3 01/14] net/bnxt: refactor epoch setting", "Date": "Mon, 11 Dec 2023 09:10:56 -0800", "Message-Id": "<20231211171109.89716-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20231211171109.89716-1-ajit.khaparde@broadcom.com>", "References": "<20231211171109.89716-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000d44591060c3f05c9\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix epoch bit setting when we ring the doorbell.\nEpoch bit needs to toggle alternatively from 0 to 1 every time the\nring indices wrap.\nCurrently its value is everything but an alternating 0 and 1.\n\nRemove unnecessary field db_epoch_shift from\nbnxt_db_info structure.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.h | 5 ++---\n drivers/net/bnxt/bnxt_ring.c | 9 ++-------\n 2 files changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h\nindex 2de154322d..26e81a6a7e 100644\n--- a/drivers/net/bnxt/bnxt_cpr.h\n+++ b/drivers/net/bnxt/bnxt_cpr.h\n@@ -53,11 +53,10 @@ struct bnxt_db_info {\n \tbool db_64;\n \tuint32_t\t\tdb_ring_mask;\n \tuint32_t\t\tdb_epoch_mask;\n-\tuint32_t\t\tdb_epoch_shift;\n };\n \n-#define DB_EPOCH(db, idx)\t(((idx) & (db)->db_epoch_mask) <<\t\\\n-\t\t\t\t ((db)->db_epoch_shift))\n+#define DB_EPOCH(db, idx)\t(!!((idx) & (db)->db_epoch_mask) <<\t\\\n+\t\t\t\t DBR_EPOCH_SFT)\n #define DB_RING_IDX(db, idx)\t(((idx) & (db)->db_ring_mask) |\t\t\\\n \t\t\t\t DB_EPOCH(db, idx))\n \ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 34b2510d54..6dacb1b37f 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -371,9 +371,10 @@ static void bnxt_set_db(struct bnxt *bp,\n \t\t\tdb->db_key64 = DBR_PATH_L2;\n \t\t\tbreak;\n \t\t}\n-\t\tif (BNXT_CHIP_SR2(bp)) {\n+\t\tif (BNXT_CHIP_P7(bp)) {\n \t\t\tdb->db_key64 |= DBR_VALID;\n \t\t\tdb_offset = bp->legacy_db_size;\n+\t\t\tdb->db_epoch_mask = ring_mask + 1;\n \t\t} else if (BNXT_VF(bp)) {\n \t\t\tdb_offset = DB_VF_OFFSET;\n \t\t}\n@@ -397,12 +398,6 @@ static void bnxt_set_db(struct bnxt *bp,\n \t\tdb->db_64 = false;\n \t}\n \tdb->db_ring_mask = ring_mask;\n-\n-\tif (BNXT_CHIP_SR2(bp)) {\n-\t\tdb->db_epoch_mask = db->db_ring_mask + 1;\n-\t\tdb->db_epoch_shift = DBR_EPOCH_SFT -\n-\t\t\t\t\trte_log2_u32(db->db_epoch_mask);\n-\t}\n }\n \n static int bnxt_alloc_cmpl_ring(struct bnxt *bp, int queue_index,\n", "prefixes": [ "v3", "01/14" ] }