Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135004/?format=api
{ "id": 135004, "url": "http://patches.dpdk.org/api/patches/135004/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231211054526.1701663-3-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231211054526.1701663-3-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231211054526.1701663-3-chaoyong.he@corigine.com", "date": "2023-12-11T05:45:26", "name": "[2/2] net/nfp: fix invalid Rx descriptor data", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5a15ef01c033ba3182058eec9f1a5eaec5516cef", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231211054526.1701663-3-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30503, "url": "http://patches.dpdk.org/api/series/30503/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30503", "date": "2023-12-11T05:45:24", "name": "fix problem in Rx", "version": 1, "mbox": "http://patches.dpdk.org/series/30503/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135004/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135004/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA8EE436C4;\n\tMon, 11 Dec 2023 06:46:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A4C5E40E72;\n\tMon, 11 Dec 2023 06:45:55 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2130.outbound.protection.outlook.com [40.107.223.130])\n by mails.dpdk.org (Postfix) with ESMTP id B8321402B2;\n Mon, 11 Dec 2023 06:45:52 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH0PR13MB5975.namprd13.prod.outlook.com (2603:10b6:510:16e::5)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec\n 2023 05:45:51 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023\n 05:45:51 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=a3o2hbbMgijxTTkBz/FC44kq7zs6OZNarjpqvBYPFnUMJT6Itrz5quJR9rsDRAaNVbZHo/PuRNGiIO9rkB/tI2ISrHK9+34ZqETcWsBrWFTEmRdVJpAuPihV4iX2Nl6NzYa86DCRWa/+D4rHj+mbUGqmaYp+nurACf7RskH7FIdlxfEEl/d+iwcFeRW48Txh6k5Thk3I7fcHZjlw265cQsCGJeA7+rw5AqyJCCTlMfuSUH/QjY+oA6CDg1FuRYTEEwDXnahDBTtTVgMpgyPud35ItaBRSBNrRfEJtfTLQA8J9LN+niLsg5EcXYjagCuKEmbNDOn5qz2KjkmKBT7i3Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=58RPhZhj+AlxJkJL6FjzBhhmkzFXzbw2zBPgTX1EN9k=;\n b=DFeP0J3bl8AoDEr1dPnqLaPHrmaM72lKf6rb+Blfjf4hWrbMTv4jPIcDec9c3JONHaGwzyfkogR12Vg25+rgWZdihHIz3NGF4x/Y6HPj8jsDoVtu9kLTRQJC3cUz9pgGy2ZyIZED1OUQYm5ByANrEMlA5xLJDjLQTRP51AT8NTYSsuE9Rbmt4i5R5Uv+/oT8uH+bW/nfdRg0HSq4ZSTXHNlbdK/pSUCMl3LsF2vT9js4IYriUSz2Ydh2x574iyQQxwxmWlvpU6hS8W/WR5sQUDKrC4Vb0cprYnypsqNV1PoO2qaEzoWEfxl2xkRy1DhF1i7FPJiY5jOxHoC3VQHAKw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=58RPhZhj+AlxJkJL6FjzBhhmkzFXzbw2zBPgTX1EN9k=;\n b=cq/fT4/3Qr/v/9a5E8RY7BpjVJJJyWMTQdFBONeW49dIsbyzJ7Dg5xgBS/3C9x8PmSXsenfCEoMpUNlNLZxcYbbbZpSz+2TZ7YfZxJ0BPhgf7ASI5/JkrQL6kUbCs3h4naQs9yeWaQDDcqpE8+rpQj8MX52SBTLZWFSSRd8AUBc=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n chaoyong.he@corigine.com, stable@dpdk.org,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 2/2] net/nfp: fix invalid Rx descriptor data", "Date": "Mon, 11 Dec 2023 13:45:26 +0800", "Message-Id": "<20231211054526.1701663-3-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231211054526.1701663-1-chaoyong.he@corigine.com>", "References": "<20231211054526.1701663-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BY3PR05CA0005.namprd05.prod.outlook.com\n (2603:10b6:a03:254::10) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH0PR13MB5975:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9245b0f7-9e0b-4690-9ac7-08dbfa0c6ef3", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n wzVSWyJK2t0iNlmdQR4O1og+Jz1g7/04vYnaHWz1UKkIe5cJpZBWFhBk9FYr3iLIFAFKU9fFGp5Y2EDrJz5chmhmTolecgS5BOdpskbmCCbj09E+VBn/fdaSeWS0aPJQthmHMXrLLs2Jhd/ntAl/3mynZyPCFySwD60RDjQp/Putafpo8aX7p+48zROOFSKnauqaIytvWCHfz/VnJh6MzwlAPq7dD3xAweNanCQmC/DJp36oDQx/TgVFyX0WvdgyhYA+5PTWRdBp89PKe6OaiBAKffkhIeitQrPYwc0ACTTfLwEDu19nDSYDchSpjJA0bx/SsdaWGogPuTr6K8QfwJUDaxM4xJ+4rQNvb+NpP8AIgiphqIHH8pipyTkg7Ea/aN7tKZsQoAtPX+t7ACL/eRPMwPADTAYCGd75YSdEgSwz/o8HGkiWYuZBKglZhZNTI86+N0lKIHpl33pMwlb9wYExt3w6H1StsfoC2DlaKTrsLFiYn82Qh+H9qjIhMFA7HKNZD5edx/A2RV+2Z0EX8UPp0jXST1ji6LjspXwcgKGlRSqvESFNLYCZH+UC7pkBrC7oOGUBxOlWkVBcOdm/5KTysUwvJU1qEXPIC9wjbf4Tu06R5kGSN+n1VYLnG8ogfj1TYTDi/IMdyM0GjLZ+QR47vb6jI+IzJ6ctEbYfpHc=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(366004)(136003)(346002)(376002)(396003)(39830400003)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(107886003)(6486002)(478600001)(2616005)(1076003)(26005)(6666004)(6506007)(52116002)(6512007)(38350700005)(38100700002)(86362001)(36756003)(41300700001)(44832011)(5660300002)(6916009)(66476007)(54906003)(2906002)(83380400001)(66946007)(4326008)(450100002)(316002)(8676002)(8936002)(66556008);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n mu9iSvczC8kSyiC2yHvV+9+wI9Vs6HshvUvIG1klgtR8HpE6jM2ulFp/cSYIrkIBq/bHVmyTKPoKvR9hMUIWe6opHHljjfSRYFmtAfBz26ge2EhkSPPW9IB+150eUQhzgDtxmEngXMIpek/jGfSJUCwyX0kwn++0QnodKXr9nsug9Vs93Xu9CHopHo6zP/30LFP3q58+g5BFuSp03ALiNZ2uH7Zg5AxQvRPOBnr9ASNwdxLecslmyUF6+ODoQ6I88AxWoTQKw6HIIr5m+8hWkWsh/bz16cIP/N8KHUQGxgrc6UOxWpG8+67i1ZnQ8H0dChLF+MF4DvwY0bi5Sdhqq9AxpgGxqBpg3lLNwdn9RjVDqpCZLhS2zwuzZ42f18oE2A2Ybb4KNGqrFs5KtHIOCDQOx9RmirKXQ6r5Do9KatrVSiqDmRbuXoAHi3s+biK/0A+vvxiaXbqY16vPN+Klfx5nSYXOH/PnEcBEcufvs/HusJOXKM6JuD85YAvysSQiXSWyL+po6h0wVE68CFa16W2H9NM+NisjkZjaAYHMUMCs3hv+chSTymwxPrUOCI512JBw0rAFdCla+LTK39ypvSPFumBW+MbAyMKYrO4TFA9RHNDwd+hr3pd7QiR/lbr0dIifk9aEcqmSV0w2GzUXvowT5bBgH8xY4sSrvmcv2PQKeCiuHBDj14d2snNOb6lFGqDLd09rH8u4CXbumfBmOxVhal6StO1R7qsnfBkattLKQItYhMJ4eYxNj2YvKGtPNOeWOYxU5zrO18+qOvN07HneYM3XzLAUH0jev5EE1WMfNidAQn1wamKVvq0Ew7LTqHEw91zVQnKijOgUB9/FeEV/31RhnBIKRXfxc9OCbYIuy3IkcxBjJ6g7BO43bVKYtViWDIyIrF9iiaycR7Dg5V4evwa2f/kbYU4wOzIH/x9tHMuZ579etdTE5ZkSo30SeOsY2MW419OcflqC58FJtDUS8jTbJ3B28kz39PLlwnX1ye7ygYe1vQq34CGNZzO07IsGh1+XAtyxS9SuSnqDac3g85OADn/PCjFyyQnoa+ah9yhEmxXn+iv4/ihsPRh5yJcb/wYvOjfny/t8dpAAKNZxxA2NsOO/mYcNlqbBzqGgIm5OJHgarELNIzzDCkL+k0JZpeoe1CDz5SH4uJXUyG7EmLTcBftCptBlcvU44OlUVMCIk8rgG7ydxA3ZZEa64sAB55TVDQJZjBUr0gPnc8za/EtyZ0Wb8xCDs2IzDXZg12zx72hfpLjF2/L2U9sGZO24TXiie8AoczJbILEnxsX66apqRlSV3EBx/6tYpS354QjBaKiLiUoTNRms7sWdC43FrYT/Rz0LyWs/aBkwSKPrCUwi2F4VdEd9Dlz1FzQbi+ZrqzJ6KyBmCq43aRkt3j2/EbADxiOB7LakwimsszwRwP8dilGms0ZQiR4YjGnoXbEoNrZouofpl2WmXLH9RyXjQ0QnvWZso5ONKobw5/2g61fAuossLwcaN0BVNKR/MyMlPyzc0/AP3MHxL3BAG9snrYQXQ9McnotQ03A3owtLXKUe5Xjq28OsmAwpr7O1pVypKurCu6oir4cTkTeIvyno+2a4gfOgm2kB8Tu0UA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9245b0f7-9e0b-4690-9ac7-08dbfa0c6ef3", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Dec 2023 05:45:51.3709 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n xqN8t/B7gt/kHMhuHx1bFowyy/utsXxeF7AfkEBYDIwIv31PKlTuJE6EKG3FY08RqsLMQpkUL6BpveSAMozkN3frZMCVUj8dgjug2psbG+4=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH0PR13MB5975", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nIf the Rx loop is broken and PMD does not update the descriptor, packets\nwill can not be received successfully.\n\nFixes: 766d51c9ce29 (\"net/nfp: merge receive function\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_rxtx.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 5094bbf145..3840e2372c 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -765,15 +765,6 @@ nfp_net_recv_pkts(void *rx_queue,\n \t\t/* Checking the checksum flag */\n \t\tnfp_net_rx_cksum(rxq, rxds, mb);\n \n-\t\tif (meta.port_id == 0) {\n-\t\t\trx_pkts[avail++] = mb;\n-\t\t} else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {\n-\t\t\tavail_multiplexed++;\n-\t\t} else {\n-\t\t\trte_pktmbuf_free(mb);\n-\t\t\tbreak;\n-\t\t}\n-\n \t\t/* Now resetting and updating the descriptor */\n \t\trxds->vals[0] = 0;\n \t\trxds->vals[1] = 0;\n@@ -786,6 +777,15 @@ nfp_net_recv_pkts(void *rx_queue,\n \t\trxq->rd_p++;\n \t\tif (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */\n \t\t\trxq->rd_p = 0;\n+\n+\t\tif (meta.port_id == 0) {\n+\t\t\trx_pkts[avail++] = mb;\n+\t\t} else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {\n+\t\t\tavail_multiplexed++;\n+\t\t} else {\n+\t\t\trte_pktmbuf_free(mb);\n+\t\t\tbreak;\n+\t\t}\n \t}\n \n \tif (nb_hold == 0)\n", "prefixes": [ "2/2" ] }