List comments

GET /api/patches/135/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 349,
        "web_url": "http://patches.dpdk.org/comment/349/",
        "msgid": "<53E9D287.7020404@6wind.com>",
        "date": "2014-08-12T08:38:31",
        "subject": "Re: [dpdk-dev] [RFC PATCH 03/14] mbuf: remove the rte_pktmbuf\n\tstructure",
        "submitter": {
            "id": 8,
            "url": "http://patches.dpdk.org/api/people/8/",
            "name": "Olivier Matz",
            "email": "olivier.matz@6wind.com"
        },
        "content": "Hi Bruce,\n\nOn 08/11/2014 10:44 PM, Bruce Richardson wrote:\n> From: Olivier Matz <olivier.matz@6wind.com>\n>\n> The rte_pktmbuf structure was initially included in the rte_mbuf\n> structure. This was needed when there was 2 types of mbuf (ctrl and\n> packet). As the control mbuf has been removed, we can merge the\n> rte_pktmbuf into the rte_mbuf structure.\n>\n> Advantages of doing this:\n>    - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data)\n>    - make the structure more consistent: for instance, there was no reason\n>      to have the ol_flags field in rte_mbuf\n>    - it will allow a deeper reorganization of the rte_mbuf structure in the\n>      next commits, allowing to gain several bytes in it\n>\n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n>\n> Conflicts:\n> \tlib/librte_pmd_virtio/virtio_rxtx.c\n> \tlib/librte_pmd_virtio/virtqueue.h\n> \tlib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n>\n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nSome files are missing. We can find some with: git grep \"pkt\\.\" in\napp/test/packet_burst_generator.c\nexamples/ip_fragmentation/main.c\nexamples/ip_pipeline/pipeline_rx.c\nexamples/ip_pipeline/pipeline_tx.c\nlib/librte_port/rte_port_frag.c\n\nI'm not sure it gives all remaining occurences. The best way\nto find them is probably to check the compilation of examples\nfor all targets.\n\n\nOlivier",
        "headers": {
            "Return-Path": "<olivier.matz@6wind.com>",
            "MIME-Version": "1.0",
            "X-Mailman-Version": "2.1.15",
            "Date": "Tue, 12 Aug 2014 10:38:31 +0200",
            "X-List-Received-Date": "Tue, 12 Aug 2014 08:35:38 -0000",
            "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0",
            "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>\n\t<1407789890-17355-4-git-send-email-bruce.richardson@intel.com>",
            "Content-Type": "text/plain; charset=ISO-8859-1; format=flowed",
            "X-BeenThere": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:message-id:date:from:user-agent:mime-version:to\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding;\n\tbh=t+VnNMm6ZwAJ/NxK8I3DJp1d1+nUMG4Yf7w7voTTN1E=;\n\tb=J3fqz9NKVKVB81erl0X4eLvcICzyxJhXAYe60a4OcnirxttSJWdioBbPgd/Jt1nvIh\n\tLrxfOkf7Ha86qrLiHWIVbSi4zQEHB0EE6nBjzsvjthB6Zw4TzRq5LsJDtQY6puDTAF23\n\tyF/qtlFWHfbsWXaZ4jdIG3EvEIkqnilJYooEty6x9SBPdUR7wKn2yIUlwTk3e5e9KNW5\n\tbM5jTkFCPyWZ0BINUxWLmOj96UDR0cY+Pkj35fuD55otrP6hUqCav+Lv0KY/eOFqkXD6\n\tQpd+9ILJLlXN2JiT2j/a3zCTtTORagVx46inGszxoG9pRxkci7mMELEA86A2k0rEgPGz\n\tTumw==",
            "Received": [
                "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id B25F5B3A7\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 10:35:38 +0200 (CEST)",
                "by mail-wi0-f170.google.com with SMTP id f8so6647805wiw.1\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 01:38:33 -0700 (PDT)",
                "from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tbx2sm7604009wjb.47.2014.08.12.01.38.31 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tTue, 12 Aug 2014 01:38:32 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [RFC PATCH 03/14] mbuf: remove the rte_pktmbuf\n\tstructure",
            "X-Received": "by 10.180.73.6 with SMTP id h6mr31023398wiv.65.1407832713168;\n\tTue, 12 Aug 2014 01:38:33 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Message-ID": "<53E9D287.7020404@6wind.com>",
            "Precedence": "list",
            "X-Gm-Message-State": "ALoCoQm99cQXhO+AjdANm6OlPvmw3BvjlVGl4erJWuiUzKEHyt2hpFVQ845etOXfXAoxxBiJVUjV",
            "From": "Olivier MATZ <olivier.matz@6wind.com>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "In-Reply-To": "<1407789890-17355-4-git-send-email-bruce.richardson@intel.com>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "7bit",
            "To": "Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org"
        }
    }
]