Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134990/?format=api
{ "id": 134990, "url": "http://patches.dpdk.org/api/patches/134990/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231210012455.20229-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231210012455.20229-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231210012455.20229-12-ajit.khaparde@broadcom.com", "date": "2023-12-10T01:24:52", "name": "[v2,11/14] net/bnxt: modify sending new HWRM commands to firmware", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b138bafdb73451f30b1da195c06496df09ecf6e3", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231210012455.20229-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 30499, "url": "http://patches.dpdk.org/api/series/30499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30499", "date": "2023-12-10T01:24:41", "name": "support new 5760X P7 devices", "version": 2, "mbox": "http://patches.dpdk.org/series/30499/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134990/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96FEF436BE;\n\tSun, 10 Dec 2023 02:33:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 976CB40ED9;\n\tSun, 10 Dec 2023 02:31:59 +0100 (CET)", "from mail-oa1-f52.google.com (mail-oa1-f52.google.com\n [209.85.160.52]) by mails.dpdk.org (Postfix) with ESMTP id 9FA7440DCE\n for <dev@dpdk.org>; Sun, 10 Dec 2023 02:31:55 +0100 (CET)", "by mail-oa1-f52.google.com with SMTP id\n 586e51a60fabf-1fb04fb8d28so2015769fac.3\n for <dev@dpdk.org>; Sat, 09 Dec 2023 17:31:55 -0800 (PST)", "from localhost.localdomain\n ([2605:a601:a780:1400:6d20:fff:e413:282a])\n by smtp.gmail.com with ESMTPSA id\n q3-20020a170902f78300b001d083fed5f3sm4006050pln.60.2023.12.09.17.31.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 09 Dec 2023 17:31:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1702171914; x=1702776714; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=dqaTeIe5rP8O548/FdoiAFmXeb8rPwoZ0/wzlUTixPc=;\n b=YBslGo2ZmP+DUaUOqbuSyBr0oDdSx2RX3sMgE9XwOrHZsSwxgSvyH2bWlEIZJH67Jm\n kOrjyQcufESNHL2tJFI5R/G6+UiDD6vP9C6KjApsBvB1W2CDUjVKqO0cox8q2HSNDE6j\n o+NOV+gf+nym5FzGbaD1rqmwMiuwDHGdSKeZQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702171914; x=1702776714;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=dqaTeIe5rP8O548/FdoiAFmXeb8rPwoZ0/wzlUTixPc=;\n b=T4X/eQISmi81PA+CtI4w8qxW+6nEEGefVlkFnk8SUiV5S+RWha0Yg7X6biqgnBd5qA\n +n4F4wP0sMgfnajyVvK6jOFm3Fn0FIblrKQk2+z+hZRkBfttK0XsthnwOcvJvfL0fACj\n ouh6+oMZZjmwwwHFIQYQikodr10dzGDIIQloXjNTJyMzViU+B3iluIgJ+W8QLlPozlAc\n 7UdPU3A4bkqNZa0LDcw2xrquetRX7Fz2nzACr9RMbNiK/+imeEChrHoetuBc96OqSHf+\n vdJCkzOpWKPgPzrmwLtajMzqy3V4wqIBH5+xtv15L10lyN27Ux7IIGRoKh2XrM2ve7lL\n nXfw==", "X-Gm-Message-State": "AOJu0Yxp1JnvAhrBtI72f5+uQH/F1WlxO6pHuoR+V04rS+qGFo6fN+Xr\n p0RcGLvGg4kqq6d+EOHVchZZSwl1gzvdw2lhAUpKY3jf31iU/IDQAh9WtncWmFhi7u1o5nkV6kg\n +nh/sceTAEf1pEh1WTp84UYiUe6GBfRuPjdhbSoV3gppSZWihQw30Np3jf7+MyjiJtyzC", "X-Google-Smtp-Source": "\n AGHT+IG9Du8XXE8g41XI1a79V8WmfY3myDvLdMz3u9eWVpCGXlHAlHmIEPzqqGW8L35TY+WzDMo3nQ==", "X-Received": "by 2002:a05:6358:cd20:b0:170:30db:119c with SMTP id\n gv32-20020a056358cd2000b0017030db119cmr812668rwb.29.1702171914399;\n Sat, 09 Dec 2023 17:31:54 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>", "Subject": "[PATCH v2 11/14] net/bnxt: modify sending new HWRM commands to\n firmware", "Date": "Sat, 9 Dec 2023 17:24:52 -0800", "Message-Id": "<20231210012455.20229-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20231210012455.20229-1-ajit.khaparde@broadcom.com>", "References": "<20231210012455.20229-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000555c71060c1dc85c\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If the firmware fails to respond a HWRM command in a certain time,\nit may be because the firmware is in a bad state.\nDo not send any new HWRM commands in such a scenario.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_hwrm.c | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 68c4778dc3..f7a60eb9a1 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -745,6 +745,7 @@ struct bnxt {\n #define BNXT_FLAG_DFLT_MAC_SET\t\t\tBIT(26)\n #define BNXT_FLAG_GFID_ENABLE\t\t\tBIT(27)\n #define BNXT_FLAG_CHIP_P7\t\t\tBIT(30)\n+#define BNXT_FLAG_FW_TIMEDOUT\t\t\tBIT(31)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n #define BNXT_NPAR(bp)\t\t((bp)->flags & BNXT_FLAG_NPAR_PF)\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex dda3d3a6ac..2835d48a0e 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -215,6 +215,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \tif (bp->flags & BNXT_FLAG_FATAL_ERROR)\n \t\treturn 0;\n \n+\t/* If previous HWRM command timed out, donot send new HWRM command */\n+\tif (bp->flags & BNXT_FLAG_FW_TIMEDOUT)\n+\t\treturn 0;\n+\n \ttimeout = bp->hwrm_cmd_timeout;\n \n \t/* Update the message length for backing store config for new FW. */\n@@ -315,6 +319,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t \"Error(timeout) sending msg 0x%04x, seq_id %d\\n\",\n \t\t\t req->req_type, req->seq_id);\n+\t\tbp->flags |= BNXT_FLAG_FW_TIMEDOUT;\n \t\treturn -ETIMEDOUT;\n \t}\n \treturn 0;\n", "prefixes": [ "v2", "11/14" ] }