Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134815/?format=api
{ "id": 134815, "url": "http://patches.dpdk.org/api/patches/134815/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231204183710.86921-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231204183710.86921-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231204183710.86921-2-ajit.khaparde@broadcom.com", "date": "2023-12-04T18:36:57", "name": "[01/14] net/bnxt: refactor epoch setting", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "173cd65d15b4ad79b05bdb880807730072c4ce7b", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231204183710.86921-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 30445, "url": "http://patches.dpdk.org/api/series/30445/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30445", "date": "2023-12-04T18:36:56", "name": "support new 5760X P7 devices", "version": 1, "mbox": "http://patches.dpdk.org/series/30445/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134815/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134815/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64D3C4366C;\n\tMon, 4 Dec 2023 19:37:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B84274113D;\n\tMon, 4 Dec 2023 19:37:23 +0100 (CET)", "from mail-pg1-f171.google.com (mail-pg1-f171.google.com\n [209.85.215.171])\n by mails.dpdk.org (Postfix) with ESMTP id 632D0400EF\n for <dev@dpdk.org>; Mon, 4 Dec 2023 19:37:22 +0100 (CET)", "by mail-pg1-f171.google.com with SMTP id\n 41be03b00d2f7-5c230c79c0bso1729346a12.1\n for <dev@dpdk.org>; Mon, 04 Dec 2023 10:37:22 -0800 (PST)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n s3-20020a056a00178300b006be5af77f06sm4236664pfg.2.2023.12.04.10.37.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Dec 2023 10:37:20 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1701715041; x=1702319841; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=sW3bUU3iwzGKxIqBME0K1KjOs/ki9KFjtPytKKaiTKM=;\n b=DD3spO7BUyjOQExKYETlI7lJKXH9WJWcS2D1QzWtnK025lCmTf2GbSVKhB/Xi8rsbl\n Z6qB8FoWPuj98VOnTNNr1NMrsy4cSzfpFWsC7PGeTouvnC9iPPogzE4TpkWA/Y/48NqY\n cF47OmMe/QTPBb071GZP8xnf/SklTsrNNIsEk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701715041; x=1702319841;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=sW3bUU3iwzGKxIqBME0K1KjOs/ki9KFjtPytKKaiTKM=;\n b=hytlfWYYd4tDabCk+cqSCBESBYkq8t8adPvU6jRhzaDjUEcDYIdDypBFFgtyGBUeYz\n fs7t3q36LozYePVaV5MSCT8TQKEyaIbSX4Ig6qAWXSGAucERaMsjSwonAwDap03NmW1T\n /b+M5qMEA6+KQhD0EuCnwVMdYrldGm1A6TfkTOp8lruGRkm4DVIb3USl2VK0xnpiPPgd\n esuRPPlX6oXb2GWeAkZfdTgEqK3QVXVC0jWn8IiqKLCu0z99OiMrobquPZv4uxAZSzOE\n BCxUDVC2xUIl1l1IrzYQK8bvpldCeIuQbM6hGTyiJUwsR/ZQVvCHodyH0cJeFdtDn4MP\n FXww==", "X-Gm-Message-State": "AOJu0YyS1WkgnPv19Nua5NIhAmd8RyiartSrOg4DKsPphQs06lnCLElf\n Iza4Ix3o8NGifd/LJ54d8zgYtcNHDPtAfbXQ6vVE60NoWazvJI6gTZsGD3FKPsHZTDUbkemubBh\n h6YdV9vpnez3ds+rdFQGmyx6N2GYa8Y7fP5OQKxhyPNp+1H7jvLGMJAzEX2BUcJ6wp7mo", "X-Google-Smtp-Source": "\n AGHT+IHQLsko4ChDSi2nmvZf2Dh0h1H7wlNYkGnASfjgv6olOFvFARM/3N9cKkltj59xHTsb55lt+w==", "X-Received": "by 2002:a05:6a20:8408:b0:18f:97c:b9eb with SMTP id\n c8-20020a056a20840800b0018f097cb9ebmr3079018pzd.69.1701715041062;\n Mon, 04 Dec 2023 10:37:21 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>", "Subject": "[PATCH 01/14] net/bnxt: refactor epoch setting", "Date": "Mon, 4 Dec 2023 10:36:57 -0800", "Message-Id": "<20231204183710.86921-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20231204183710.86921-1-ajit.khaparde@broadcom.com>", "References": "<20231204183710.86921-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"0000000000008f2426060bb368b9\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix epoch bit setting when we ring the doorbell.\nEpoch bit needs to toggle alreanately from 0 to 1 everytime the\nring indices wrap.\nCurrently its value is everything but an alternating 0 and 1.\n\nRemove unnecessary field db_epoch_shift from\nbnxt_db_info structure.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.h | 5 ++---\n drivers/net/bnxt/bnxt_ring.c | 9 ++-------\n 2 files changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h\nindex 2de154322d..26e81a6a7e 100644\n--- a/drivers/net/bnxt/bnxt_cpr.h\n+++ b/drivers/net/bnxt/bnxt_cpr.h\n@@ -53,11 +53,10 @@ struct bnxt_db_info {\n \tbool db_64;\n \tuint32_t\t\tdb_ring_mask;\n \tuint32_t\t\tdb_epoch_mask;\n-\tuint32_t\t\tdb_epoch_shift;\n };\n \n-#define DB_EPOCH(db, idx)\t(((idx) & (db)->db_epoch_mask) <<\t\\\n-\t\t\t\t ((db)->db_epoch_shift))\n+#define DB_EPOCH(db, idx)\t(!!((idx) & (db)->db_epoch_mask) <<\t\\\n+\t\t\t\t DBR_EPOCH_SFT)\n #define DB_RING_IDX(db, idx)\t(((idx) & (db)->db_ring_mask) |\t\t\\\n \t\t\t\t DB_EPOCH(db, idx))\n \ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 34b2510d54..6dacb1b37f 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -371,9 +371,10 @@ static void bnxt_set_db(struct bnxt *bp,\n \t\t\tdb->db_key64 = DBR_PATH_L2;\n \t\t\tbreak;\n \t\t}\n-\t\tif (BNXT_CHIP_SR2(bp)) {\n+\t\tif (BNXT_CHIP_P7(bp)) {\n \t\t\tdb->db_key64 |= DBR_VALID;\n \t\t\tdb_offset = bp->legacy_db_size;\n+\t\t\tdb->db_epoch_mask = ring_mask + 1;\n \t\t} else if (BNXT_VF(bp)) {\n \t\t\tdb_offset = DB_VF_OFFSET;\n \t\t}\n@@ -397,12 +398,6 @@ static void bnxt_set_db(struct bnxt *bp,\n \t\tdb->db_64 = false;\n \t}\n \tdb->db_ring_mask = ring_mask;\n-\n-\tif (BNXT_CHIP_SR2(bp)) {\n-\t\tdb->db_epoch_mask = db->db_ring_mask + 1;\n-\t\tdb->db_epoch_shift = DBR_EPOCH_SFT -\n-\t\t\t\t\trte_log2_u32(db->db_epoch_mask);\n-\t}\n }\n \n static int bnxt_alloc_cmpl_ring(struct bnxt *bp, int queue_index,\n", "prefixes": [ "01/14" ] }