Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134783/?format=api
http://patches.dpdk.org/api/patches/134783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231204075048.894-4-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231204075048.894-4-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231204075048.894-4-fengchengwen@huawei.com", "date": "2023-12-04T07:50:45", "name": "[RFC,v2,3/6] test/argparse: add verify argument config test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "71be30cc765c8dd0c7f41aea786699c381962ad8", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231204075048.894-4-fengchengwen@huawei.com/mbox/", "series": [ { "id": 30439, "url": "http://patches.dpdk.org/api/series/30439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30439", "date": "2023-12-04T07:50:42", "name": "add argparse library", "version": 2, "mbox": "http://patches.dpdk.org/series/30439/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134783/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/134783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D1AB44365D;\n\tMon, 4 Dec 2023 08:54:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 86572406B8;\n\tMon, 4 Dec 2023 08:54:02 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id ED277402AE\n for <dev@dpdk.org>; Mon, 4 Dec 2023 08:53:58 +0100 (CET)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.54])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SkG575lbxz14L7K;\n Mon, 4 Dec 2023 15:48:59 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Mon, 4 Dec 2023 15:53:56 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>,\n <stephen@networkplumber.org>", "CC": "<tangkunshan@huawei.com>", "Subject": "[RFC v2 3/6] test/argparse: add verify argument config test", "Date": "Mon, 4 Dec 2023 07:50:45 +0000", "Message-ID": "<20231204075048.894-4-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231204075048.894-1-fengchengwen@huawei.com>", "References": "<20231121122651.7078-1-fengchengwen@huawei.com>\n <20231204075048.894-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit adds verify argument config test.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test/meson.build | 1 +\n app/test/test_argparse.c | 327 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 328 insertions(+)\n create mode 100644 app/test/test_argparse.c", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex dcc93f4a43..864b79d39f 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -27,6 +27,7 @@ source_file_deps = {\n # the various test_*.c files\n 'test_acl.c': ['net', 'acl'],\n 'test_alarm.c': [],\n+ 'test_argparse.c': ['argparse'],\n 'test_atomic.c': ['hash'],\n 'test_barrier.c': [],\n 'test_bitcount.c': [],\ndiff --git a/app/test/test_argparse.c b/app/test/test_argparse.c\nnew file mode 100644\nindex 0000000000..d38ffb5775\n--- /dev/null\n+++ b/app/test/test_argparse.c\n@@ -0,0 +1,327 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2023 HiSilicon Limited\n+ */\n+\n+#include <stdio.h>\n+#include <string.h>\n+\n+#include <rte_argparse.h>\n+\n+#include \"test.h\"\n+\n+static int default_argc;\n+static char *default_argv[1];\n+\n+/*\n+ * Define strdup wrapper.\n+ * 1. Mainly to fix compile error \"warning: assignment discards 'const'\n+ * qualifier from pointer target type [-Wdiscarded-qualifiers]\" for\n+ * following code:\n+ * argv[x] = \"100\";\n+ * 2. Because this is a test, the memory release which allocated by this\n+ * wrapper in the subtest is not considered.\n+ */\n+static char *\n+test_strdup(const char *str)\n+{\n+\tchar *s = strdup(str);\n+\tif (s == NULL)\n+\t\texit(-ENOMEM);\n+\treturn s;\n+}\n+\n+static int\n+test_argparse_setup(void)\n+{\n+\tdefault_argc = 1;\n+\tdefault_argv[0] = test_strdup(\"test_argparse\");\n+\treturn 0;\n+}\n+\n+static void\n+test_argparse_teardown(void)\n+{\n+\tfree(default_argv[0]);\n+}\n+\n+static int\n+test_argparse_callback(uint32_t index, const char *value, void *opaque)\n+{\n+\tRTE_SET_USED(index);\n+\tRTE_SET_USED(value);\n+\tRTE_SET_USED(opaque);\n+\treturn 0;\n+}\n+\n+/* valid templater, must contain at least two args. */\n+#define argparse_templater() { \\\n+\t.prog_name = \"test_argparse\", \\\n+\t.usage = \"-a xx -b yy\", \\\n+\t.descriptor = NULL, \\\n+\t.epilog = NULL, \\\n+\t.exit_on_error = false, \\\n+\t.callback = test_argparse_callback, \\\n+\t.args = { \\\n+\t\t{ \"--abc\", \"-a\", \"abc argument\", (void *)1, (void *)1, RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT }, \\\n+\t\t{ \"--xyz\", \"-x\", \"xyz argument\", (void *)1, (void *)2, RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT }, \\\n+\t\tARGPARSE_ARG_END(), \\\n+\t}, \\\n+}\n+\n+static void\n+test_argparse_copy(struct rte_argparse *dst, struct rte_argparse *src)\n+{\n+\tuint32_t i;\n+\tmemcpy(dst, src, sizeof(*src));\n+\tfor (i = 0; /* NULL */; i++) {\n+\t\tmemcpy(&dst->args[i], &src->args[i], sizeof(src->args[i]));\n+\t\tif (src->args[i].name_long == NULL)\n+\t\t\tbreak;\n+\t}\n+}\n+\n+static struct rte_argparse *\n+test_argparse_init_obj(void)\n+{\n+\tstatic struct rte_argparse backup = argparse_templater();\n+\tstatic struct rte_argparse obj = argparse_templater();\n+\ttest_argparse_copy(&obj, &backup);\n+\treturn &obj;\n+}\n+\n+static int\n+test_argparse_invalid_basic_param(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->prog_name = NULL;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->usage = NULL;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+test_argparse_invalid_arg_name(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_long = \"-ab\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_long = \"-abc\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_long = \"---c\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_long = \"abc\";\n+\tobj->args[0].name_short = \"-a\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_short = \"a\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_short = \"abc\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_short = \"ab\";\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_argparse_invalid_arg_help(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].help = NULL;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_argparse_invalid_has_val(void)\n+{\n+\tuint32_t set_mask[] = { 0,\n+\t\t\t\tRTE_ARGPARSE_ARG_NO_VALUE,\n+\t\t\t\tRTE_ARGPARSE_ARG_OPTIONAL_VALUE\n+\t\t\t };\n+\tstruct rte_argparse *obj;\n+\tuint32_t index;\n+\tint ret;\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].flags &= ~0x3u;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tfor (index = 0; index < RTE_DIM(set_mask); index++) {\n+\t\tobj = test_argparse_init_obj();\n+\t\tobj->args[0].name_long = \"abc\";\n+\t\tobj->args[0].name_short = NULL;\n+\t\tobj->args[0].flags &= ~0x3u;\n+\t\tobj->args[0].flags |= set_mask[index];\n+\t\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\t\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_argparse_invalid_arg_saver(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\t/* test saver == NULL with val-type != 0. */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = NULL;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\t/* test saver == NULL with callback is NULL. */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = NULL;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE;\n+\tobj->callback = NULL;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\t/* test saver != NULL with val-type is zero! */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = (void *)1;\n+\tobj->args[0].val_set = (void *)1;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\t/* test saver != NULL with val-type is max. */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = (void *)1;\n+\tobj->args[0].val_set = (void *)1;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE | RTE_ARGPARSE_ARG_VALUE_MAX;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\t/* test saver != NULL with required value, but val-set is not NULL. */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = (void *)1;\n+\tobj->args[0].val_set = (void *)1;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_argparse_invalid_arg_flags(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].flags |= ~0x107FFu;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].name_long = \"positional\";\n+\tobj->args[0].name_short = NULL;\n+\tobj->args[0].val_saver = (void *)1;\n+\tobj->args[0].val_set = (void *)1;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT |\n+\t\t\t RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].flags |= RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\tobj = test_argparse_init_obj();\n+\tobj->args[0].val_saver = NULL;\n+\tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n+\tobj->callback = NULL;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_argparse_invalid_arg_repeat(void)\n+{\n+\tstruct rte_argparse *obj;\n+\tint ret;\n+\n+\t/* test for long name repeat! */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[1].name_long = obj->args[0].name_long;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\t/* test for short name repeat! */\n+\tobj = test_argparse_init_obj();\n+\tobj->args[1].name_short = obj->args[0].name_short;\n+\tret = rte_argparse_parse(obj, default_argc, default_argv);\n+\tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n+\n+\treturn 0;\n+}\n+\n+static struct unit_test_suite argparse_test_suite = {\n+\t.suite_name = \"Argparse Unit Test Suite\",\n+\t.setup = test_argparse_setup,\n+\t.teardown = test_argparse_teardown,\n+\t.unit_test_cases = {\n+\t\tTEST_CASE(test_argparse_invalid_basic_param),\n+\t\tTEST_CASE(test_argparse_invalid_arg_name),\n+\t\tTEST_CASE(test_argparse_invalid_arg_help),\n+\t\tTEST_CASE(test_argparse_invalid_has_val),\n+\t\tTEST_CASE(test_argparse_invalid_arg_saver),\n+\t\tTEST_CASE(test_argparse_invalid_arg_flags),\n+\t\tTEST_CASE(test_argparse_invalid_arg_repeat),\n+\n+\t\tTEST_CASES_END() /**< NULL terminate unit test array */\n+\t}\n+};\n+\n+static int\n+test_argparse(void)\n+{\n+\treturn unit_test_suite_runner(&argparse_test_suite);\n+}\n+\n+REGISTER_FAST_TEST(argparse_autotest, true, true, test_argparse);\n", "prefixes": [ "RFC", "v2", "3/6" ] }{ "id": 134783, "url": "