Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134715/?format=api
http://patches.dpdk.org/api/patches/134715/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-14-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231129173122.126895-14-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231129173122.126895-14-stephen@networkplumber.org", "date": "2023-11-29T17:26:07", "name": "[v5,13/19] net/bnx2x: remove reference to sanity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "053e11caf6f8282055a6080314243f958df2a1f5", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-14-stephen@networkplumber.org/mbox/", "series": [ { "id": 30417, "url": "http://patches.dpdk.org/api/series/30417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30417", "date": "2023-11-29T17:25:54", "name": "remove use of the term \"sanity check\"", "version": 5, "mbox": "http://patches.dpdk.org/series/30417/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134715/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96E9943403;\n\tWed, 29 Nov 2023 18:33:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9FB7242E75;\n\tWed, 29 Nov 2023 18:31:55 +0100 (CET)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id 153CC42E8A\n for <dev@dpdk.org>; Wed, 29 Nov 2023 18:31:50 +0100 (CET)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-6cbd24d9557so5121b3a.1\n for <dev@dpdk.org>; Wed, 29 Nov 2023 09:31:50 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Nov 2023 09:31:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279109;\n x=1701883909; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2BRWx5O95zlaiPh7i2kS5M8xLSk8a7cvqGAMKkSSxW4=;\n b=zPfZ+5vxnCgjyf1AwatdNZQLsxaDuwjBwI/9+cLKfQ5Z5q5F3ItmilC6dvETIdY1uf\n 5tSfhA7qPHw92DCM63dDyJHm56rC6u+QW2VTeuu+ZhCWozkMNQ4kJ6/A6cWXMlvXn3QA\n 3dEtrhL2PJulOTte+fkNlSWO+BUhzLbrKH1D1eV7wDP7rSwb0OLU9wlGqfUJiFs+Uo9O\n 1ycqyZz+SbsfbRvqsaDX8Hk+sSofJ0z2iLu0uiTJE+5VT1Mym+Wk/l+rKEsmfsqCmBkJ\n dkLo2pS94nlGWaAtAW2qB4sTYqZCKHWcxh7ylNYh++XNPrfTywRMCeFNUTsx8I1DJtvu\n Tw8g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701279109; x=1701883909;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2BRWx5O95zlaiPh7i2kS5M8xLSk8a7cvqGAMKkSSxW4=;\n b=DQV1/B9HTDOC8sexPKzZNJTkS0NQMvYuJ5q5AKd1A44OWd3bueqdRCMqeGq3bU/G8G\n PP9Z/bDaZKXrjOZHrT7G9Je2QLTI6KicyGH7sqd4XL7BnMOjZ7+6CwDgbhyuc8LnmC8P\n KWHEKY0eJmzfNNADfZgk3IKyN4ZSios5P52j+tPStmn/bWjKCY73V2+m42cG0EvyP7Gg\n tqoYRBhuM5S02EUhA9Ao1GUHBe26FYRcofutPKXxIjxbEhU315/Pb4BVVR66DCxGnVY5\n XgEiDAVNAl5KQOAlWPJoeQr1K8n12m23R4Ly6u0vXwShTRJd41yQroGPmYRV4lV/dpFw\n 8t9w==", "X-Gm-Message-State": "AOJu0YxpovFKjXRWGZhAv5VkTdPII2CDDv8AKNATRRP1Srjd9FHdzWmX\n BifUpdkVmT+HnBfQ7dQON3TSf8ARLYn+bVDAdlVUlw==", "X-Google-Smtp-Source": "\n AGHT+IG4hEvoDMqpN8WUP/DDK8/0OuyN6LrK5H0QE3n9cWrfodvvWH+bD2FnHum308nhZpuUHWpF/A==", "X-Received": "by 2002:a05:6a00:658a:b0:6cb:ba8d:96a7 with SMTP id\n hd10-20020a056a00658a00b006cbba8d96a7mr27442842pfb.14.1701279109005;\n Wed, 29 Nov 2023 09:31:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Julien Aube <julien_dpdk@jaube.fr>", "Subject": "[PATCH v5 13/19] net/bnx2x: remove reference to sanity", "Date": "Wed, 29 Nov 2023 09:26:07 -0800", "Message-ID": "<20231129173122.126895-14-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231129173122.126895-1-stephen@networkplumber.org>", "References": "<20230802232550.125487-1-stephen@networkplumber.org>\n <20231129173122.126895-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace \"sanity check\"\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnx2x/bnx2x.c | 2 +-\n drivers/net/bnx2x/bnx2x_stats.c | 8 ++++----\n drivers/net/bnx2x/ecore_sp.c | 2 +-\n drivers/net/bnx2x/elink.c | 4 ++--\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex c3283c94f38f..e345f293f25c 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -7820,7 +7820,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc)\n \tuint32_t ovlan2;\n \tuint8_t i, j;\n \n-\t/* various MF mode sanity checks... */\n+\t/* various MF mode checks... */\n \n \tif (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) {\n \t\tPMD_DRV_LOG(NOTICE, sc,\ndiff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c\nindex c07b01510a06..86d90679ac0a 100644\n--- a/drivers/net/bnx2x/bnx2x_stats.c\n+++ b/drivers/net/bnx2x/bnx2x_stats.c\n@@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc)\n \t\t */\n \t\treturn;\n \t}\n-\t/* sanity */\n+\t/* input valid? */\n \tif (!sc->port.pmf || !sc->port.port_stx) {\n \t\tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \t\treturn;\n@@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc)\n uint32_t mac_addr;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->link_vars.link_up || !sc->port.pmf) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\n@@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc)\n struct dmae_command *dmae = &sc->stats_dmae;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->func_stx) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\n@@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc)\n struct dmae_command *dmae;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->port.pmf || !sc->port.port_stx) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\ndiff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c\nindex c6c3857778f7..158205266f62 100644\n--- a/drivers/net/bnx2x/ecore_sp.c\n+++ b/drivers/net/bnx2x/ecore_sp.c\n@@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc,\n \t\t\tbreak;\n \t}\n \n-\t/* Sanity check */\n+\t/* Argument check */\n \tif (!cur_len)\n \t\treturn ECORE_SUCCESS;\n \ndiff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c\nindex 2c81f85b9605..6ebd47d927f8 100644\n--- a/drivers/net/bnx2x/elink.c\n+++ b/drivers/net/bnx2x/elink.c\n@@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin,\n {\n \tuint32_t epio_mask, gp_oenable;\n \t*en = 0;\n-\t/* Sanity check */\n+\t/* Input check */\n \tif (epio_pin > 31) {\n \t\tELINK_DEBUG_P1(sc, \"Invalid EPIO pin %d to get\", epio_pin);\n \t\treturn;\n@@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e\n {\n \tuint32_t epio_mask, gp_output, gp_oenable;\n \n-\t/* Sanity check */\n+\t/* Input check */\n \tif (epio_pin > 31) {\n \t\tELINK_DEBUG_P1(sc, \"Invalid EPIO pin %d to set\", epio_pin);\n \t\treturn;\n", "prefixes": [ "v5", "13/19" ] }{ "id": 134715, "url": "