Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134707/?format=api
{ "id": 134707, "url": "http://patches.dpdk.org/api/patches/134707/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231129173122.126895-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231129173122.126895-6-stephen@networkplumber.org", "date": "2023-11-29T17:25:59", "name": "[v5,05/19] lib: replace use of sanity check in comments and messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "36766cc93c3564faca827e629f1c6b1ba74937fa", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 30417, "url": "http://patches.dpdk.org/api/series/30417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30417", "date": "2023-11-29T17:25:54", "name": "remove use of the term \"sanity check\"", "version": 5, "mbox": "http://patches.dpdk.org/series/30417/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134707/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134707/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8CA3B43403;\n\tWed, 29 Nov 2023 18:32:17 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF24042E76;\n\tWed, 29 Nov 2023 18:31:44 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 1FC4E42E68\n for <dev@dpdk.org>; Wed, 29 Nov 2023 18:31:41 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6cde11fb647so236719b3a.1\n for <dev@dpdk.org>; Wed, 29 Nov 2023 09:31:41 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Nov 2023 09:31:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279100;\n x=1701883900; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/Lfvt3k3DtrG+364NbbTqMP3mwZnb3mqaculuXN6OnA=;\n b=qesf+9pKC6UFqCoi3psonF2qUwqv2J3JtnL9SrpzZtuft117qKHAqdScPr2tm0gXMB\n A4BvZqPNuO4TcVuWeU265eu5iQ+lNlLdVzlExsc/eTyvlGx8aUs9kyG6BDf5kRDkjn8o\n D6gZIWnU9g1qLL12c6q3wNANV25INbw91phCc/RAIKbQjtOUHqxpE4vFA08WOelOGFUI\n DFAi546gWiHhRx+otfscCHEYZkccDqDOzZ1ZIXMvMXhh6th/V+qUpbhQqxjO8k97R5Z0\n M+9GcJuLgWKKM4Uzljb8l8exYQebUnq8VE+UgEKdgtjwXPnt9X1KLzmgV0mlSn0ZoxFf\n X+TQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701279100; x=1701883900;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/Lfvt3k3DtrG+364NbbTqMP3mwZnb3mqaculuXN6OnA=;\n b=pvTANlYG7N9q57FJYaOZDCwF7ZOMFbdViPVYpgrZy9935ItR3iZCBcwOA2G7Vw0PHP\n Q4MYyaw+tsZi409fRM8ME2k+oDtF7wkTFd178ACXZbaQ6r8jTL4Mjk/hcGXDRrgxBGfa\n QDBNTPW3e1JKzfm8LBFTqxieSYV5BnNzUnkPaYsxZ64IrH6B2QSMmBjsjcTsWilb5CO6\n tS8VvFvnrW0tuEewqn1DR+6/TSsZ+Xk0RePVTLRPflCiwLLOEXeNqzYaFcFkwemjlwOw\n 5SYnuBkRE/75bAVy44459DxU5XFsATsFBoacVhVCRGr3bQ2xXfRclPhA2rs7JQ6cUGyQ\n dCOw==", "X-Gm-Message-State": "AOJu0Yz6zoEf+U9ZhwLLrsd5gs9JWSOjaqtdlHUpdLUM3OAv5XTD3kgB\n JSPcbChWotT8D8JQ7UnXVaNqDscQC/JCgFGgsTs=", "X-Google-Smtp-Source": "\n AGHT+IG7jGUbCz5lnNdlgvFKPFPWp8GrkjisvLe/l248z8B4uStgHayJBeDUhua3j2IJfuQ8r2OOCw==", "X-Received": "by 2002:a05:6a20:3941:b0:18d:d16:e86 with SMTP id\n r1-20020a056a20394100b0018d0d160e86mr2453928pzg.59.1701279100014;\n Wed, 29 Nov 2023 09:31:40 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Zhirun Yan <zhirun.yan@intel.com>, Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH v5 05/19] lib: replace use of sanity check in comments and\n messages", "Date": "Wed, 29 Nov 2023 09:25:59 -0800", "Message-ID": "<20231129173122.126895-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231129173122.126895-1-stephen@networkplumber.org>", "References": "<20230802232550.125487-1-stephen@networkplumber.org>\n <20231129173122.126895-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sanity check is on the Tier 2 non-inclusive list.\nReplace or remove it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/graph/graph.c | 2 +-\n lib/graph/graph_stats.c | 2 +-\n lib/graph/node.c | 2 +-\n lib/jobstats/rte_jobstats.c | 6 +++---\n lib/metrics/rte_metrics.c | 2 +-\n lib/pcapng/rte_pcapng.c | 2 +-\n 6 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/graph/graph.c b/lib/graph/graph.c\nindex 26f0968a978d..e51dcc30568e 100644\n--- a/lib/graph/graph.c\n+++ b/lib/graph/graph.c\n@@ -344,7 +344,7 @@ rte_graph_create(const char *name, struct rte_graph_param *prm)\n \n \tgraph_spinlock_lock();\n \n-\t/* Check arguments sanity */\n+\t/* Check argument validity */\n \tif (prm == NULL)\n \t\tSET_ERR_JMP(EINVAL, fail, \"Param should not be NULL\");\n \ndiff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c\nindex cc32245c0593..cfb30ae07497 100644\n--- a/lib/graph/graph_stats.c\n+++ b/lib/graph/graph_stats.c\n@@ -317,7 +317,7 @@ rte_graph_cluster_stats_create(const struct rte_graph_cluster_stats_param *prm)\n \tconst char *pattern;\n \trte_graph_t i;\n \n-\t/* Sanity checks */\n+\t/* Validate arguments */\n \tif (!rte_graph_has_stats_feature())\n \t\tSET_ERR_JMP(EINVAL, fail, \"Stats feature is not enabled\");\n \ndiff --git a/lib/graph/node.c b/lib/graph/node.c\nindex 99a962277964..c238d140ed31 100644\n--- a/lib/graph/node.c\n+++ b/lib/graph/node.c\n@@ -68,7 +68,7 @@ __rte_node_register(const struct rte_node_register *reg)\n \n \tgraph_spinlock_lock();\n \n-\t/* Check sanity */\n+\t/* Check argument validity */\n \tif (reg == NULL || reg->process == NULL) {\n \t\trte_errno = EINVAL;\n \t\tgoto fail;\ndiff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c\nindex af565a14eaf3..1c4b280c952a 100644\n--- a/lib/jobstats/rte_jobstats.c\n+++ b/lib/jobstats/rte_jobstats.c\n@@ -124,7 +124,7 @@ rte_jobstats_start(struct rte_jobstats_context *ctx, struct rte_jobstats *job)\n {\n \tuint64_t now;\n \n-\t/* Some sanity check. */\n+\t/* Check validity of arguments. */\n \tif (unlikely(ctx == NULL || job == NULL || job->context != NULL))\n \t\treturn -EINVAL;\n \n@@ -144,7 +144,7 @@ rte_jobstats_abort(struct rte_jobstats *job)\n \tstruct rte_jobstats_context *ctx;\n \tuint64_t now, exec_time;\n \n-\t/* Some sanity check. */\n+\t/* Check that arguments are valid */\n \tif (unlikely(job == NULL || job->context == NULL))\n \t\treturn -EINVAL;\n \n@@ -165,7 +165,7 @@ rte_jobstats_finish(struct rte_jobstats *job, int64_t job_value)\n \tuint64_t now, exec_time;\n \tint need_update;\n \n-\t/* Some sanity check. */\n+\t/* Check arguments */\n \tif (unlikely(job == NULL || job->context == NULL))\n \t\treturn -EINVAL;\n \ndiff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c\nindex 0ccdbabc04eb..f60d4f3f6e25 100644\n--- a/lib/metrics/rte_metrics.c\n+++ b/lib/metrics/rte_metrics.c\n@@ -120,7 +120,7 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)\n \tuint16_t idx_name;\n \tuint16_t idx_base;\n \n-\t/* Some sanity checks */\n+\t/* Some consistency checks */\n \tif (cnt_names < 1 || names == NULL)\n \t\treturn -EINVAL;\n \tfor (idx_name = 0; idx_name < cnt_names; idx_name++)\ndiff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c\nindex f74ec939a9f8..0de0a231693e 100644\n--- a/lib/pcapng/rte_pcapng.c\n+++ b/lib/pcapng/rte_pcapng.c\n@@ -619,7 +619,7 @@ rte_pcapng_write_packets(rte_pcapng_t *self,\n \t\tstruct pcapng_enhance_packet_block *epb;\n \t\tuint64_t cycles, timestamp;\n \n-\t\t/* sanity check that is really a pcapng mbuf */\n+\t\t/* Check that is really a pcapng mbuf */\n \t\tepb = rte_pktmbuf_mtod(m, struct pcapng_enhance_packet_block *);\n \t\tif (unlikely(epb->block_type != PCAPNG_ENHANCED_PACKET_BLOCK ||\n \t\t\t epb->block_length != rte_pktmbuf_data_len(m))) {\n", "prefixes": [ "v5", "05/19" ] }