Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134603/?format=api
{ "id": 134603, "url": "http://patches.dpdk.org/api/patches/134603/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231124070103.1778196-1-kaiwenx.deng@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231124070103.1778196-1-kaiwenx.deng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231124070103.1778196-1-kaiwenx.deng@intel.com", "date": "2023-11-24T07:01:03", "name": "net/i40e: remove redundant judgment in fdir parse", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4f984bc6e23518e7955b778b47499ce90c060048", "submitter": { "id": 2886, "url": "http://patches.dpdk.org/api/people/2886/?format=api", "name": "Kaiwen Deng", "email": "kaiwenx.deng@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231124070103.1778196-1-kaiwenx.deng@intel.com/mbox/", "series": [ { "id": 30384, "url": "http://patches.dpdk.org/api/series/30384/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30384", "date": "2023-11-24T07:01:03", "name": "net/i40e: remove redundant judgment in fdir parse", "version": 1, "mbox": "http://patches.dpdk.org/series/30384/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134603/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134603/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6096433B5;\n\tFri, 24 Nov 2023 08:43:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 002C542FFF;\n\tFri, 24 Nov 2023 08:43:48 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id C621142F31;\n Fri, 24 Nov 2023 08:43:46 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Nov 2023 23:43:45 -0800", "from shwdenpg561.ccr.corp.intel.com (HELO dpdk..) ([10.239.252.3])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Nov 2023 23:43:42 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1700811827; x=1732347827;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=Gh9l+oySqvSlXtuz8VQH/RoX4MvfxExwNWQZ4xmQQGg=;\n b=cnZcEQxk0aO5nHKpSoHM1DRTLbwTdrkNVMFst+0vIWaZx9T65xvvN+ML\n xrEeoWzaQX5EfRg+yNWPYpx9H7c3mi+xTTk4i+jEG97Z6XV1lGq8hD/6V\n SGp4ZekIFAQ/DuZVe7A21Mv+umRXR178xQ4XgGa5IVqfBFDQEu8nL7sFR\n wDMa+zOWMRBN6xtGEfnyEN+NP2ZQs7Oviv0sZzNg7NY5uVrdLwfcVpCX8\n YOHOTbgbSf+KmcHFdX5Slke4hlWrtMRTnOdgc5zHip/cCNA+K0ba5AEQj\n fStGM47VLZAI52woz3g5OvYBY/7vACQn/131gSG/kXUvl66NluzJjkDNg A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10902\"; a=\"458870561\"", "E=Sophos;i=\"6.04,223,1695711600\"; d=\"scan'208\";a=\"458870561\"", "E=McAfee;i=\"6600,9927,10902\"; a=\"760889629\"", "E=Sophos;i=\"6.04,223,1695711600\"; d=\"scan'208\";a=\"760889629\"" ], "X-ExtLoop1": "1", "From": "Kaiwen Deng <kaiwenx.deng@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,\n Kaiwen Deng <kaiwenx.deng@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>", "Subject": "[PATCH] net/i40e: remove redundant judgment in fdir parse", "Date": "Fri, 24 Nov 2023 15:01:03 +0800", "Message-Id": "<20231124070103.1778196-1-kaiwenx.deng@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "if (eth_spec && eth_mask &&\n\t next_type == RTE_FLOW_ITEM_TYPE_END) {\n ...\n if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {\n ...\n }\n...\n}\n\nClearly, that condition in the inner \"if\" is always \"false\".\n\nThis commit will remove the redundant judgment.\n\nFixes: 7d83c152a207 (\"net/i40e: parse flow director filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>\n---\n drivers/net/i40e/i40e_flow.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 877e49151e..92165c8422 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -1708,8 +1708,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,\n \n \t\t\t\tether_type = rte_be_to_cpu_16(eth_spec->hdr.ether_type);\n \n-\t\t\t\tif (next_type == RTE_FLOW_ITEM_TYPE_VLAN ||\n-\t\t\t\t ether_type == RTE_ETHER_TYPE_IPV4 ||\n+\t\t\t\tif (ether_type == RTE_ETHER_TYPE_IPV4 ||\n \t\t\t\t ether_type == RTE_ETHER_TYPE_IPV6 ||\n \t\t\t\t ether_type == i40e_get_outer_vlan(dev)) {\n \t\t\t\t\trte_flow_error_set(error, EINVAL,\n", "prefixes": [] }