Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134532/?format=api
{ "id": 134532, "url": "http://patches.dpdk.org/api/patches/134532/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231122163228.986037-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231122163228.986037-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231122163228.986037-1-bruce.richardson@intel.com", "date": "2023-11-22T16:32:28", "name": "eal/windows: fix mingw build", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "ddb2527477a6fd675aa849071fc20c7c267f3cbc", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231122163228.986037-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30358, "url": "http://patches.dpdk.org/api/series/30358/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30358", "date": "2023-11-22T16:32:28", "name": "eal/windows: fix mingw build", "version": 1, "mbox": "http://patches.dpdk.org/series/30358/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134532/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87B8043382;\n\tWed, 22 Nov 2023 17:32:41 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02BC24028C;\n\tWed, 22 Nov 2023 17:32:41 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id DDA0940265;\n Wed, 22 Nov 2023 17:32:39 +0100 (CET)", "from fmviesa001.fm.intel.com ([10.60.135.141])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Nov 2023 08:32:38 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.22])\n by fmviesa001.fm.intel.com with ESMTP; 22 Nov 2023 08:32:37 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1700670760; x=1732206760;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=D+LqBm3sqpHBotmiz6gTYbmxbDfp+acEa7LSdSHpn4g=;\n b=R+Z1n9ZM3vxLge9npKKxJ9JR8Dkwc2mOFLXX264MSY6kSR9jnLGfoMzo\n iXarr4/iCqqcR9yFGwoD1x4lcWsHrAD5A8rhWL/AElhESr2TcrNusNfG5\n QgnjlIiHCN4DuuXRb9aZsUfv7kji9+SmoGo5t82OEWn+mcXbfi+rNH5zU\n cFeqgpwq0cL6u2IdD7+Tcv4l/WmN9VdE6hJKs+SHjcVazI/vn9fQBWqtT\n XU7bTl1SreDKhqkV/miKcktrl5fxlf0AqtCPVpt480iXsLqCwkqFPDqj4\n d5ktEe1BORa1w7YIH4GhLbKdE5LXljTi7tH3ZDgdV3fsrWYpUn9zJU8gD A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10902\"; a=\"391861819\"", "E=Sophos;i=\"6.04,219,1695711600\"; d=\"scan'208\";a=\"391861819\"", "E=Sophos;i=\"6.04,219,1695711600\"; d=\"scan'208\";a=\"15317975\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Bruce Richardson <bruce.richardson@intel.com>, dmitry.kozliuk@gmail.com,\n stable@dpdk.org, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH] eal/windows: fix mingw build", "Date": "Wed, 22 Nov 2023 16:32:28 +0000", "Message-Id": "<20231122163228.986037-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When compiling with mingw on Ubuntu 23.10, I get the following compiler\nerror:\n\n../../lib/eal/windows/eal_memory.c:77: error: \"MEM_REPLACE_PLACEHOLDER\" redefined [-Werror]\n 77 | #define MEM_REPLACE_PLACEHOLDER 0x00004000\n |\nIn file included from /usr/share/mingw-w64/include/minwindef.h:163,\n from /usr/share/mingw-w64/include/windef.h:9,\n from /usr/share/mingw-w64/include/windows.h:69,\n from ../../lib/eal/windows/include/rte_windows.h:32,\n from ../../lib/eal/windows/include/rte_os_shim.h:9,\n from ../../lib/eal/common/eal_internal_cfg.h:14,\n from ../../lib/eal/windows/eal_memory.c:11:\n/usr/share/mingw-w64/include/winnt.h:5710: note: this is the location of the previous definition\n 5710 | #define MEM_REPLACE_PLACEHOLDER 0x4000\n\nand a similar error for MEM_RESERVE_PLACEHOLDER. These errors can be\nfixed by wrapping the two defines in #ifndef .. #endif blocks.\n\nFixes: 2a5d547a4a9b (\"eal/windows: implement basic memory management\")\nCc: dmitry.kozliuk@gmail.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eal/windows/eal_memory.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/lib/eal/windows/eal_memory.c b/lib/eal/windows/eal_memory.c\nindex 215d768e2c..64598745de 100644\n--- a/lib/eal/windows/eal_memory.c\n+++ b/lib/eal/windows/eal_memory.c\n@@ -74,8 +74,13 @@ static VirtualAlloc2_type VirtualAlloc2_ptr;\n \n #define MEM_COALESCE_PLACEHOLDERS 0x00000001\n #define MEM_PRESERVE_PLACEHOLDER 0x00000002\n+\n+#ifndef MEM_REPLACE_PLACEHOLDER\n #define MEM_REPLACE_PLACEHOLDER 0x00004000\n+#endif\n+#ifndef MEM_RESERVE_PLACEHOLDER\n #define MEM_RESERVE_PLACEHOLDER 0x00040000\n+#endif\n \n int\n eal_mem_win32api_init(void)\n", "prefixes": [] }