Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134496/?format=api
{ "id": 134496, "url": "http://patches.dpdk.org/api/patches/134496/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231120170942.197172-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231120170942.197172-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231120170942.197172-11-stephen@networkplumber.org", "date": "2023-11-20T17:07:05", "name": "[v4,10/10] common/dpaxx: remove zero length array", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8aa7bab76e7cfae60b86c32a1116fe78bb3c6eeb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231120170942.197172-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 30342, "url": "http://patches.dpdk.org/api/series/30342/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30342", "date": "2023-11-20T17:06:55", "name": "Replace zero length arrays", "version": 4, "mbox": "http://patches.dpdk.org/series/30342/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134496/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D17EB43381;\n\tMon, 20 Nov 2023 18:11:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8B04F42E6B;\n\tMon, 20 Nov 2023 18:10:08 +0100 (CET)", "from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170])\n by mails.dpdk.org (Postfix) with ESMTP id 4FAF242E4A\n for <dev@dpdk.org>; Mon, 20 Nov 2023 18:10:04 +0100 (CET)", "by mail-pf1-f170.google.com with SMTP id\n d2e1a72fcca58-6b87c1edfd5so3665129b3a.1\n for <dev@dpdk.org>; Mon, 20 Nov 2023 09:10:04 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n p18-20020a62ab12000000b006cb7f9da229sm2894681pff.202.2023.11.20.09.10.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 20 Nov 2023 09:10:02 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700500203;\n x=1701105003; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=T0fmocB3opu4AXHvVFYLFUGkMS73o4AE8HhZQ111gLM=;\n b=Ew2rz4mjBuGFUWM4YPWUPH7KUB9MO4JRdBs3fFYkYIpOfqIKterEFZXI625l6AWBV9\n KzOGl0/o16tf6eNK3ZM6V8Uo/xChYnfyyhrWkkxqXOTLgbok1RGb8tCw/exlkcsHz/Iu\n IykUI1dNhqaNUvAd+IxJSYqKEEvXcOMVWggGUkol48wJCzBBX95ZkmY9z7GOrB6MTLa+\n 9VGjsZxdq3C7jn9MPgpHg/TFVNBwe8ZZWWNYEKHdJw2i5IGAGajzZ17QR1/wmNkY9ol0\n A6c6poSpyn4bQ8sJtjo9hDgqRNv3kCOKS/PNs2rABhWANuE6ZalEAk3A6WuqVoeB0N8b\n s2uw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1700500203; x=1701105003;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=T0fmocB3opu4AXHvVFYLFUGkMS73o4AE8HhZQ111gLM=;\n b=IxcYxuZlndQE1ppJX/YcSASMc1iesRNhRgK0gNzsLyOeqyi2h4msqny3aMLawpWWNh\n 7GiA5I+AWpYbSd8LeDBWgi9oQlRjKNY+nrJDhY0jqQr8rXrrzKk8QDLicInxlU81vYqg\n ntFJR+UqjgGZ8Cye+rERQCj17qF00GfiEsDkE95uqWASpjtANx6s4KosruC6EBZipbYt\n 1dju858+OTKyn3ZQ6OYFD3ZDQNcshPam1Zm9k8MZuy5w4bstfY/y+sQw+OkyyKA/QHRL\n Z67xjacsmmd3PPPRLPoaIcjbOQpZSNs/jA/Nrubax9wJO62vpiEEbsg0iCdMtLqwPDPv\n N4XA==", "X-Gm-Message-State": "AOJu0Yy4zPE/rIw2BpwP6Ot4vLG6D3OdWrJ+0+Aox9YaNrAUeHmOg4ME\n IX+u04IZ6FBfBsfCSby6chEnMbVvTSvqhLLed6E=", "X-Google-Smtp-Source": "\n AGHT+IH73CwPTAnOgdeg/meZVTQiFoGgGBOGooYCtPhZZt6FEIb8q/6ZmC5U+MEwMBPz5tycSh0n4g==", "X-Received": "by 2002:a05:6a00:3a0d:b0:68e:2478:d6c9 with SMTP id\n fj13-20020a056a003a0d00b0068e2478d6c9mr6014854pfb.2.1700500202939;\n Mon, 20 Nov 2023 09:10:02 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>", "Subject": "[PATCH v4 10/10] common/dpaxx: remove zero length array", "Date": "Mon, 20 Nov 2023 09:07:05 -0800", "Message-ID": "<20231120170942.197172-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231120170942.197172-1-stephen@networkplumber.org>", "References": "<20230113215205.125767-1-stephen@networkplumber.org>\n <20231120170942.197172-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is a place holder zero length array in this driver.\nBut since the structure is embedded in other structures,\nit could not have been safely used anyway.\nThere doesn't appear to be any uses of it in the current code.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/dpaax/caamflib/desc/ipsec.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/dpaax/caamflib/desc/ipsec.h b/drivers/common/dpaax/caamflib/desc/ipsec.h\nindex 95fc3ea5ba3b..9d59b93292f9 100644\n--- a/drivers/common/dpaax/caamflib/desc/ipsec.h\n+++ b/drivers/common/dpaax/caamflib/desc/ipsec.h\n@@ -336,7 +336,6 @@ struct ipsec_encap_gcm {\n * @ip_hdr_len: optional IP Header length (in bytes)\n * reserved - 16b\n * Opt. IP Hdr Len - 16b\n- * @ip_hdr: optional IP Header content (only for IPsec legacy mode)\n */\n struct ipsec_encap_pdb {\n \tuint32_t options;\n@@ -350,7 +349,6 @@ struct ipsec_encap_pdb {\n \t};\n \tuint32_t spi;\n \tuint32_t ip_hdr_len;\n-\tuint8_t ip_hdr[0];\n };\n \n static inline unsigned int\n@@ -776,7 +774,7 @@ cnstr_shdsc_ipsec_encap(uint32_t *descbuf, bool ps, bool swap,\n \t\tPROGRAM_SET_36BIT_ADDR(p);\n \tphdr = SHR_HDR(p, share, hdr, 0);\n \t__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);\n-\tCOPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);\n+\n \tSET_LABEL(p, hdr);\n \tpkeyjmp = JUMP(p, keyjmp, LOCAL_JUMP, ALL_TRUE, BOTH|SHRD);\n \tif (authdata->keylen)\n@@ -913,7 +911,7 @@ cnstr_shdsc_ipsec_encap_des_aes_xcbc(uint32_t *descbuf,\n \tPROGRAM_CNTXT_INIT(p, descbuf, 0);\n \tphdr = SHR_HDR(p, share, hdr, 0);\n \t__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);\n-\tCOPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);\n+\n \tSET_LABEL(p, hdr);\n \tpkeyjump = JUMP(p, keyjump, LOCAL_JUMP, ALL_TRUE, SHRD | SELF);\n \t/*\n", "prefixes": [ "v4", "10/10" ] }