Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134464/?format=api
{ "id": 134464, "url": "http://patches.dpdk.org/api/patches/134464/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231117163729.243188-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231117163729.243188-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231117163729.243188-2-stephen@networkplumber.org", "date": "2023-11-17T16:35:55", "name": "[v7,1/5] pdump: fix setting rte_errno on mp error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b5ea89e3b2b36626c0df7fc57296227a0afac6a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231117163729.243188-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 30330, "url": "http://patches.dpdk.org/api/series/30330/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30330", "date": "2023-11-17T16:35:55", "name": "dumpcap and pcapng fixes", "version": 7, "mbox": "http://patches.dpdk.org/series/30330/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134464/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134464/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCDFF43355;\n\tFri, 17 Nov 2023 17:37:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E8C7402EA;\n\tFri, 17 Nov 2023 17:37:42 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 8ECC040285\n for <dev@dpdk.org>; Fri, 17 Nov 2023 17:37:41 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6c3363a2b93so2105867b3a.3\n for <dev@dpdk.org>; Fri, 17 Nov 2023 08:37:41 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n f22-20020a631016000000b005bd3f34b10dsm1595541pgl.24.2023.11.17.08.37.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Nov 2023 08:37:40 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700239060;\n x=1700843860; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=q3urgK3Pm25QrTpl2T7N34pdnrFPqlg7nm7VfucyFPo=;\n b=L573xhqcIxkgnmYy29F/VpseJNB+MG3WFp+4WKfM9Tga+NNaVJpqBtgITEVikoLd77\n 00bHoGiJ5U/uuuz8mU7DajrglrkKmATqMtZbTguZi8BnqIgS/aYx2ZWSKmvE+xXW3iDS\n IwV3naB4XSMTeDvBiJ5X8RryghmNGeHj7qFQxKjJAVbL95dZQBjkMeVFSLh+ANtoqSSS\n zwDOhKi9dC2nY32tmGiOKJPtADjolj/7e/Uq/ZTO9edDNEpN71EBccwSnzhAE4S6qYZW\n K2eKNqBd/+5Jc9uDgxrxmimij26qIvKzlORgO/mAEnVQ1E5/6nMDobwBTDcPE+qCfGyz\n 2edQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1700239060; x=1700843860;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=q3urgK3Pm25QrTpl2T7N34pdnrFPqlg7nm7VfucyFPo=;\n b=O0KiFzgB0/BkpXcitZUzuXkFaJMKksmGxqXLERIXBfpQlTMtUOatOs63718+K0nPnw\n K9TnF9snzAMIgB1VxrpFH97wsg40pmrv/YbkLFhIDJcBQ2Ea1//xYMZxbD6aD/jeHVPK\n nPNqkvnIhNTk/3KbeSvMBaM4Us3+eh4G90drUMIcgmUEsAyhhlb/cDgszsywtZWibdh6\n aUbmRoFJ3hUNzUoXB+MDRf/oZXlouWsFSUF8mXYVGcXOoWUMsJXmQCcijxD8/CayWdFM\n yqvegvvq8jKJJ7rhas8xpUxKWjtBHjKtDvXSAOiXVkZRL86th0S+F1X1eVd9POgboJWm\n a8ag==", "X-Gm-Message-State": "AOJu0YyyVGmZy6QmsdZ7dLLaXzVMlk/erkjtXQfElaapPNL8scM4/8tc\n UwMSDn+Z/zCWKKvt0Ury8laPu9iWWEHPCn5x3IRdgw==", "X-Google-Smtp-Source": "\n AGHT+IFLu0R7VCkq9ghQTK3vvJQmA8197ZC05JeudC6jyNA+Pn+RCWdf2twRf8wkb6qD83uV/fVwCA==", "X-Received": "by 2002:a05:6a20:7293:b0:186:a0d9:4189 with SMTP id\n o19-20020a056a20729300b00186a0d94189mr17073342pzk.35.1700239060403;\n Fri, 17 Nov 2023 08:37:40 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Jianfeng Tan <jianfeng.tan@intel.com>", "Subject": "[PATCH v7 1/5] pdump: fix setting rte_errno on mp error", "Date": "Fri, 17 Nov 2023 08:35:55 -0800", "Message-ID": "<20231117163729.243188-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231117163729.243188-1-stephen@networkplumber.org>", "References": "<20230921042349.104150-1-stephen@networkplumber.org>\n <20231117163729.243188-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The response from MP server sets err_value to negative\non error. The convention for rte_errno is to use a positive\nvalue on error. This makes errors like duplicate registration\nshow up with the correct error value.\n\nFixes: 660098d61f57 (\"pdump: use generic multi-process channel\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/pdump/rte_pdump.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c\nindex 80b90c6f7d03..e94f49e21250 100644\n--- a/lib/pdump/rte_pdump.c\n+++ b/lib/pdump/rte_pdump.c\n@@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue,\n \tif (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) {\n \t\tmp_rep = &mp_reply.msgs[0];\n \t\tresp = (struct pdump_response *)mp_rep->param;\n-\t\trte_errno = resp->err_value;\n-\t\tif (!resp->err_value)\n+\t\tif (resp->err_value == 0)\n \t\t\tret = 0;\n+\t\telse\n+\t\t\trte_errno = -resp->err_value;\n \t\tfree(mp_reply.msgs);\n \t}\n \n", "prefixes": [ "v7", "1/5" ] }