Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134405/?format=api
{ "id": 134405, "url": "http://patches.dpdk.org/api/patches/134405/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1700089378-26197-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1700089378-26197-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1700089378-26197-2-git-send-email-roretzla@linux.microsoft.com", "date": "2023-11-15T23:02:55", "name": "[1/4] lib: add extension keyword to statement expressions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c9f01fb5d87f012d402677f0bcfebbce08f98f88", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1700089378-26197-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 30308, "url": "http://patches.dpdk.org/api/series/30308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30308", "date": "2023-11-15T23:02:54", "name": "add __extension__ keyword to statement expressions", "version": 1, "mbox": "http://patches.dpdk.org/series/30308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134405/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134405/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A3B04333B;\n\tThu, 16 Nov 2023 00:03:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9792440A7D;\n\tThu, 16 Nov 2023 00:03:02 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 3C85E4025F\n for <dev@dpdk.org>; Thu, 16 Nov 2023 00:03:00 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 41C5B20B74C2; Wed, 15 Nov 2023 15:02:59 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 41C5B20B74C2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1700089379;\n bh=4IB/nLpismkTxokl5YkJWM3fX0K9eVmwCsPTYZdRdDs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PYsVXrRf7ZRMZyl7L01AQS57RgCg82wyVpjUripC5xtLXPdZ97SLRaVcl9H0NDF4Z\n 2O4c+p5TxWe7AFev3NwpOuEMMoJQWyTxuGukDa5YqQ5ppJFEWLYSBfaoT6gO9xPpEk\n woYiZ84bP7aLvNmEP09PliKTpLCifjwSNIz/gSBg=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Aman Singh <aman.deep.singh@intel.com>,\n Amit Bernstein <amitbern@amazon.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Apeksha Gupta <apeksha.gupta@nxp.com>, Beilei Xing <beilei.xing@intel.com>,\n Brian Dooley <brian.dooley@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Evgeny Schemeilin <evgenys@amazon.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Gagandeep Singh <g.singh@nxp.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,\n Harman Kalra <hkalra@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,\n Jerin Jacob <jerinj@marvell.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Kai Ji <kai.ji@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Maciej Czekaj <mczekaj@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Qi Zhang <qi.z.zhang@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Rakesh Kudurumalla <rkudurumalla@marvell.com>,\n Ron Beider <rbeider@amazon.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Sachin Saxena <sachin.saxena@nxp.com>,\n Satha Rao <skoteshwar@marvell.com>, Shai Brandes <shaibran@amazon.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tianfei Zhang <tianfei.zhang@intel.com>,\n Wajeeh Atrash <atrwajee@amazon.com>, Xiao Wang <xiao.w.wang@intel.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 1/4] lib: add extension keyword to statement expressions", "Date": "Wed, 15 Nov 2023 15:02:55 -0800", "Message-Id": "<1700089378-26197-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1700089378-26197-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1700089378-26197-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add __extension__ keyword to gcc statement expression extensions.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/ethdev/rte_mtr.c | 10 +++++-----\n lib/ethdev/rte_tm.c | 6 +++---\n lib/pipeline/rte_pipeline.c | 8 ++++----\n lib/pipeline/rte_swx_pipeline_internal.h | 2 +-\n lib/port/rte_port_source_sink.c | 4 ++--\n 5 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_mtr.c b/lib/ethdev/rte_mtr.c\nindex 4e94af9..900837b 100644\n--- a/lib/ethdev/rte_mtr.c\n+++ b/lib/ethdev/rte_mtr.c\n@@ -41,14 +41,14 @@\n }\n \n #define RTE_MTR_FUNC(port_id, func)\t\t\t\\\n-({\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\\\n \tconst struct rte_mtr_ops *ops =\t\t\t\\\n-\t\trte_mtr_ops_get(port_id, error);\t\t\\\n-\tif (ops == NULL)\t\t\t\t\t\\\n+\t\trte_mtr_ops_get(port_id, error);\t\\\n+\tif (ops == NULL)\t\t\t\t\\\n \t\treturn -rte_errno;\t\t\t\\\n \t\t\t\t\t\t\t\\\n \tif (ops->func == NULL)\t\t\t\t\\\n-\t\treturn -rte_mtr_error_set(error,\t\t\\\n+\t\treturn -rte_mtr_error_set(error,\t\\\n \t\t\tENOSYS,\t\t\t\t\\\n \t\t\tRTE_MTR_ERROR_TYPE_UNSPECIFIED,\t\\\n \t\t\tNULL,\t\t\t\t\\\n@@ -58,7 +58,7 @@\n })\n \n #define RTE_MTR_HNDL_FUNC(port_id, func)\t\t\\\n-({\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\\\n \tconst struct rte_mtr_ops *ops =\t\t\t\\\n \t\trte_mtr_ops_get(port_id, error);\t\\\n \tif (ops == NULL)\t\t\t\t\\\ndiff --git a/lib/ethdev/rte_tm.c b/lib/ethdev/rte_tm.c\nindex 2d08141..d594fe0 100644\n--- a/lib/ethdev/rte_tm.c\n+++ b/lib/ethdev/rte_tm.c\n@@ -40,11 +40,11 @@\n \treturn ops;\n }\n \n-#define RTE_TM_FUNC(port_id, func)\t\t\t\t\\\n-({\t\t\t\t\t\t\t\\\n+#define RTE_TM_FUNC(port_id, func)\t\t\t\\\n+__extension__ ({\t\t\t\t\t\\\n \tconst struct rte_tm_ops *ops =\t\t\t\\\n \t\trte_tm_ops_get(port_id, error);\t\t\\\n-\tif (ops == NULL)\t\t\t\t\t\\\n+\tif (ops == NULL)\t\t\t\t\\\n \t\treturn -rte_errno;\t\t\t\\\n \t\t\t\t\t\t\t\\\n \tif (ops->func == NULL)\t\t\t\t\\\ndiff --git a/lib/pipeline/rte_pipeline.c b/lib/pipeline/rte_pipeline.c\nindex 436cf54..e5cab00 100644\n--- a/lib/pipeline/rte_pipeline.c\n+++ b/lib/pipeline/rte_pipeline.c\n@@ -17,16 +17,16 @@\n #ifdef RTE_PIPELINE_STATS_COLLECT\n \n #define RTE_PIPELINE_STATS_AH_DROP_WRITE(p, mask)\t\t\t\\\n-\t({ (p)->n_pkts_ah_drop = rte_popcount64(mask); })\n+\t__extension__ ({ (p)->n_pkts_ah_drop = rte_popcount64(mask); })\n \n #define RTE_PIPELINE_STATS_AH_DROP_READ(p, counter)\t\t\t\\\n-\t({ (counter) += (p)->n_pkts_ah_drop; (p)->n_pkts_ah_drop = 0; })\n+\t__extension__ ({ (counter) += (p)->n_pkts_ah_drop; (p)->n_pkts_ah_drop = 0; })\n \n #define RTE_PIPELINE_STATS_TABLE_DROP0(p)\t\t\t\t\\\n-\t({ (p)->pkts_drop_mask = (p)->action_mask0[RTE_PIPELINE_ACTION_DROP]; })\n+\t__extension__ ({ (p)->pkts_drop_mask = (p)->action_mask0[RTE_PIPELINE_ACTION_DROP]; })\n \n #define RTE_PIPELINE_STATS_TABLE_DROP1(p, counter)\t\t\t\\\n-({\t\t\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\t\t\\\n \tuint64_t mask = (p)->action_mask0[RTE_PIPELINE_ACTION_DROP];\t\\\n \tmask ^= (p)->pkts_drop_mask;\t\t\t\t\t\\\n \t(counter) += rte_popcount64(mask);\t\t\t\\\ndiff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_internal.h\nindex a67b6e9..beb2011 100644\n--- a/lib/pipeline/rte_swx_pipeline_internal.h\n+++ b/lib/pipeline/rte_swx_pipeline_internal.h\n@@ -1485,7 +1485,7 @@ struct thread {\n #endif\n \n #define METADATA_READ(thread, offset, n_bits) \\\n-({ \\\n+__extension__ ({ \\\n \tuint64_t *m64_ptr = (uint64_t *)&(thread)->metadata[offset]; \\\n \tuint64_t m64 = *m64_ptr; \\\n \tuint64_t m64_mask = UINT64_MAX >> (64 - (n_bits)); \\\ndiff --git a/lib/port/rte_port_source_sink.c b/lib/port/rte_port_source_sink.c\nindex ff9677c..7b5fcb4 100644\n--- a/lib/port/rte_port_source_sink.c\n+++ b/lib/port/rte_port_source_sink.c\n@@ -176,7 +176,7 @@ struct rte_port_source {\n #else /* RTE_PORT_PCAP */\n \n #define PCAP_SOURCE_LOAD(port, file_name, n_bytes, socket_id)\t\\\n-({\t\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\t\\\n \tint _ret = 0;\t\t\t\t\t\t\\\n \t\t\t\t\t\t\t\t\\\n \tif (file_name) {\t\t\t\t\t\\\n@@ -429,7 +429,7 @@ struct rte_port_sink {\n #else\n \n #define PCAP_SINK_OPEN(port, file_name, max_n_pkts)\t\t\\\n-({\t\t\t\t\t\t\t\t\\\n+__extension__ ({\t\t\t\t\t\t\\\n \tint _ret = 0;\t\t\t\t\t\t\\\n \t\t\t\t\t\t\t\t\\\n \tif (file_name) {\t\t\t\t\t\\\n", "prefixes": [ "1/4" ] }