Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134308/?format=api
http://patches.dpdk.org/api/patches/134308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-33-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114112407.3496460-33-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114112407.3496460-33-huangdengdui@huawei.com", "date": "2023-11-14T11:23:56", "name": "[v2,32/43] net/memif: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "73bba0d3a38ac129223dabfdc9aa4581720b2316", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-33-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30292, "url": "http://patches.dpdk.org/api/series/30292/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30292", "date": "2023-11-14T11:23:25", "name": "replace strerror", "version": 2, "mbox": "http://patches.dpdk.org/series/30292/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134308/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134308/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E105A43329;\n\tTue, 14 Nov 2023 12:27:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5E20541104;\n\tTue, 14 Nov 2023 12:24:45 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 8DB77402E6\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:24:13 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV3pH2ld5zWhG9;\n Tue, 14 Nov 2023 19:23:51 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 19:24:12 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH v2 32/43] net/memif: use rte strerror", "Date": "Tue, 14 Nov 2023 19:23:56 +0800", "Message-ID": "<20231114112407.3496460-33-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114112407.3496460-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114112407.3496460-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/memif/memif_socket.c | 4 ++--\n drivers/net/memif/rte_eth_memif.c | 20 ++++++++++----------\n 2 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c\nindex 649f8d0e61..592b71979a 100644\n--- a/drivers/net/memif/memif_socket.c\n+++ b/drivers/net/memif/memif_socket.c\n@@ -71,7 +71,7 @@ memif_msg_send_from_queue(struct memif_control_channel *cc)\n \tsize = memif_msg_send(rte_intr_fd_get(cc->intr_handle), &e->msg,\n \t\t\t e->fd);\n \tif (size != sizeof(memif_msg_t)) {\n-\t\tMIF_LOG(ERR, \"sendmsg fail: %s.\", strerror(errno));\n+\t\tMIF_LOG(ERR, \"sendmsg fail: %s.\", rte_strerror(errno));\n \t\tret = -1;\n \t} else {\n \t\tMIF_LOG(DEBUG, \"Sent msg type %u.\", e->msg.type);\n@@ -975,7 +975,7 @@ memif_socket_create(char *key, uint8_t listener, bool is_abstract, uid_t owner_u\n \treturn sock;\n \n error:\n-\tMIF_LOG(ERR, \"Failed to setup socket %s: %s\", key, strerror(errno));\n+\tMIF_LOG(ERR, \"Failed to setup socket %s: %s\", key, rte_strerror(errno));\n \tif (sock != NULL) {\n \t\trte_intr_instance_free(sock->intr_handle);\n \t\trte_free(sock);\ndiff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex 7cc8c0da91..f7697394f1 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -805,7 +805,7 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t sizeof(a));\n \t\tif (unlikely(size < 0)) {\n \t\t\tMIF_LOG(WARNING,\n-\t\t\t\t\"Failed to send interrupt. %s\", strerror(errno));\n+\t\t\t\t\"Failed to send interrupt. %s\", rte_strerror(errno));\n \t\t}\n \t}\n \n@@ -960,7 +960,7 @@ eth_memif_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t\t &a, sizeof(a));\n \t\tif (unlikely(size < 0)) {\n \t\t\tMIF_LOG(WARNING,\n-\t\t\t\t\"Failed to send interrupt. %s\", strerror(errno));\n+\t\t\t\t\"Failed to send interrupt. %s\", rte_strerror(errno));\n \t\t}\n \t}\n \n@@ -1082,27 +1082,27 @@ memif_region_init_shm(struct rte_eth_dev *dev, uint8_t has_buffers)\n \n \tr->fd = memfd_create(shm_name, MFD_ALLOW_SEALING);\n \tif (r->fd < 0) {\n-\t\tMIF_LOG(ERR, \"Failed to create shm file: %s.\", strerror(errno));\n+\t\tMIF_LOG(ERR, \"Failed to create shm file: %s.\", rte_strerror(errno));\n \t\tret = -1;\n \t\tgoto error;\n \t}\n \n \tret = fcntl(r->fd, F_ADD_SEALS, F_SEAL_SHRINK);\n \tif (ret < 0) {\n-\t\tMIF_LOG(ERR, \"Failed to add seals to shm file: %s.\", strerror(errno));\n+\t\tMIF_LOG(ERR, \"Failed to add seals to shm file: %s.\", rte_strerror(errno));\n \t\tgoto error;\n \t}\n \n \tret = ftruncate(r->fd, r->region_size);\n \tif (ret < 0) {\n-\t\tMIF_LOG(ERR, \"Failed to truncate shm file: %s.\", strerror(errno));\n+\t\tMIF_LOG(ERR, \"Failed to truncate shm file: %s.\", rte_strerror(errno));\n \t\tgoto error;\n \t}\n \n \tr->addr = mmap(NULL, r->region_size, PROT_READ |\n \t\t PROT_WRITE, MAP_SHARED, r->fd, 0);\n \tif (r->addr == MAP_FAILED) {\n-\t\tMIF_LOG(ERR, \"Failed to mmap shm region: %s.\", strerror(ret));\n+\t\tMIF_LOG(ERR, \"Failed to mmap shm region: %s.\", rte_strerror(ret));\n \t\tret = -1;\n \t\tgoto error;\n \t}\n@@ -1223,7 +1223,7 @@ memif_init_queues(struct rte_eth_dev *dev)\n \t\tif (rte_intr_fd_get(mq->intr_handle) < 0) {\n \t\t\tMIF_LOG(WARNING,\n \t\t\t\t\"Failed to create eventfd for tx queue %d: %s.\", i,\n-\t\t\t\tstrerror(errno));\n+\t\t\t\trte_strerror(errno));\n \t\t}\n \t\tmq->buffers = NULL;\n \t\tif (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY) {\n@@ -1247,7 +1247,7 @@ memif_init_queues(struct rte_eth_dev *dev)\n \t\tif (rte_intr_fd_get(mq->intr_handle) < 0) {\n \t\t\tMIF_LOG(WARNING,\n \t\t\t\t\"Failed to create eventfd for rx queue %d: %s.\", i,\n-\t\t\t\tstrerror(errno));\n+\t\t\t\trte_strerror(errno));\n \t\t}\n \t\tmq->buffers = NULL;\n \t\tif (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY) {\n@@ -1299,7 +1299,7 @@ memif_connect(struct rte_eth_dev *dev)\n \t\t\t\t\t\tMAP_SHARED, mr->fd, 0);\n \t\t\t\tif (mr->addr == MAP_FAILED) {\n \t\t\t\t\tMIF_LOG(ERR, \"mmap failed: %s\\n\",\n-\t\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\t\trte_strerror(errno));\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t}\n@@ -1983,7 +1983,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)\n \t */\n \tif (ret < 0 && rte_errno != EEXIST)\n \t\tMIF_LOG(WARNING, \"Failed to register mp action callback: %s\",\n-\t\t\tstrerror(rte_errno));\n+\t\t\trte_strerror(rte_errno));\n \n \t/* use abstract address by default */\n \tflags |= ETH_MEMIF_FLAG_SOCKET_ABSTRACT;\n", "prefixes": [ "v2", "32/43" ] }{ "id": 134308, "url": "