Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134295/?format=api
http://patches.dpdk.org/api/patches/134295/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-14-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114112407.3496460-14-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114112407.3496460-14-huangdengdui@huawei.com", "date": "2023-11-14T11:23:37", "name": "[v2,13/43] bus/fslmc: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6049f7356c17bd51a177108a17d979d76ff753b6", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-14-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30292, "url": "http://patches.dpdk.org/api/series/30292/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30292", "date": "2023-11-14T11:23:25", "name": "replace strerror", "version": 2, "mbox": "http://patches.dpdk.org/series/30292/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134295/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7371143329;\n\tTue, 14 Nov 2023 12:25:52 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4C48440DF5;\n\tTue, 14 Nov 2023 12:24:30 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id CA201402E4\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:24:11 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV3kp6CcPzmXFD;\n Tue, 14 Nov 2023 19:20:50 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 19:24:09 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH v2 13/43] bus/fslmc: use rte strerror", "Date": "Tue, 14 Nov 2023 19:23:37 +0800", "Message-ID": "<20231114112407.3496460-14-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114112407.3496460-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114112407.3496460-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/bus/fslmc/fslmc_vfio.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex 5966776a85..1cbbcf9019 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -481,7 +481,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \tif (ret) {\n \t\tDPAA2_BUS_ERR(\" %s cannot get group status, \"\n \t\t\t\t\"error %i (%s)\\n\", dev_addr,\n-\t\t\t\terrno, strerror(errno));\n+\t\t\t\terrno, rte_strerror(errno));\n \t\tclose(vfio_group_fd);\n \t\trte_vfio_clear_group(vfio_group_fd);\n \t\treturn -1;\n@@ -504,7 +504,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \t\tif (ret) {\n \t\t\tDPAA2_BUS_ERR(\" %s cannot add VFIO group to container, \"\n \t\t\t\t\t\"error %i (%s)\\n\", dev_addr,\n-\t\t\t\t\terrno, strerror(errno));\n+\t\t\t\t\terrno, rte_strerror(errno));\n \t\t\tclose(vfio_group_fd);\n \t\t\tclose(vfio_container_fd);\n \t\t\trte_vfio_clear_group(vfio_group_fd);\n@@ -551,7 +551,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char *dev_addr,\n \tret = ioctl(*vfio_dev_fd, VFIO_DEVICE_GET_INFO, device_info);\n \tif (ret) {\n \t\tDPAA2_BUS_ERR(\" %s cannot get device info, error %i (%s)\",\n-\t\t\t\tdev_addr, errno, strerror(errno));\n+\t\t\t\tdev_addr, errno, rte_strerror(errno));\n \t\tclose(*vfio_dev_fd);\n \t\tclose(vfio_group_fd);\n \t\tclose(vfio_container_fd);\n@@ -617,7 +617,7 @@ int rte_dpaa2_intr_enable(struct rte_intr_handle *intr_handle, int index)\n \tif (ret) {\n \t\tDPAA2_BUS_ERR(\"Error:dpaa2 SET IRQs fd=%d, err = %d(%s)\",\n \t\t\t rte_intr_fd_get(intr_handle), errno,\n-\t\t\t strerror(errno));\n+\t\t\t rte_strerror(errno));\n \t\treturn ret;\n \t}\n \n@@ -667,7 +667,7 @@ rte_dpaa2_vfio_setup_intr(struct rte_intr_handle *intr_handle,\n \t\tret = ioctl(vfio_dev_fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info);\n \t\tif (ret < 0) {\n \t\t\tDPAA2_BUS_ERR(\"Cannot get IRQ(%d) info, error %i (%s)\",\n-\t\t\t\t i, errno, strerror(errno));\n+\t\t\t\t i, errno, rte_strerror(errno));\n \t\t\treturn -1;\n \t\t}\n \n@@ -682,7 +682,7 @@ rte_dpaa2_vfio_setup_intr(struct rte_intr_handle *intr_handle,\n \t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n \t\tif (fd < 0) {\n \t\t\tDPAA2_BUS_ERR(\"Cannot set up eventfd, error %i (%s)\",\n-\t\t\t\t errno, strerror(errno));\n+\t\t\t\t errno, rte_strerror(errno));\n \t\t\treturn -1;\n \t\t}\n \n", "prefixes": [ "v2", "13/43" ] }{ "id": 134295, "url": "