Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134271/?format=api
{ "id": 134271, "url": "http://patches.dpdk.org/api/patches/134271/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-15-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114110006.91148-15-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-15-haijie1@huawei.com", "date": "2023-11-14T10:59:58", "name": "[v3,14/22] telemetry: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1a7d979ab6be93f6a27d23737a464b83c4fcbd70", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-15-haijie1@huawei.com/mbox/", "series": [ { "id": 30291, "url": "http://patches.dpdk.org/api/series/30291/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30291", "date": "2023-11-14T10:59:44", "name": "replace strtok with reentrant version", "version": 3, "mbox": "http://patches.dpdk.org/series/30291/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134271/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2FAB443329;\n\tTue, 14 Nov 2023 12:11:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 688A840DFB;\n\tTue, 14 Nov 2023 12:10:14 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 20E81402F2\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:10:00 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV3Tz3d6BzvQWY\n for <dev@dpdk.org>; Tue, 14 Nov 2023 19:09:43 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:09:58 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Ciara Power <ciara.power@intel.com>, Bruce Richardson\n <bruce.richardson@intel.com>, Keith Wiles <keith.wiles@intel.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v3 14/22] telemetry: replace strtok with reentrant version", "Date": "Tue, 14 Nov 2023 18:59:58 +0800", "Message-ID": "<20231114110006.91148-15-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: 6dd571fd07c3 (\"telemetry: introduce new functionality\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/telemetry/telemetry.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 92982842a860..bb028d9381f7 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -371,6 +371,7 @@ static void *\n client_handler(void *sock_id)\n {\n \tint s = (int)(uintptr_t)sock_id;\n+\tchar *sp = NULL;\n \tchar buffer[1024];\n \tchar info_str[1024];\n \tsnprintf(info_str, sizeof(info_str),\n@@ -385,8 +386,8 @@ client_handler(void *sock_id)\n \tint bytes = read(s, buffer, sizeof(buffer) - 1);\n \twhile (bytes > 0) {\n \t\tbuffer[bytes] = 0;\n-\t\tconst char *cmd = strtok(buffer, \",\");\n-\t\tconst char *param = strtok(NULL, \"\\0\");\n+\t\tconst char *cmd = strtok_r(buffer, \",\", &sp);\n+\t\tconst char *param = strtok_r(NULL, \"\\0\", &sp);\n \t\ttelemetry_cb fn = unknown_command;\n \t\tint i;\n \n", "prefixes": [ "v3", "14/22" ] }