Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134269/?format=api
{ "id": 134269, "url": "http://patches.dpdk.org/api/patches/134269/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-14-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114110006.91148-14-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-14-haijie1@huawei.com", "date": "2023-11-14T10:59:57", "name": "[v3,13/22] security: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b46906ea1ec01e0db6e8f7a6cf27cf9aabcef77d", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-14-haijie1@huawei.com/mbox/", "series": [ { "id": 30291, "url": "http://patches.dpdk.org/api/series/30291/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30291", "date": "2023-11-14T10:59:44", "name": "replace strtok with reentrant version", "version": 3, "mbox": "http://patches.dpdk.org/series/30291/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134269/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 768D543329;\n\tTue, 14 Nov 2023 12:11:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1243A40DCA;\n\tTue, 14 Nov 2023 12:10:12 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id E1EE8402F1\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:09:59 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV3Tr6rW6zWhG5;\n Tue, 14 Nov 2023 19:09:36 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:09:58 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>, Gowrishankar\n Muthukrishnan <gmuthukrishn@marvell.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v3 13/22] security: replace strtok with reentrant version", "Date": "Tue, 14 Nov 2023 18:59:57 +0800", "Message-ID": "<20231114110006.91148-14-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: 259ca6d1617f (\"security: add telemetry endpoint for capabilities\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/security/rte_security.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c\nindex b082a290296b..e20d610172ef 100644\n--- a/lib/security/rte_security.c\n+++ b/lib/security/rte_security.c\n@@ -496,13 +496,14 @@ security_handle_cryptodev_crypto_caps(const char *cmd __rte_unused, const char *\n \tint dev_id, capa_id;\n \tint crypto_caps_n;\n \tchar *end_param;\n+\tchar *sp = NULL;\n \tint rc;\n \n \tif (!params || strlen(params) == 0 || !isdigit(*params))\n \t\treturn -EINVAL;\n \n \tdev_id = strtoul(params, &end_param, 0);\n-\tcapa_param = strtok(end_param, \",\");\n+\tcapa_param = strtok_r(end_param, \",\", &sp);\n \tif (!capa_param || strlen(capa_param) == 0 || !isdigit(*capa_param))\n \t\treturn -EINVAL;\n \n", "prefixes": [ "v3", "13/22" ] }