Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134268/?format=api
{ "id": 134268, "url": "http://patches.dpdk.org/api/patches/134268/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-12-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114110006.91148-12-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-12-haijie1@huawei.com", "date": "2023-11-14T10:59:55", "name": "[v3,11/22] ethdev: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3c62d62d37296374d3d6e5afdde3c6967308b477", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-12-haijie1@huawei.com/mbox/", "series": [ { "id": 30291, "url": "http://patches.dpdk.org/api/series/30291/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30291", "date": "2023-11-14T10:59:44", "name": "replace strtok with reentrant version", "version": 3, "mbox": "http://patches.dpdk.org/series/30291/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134268/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2F6943329;\n\tTue, 14 Nov 2023 12:11:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E90E5406B8;\n\tTue, 14 Nov 2023 12:10:10 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id C8B4B402E6\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:09:58 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV3QQ2v2PzmXBn;\n Tue, 14 Nov 2023 19:06:38 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:09:57 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v3 11/22] ethdev: replace strtok with reentrant version", "Date": "Tue, 14 Nov 2023 18:59:55 +0800", "Message-ID": "<20231114110006.91148-12-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: f38f62650f7b (\"ethdev: add Rx queue telemetry query\")\nFixes: 9e7533aeb80a (\"ethdev: add telemetry command for TM level capabilities\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/ethdev/rte_ethdev_telemetry.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c\nindex b01028ce9b60..6810c54109a5 100644\n--- a/lib/ethdev/rte_ethdev_telemetry.c\n+++ b/lib/ethdev/rte_ethdev_telemetry.c\n@@ -477,6 +477,7 @@ ethdev_parse_queue_params(const char *params, bool is_rx,\n \tconst char *qid_param;\n \tuint16_t nb_queues;\n \tchar *end_param;\n+\tchar *sp = NULL;\n \tuint64_t qid;\n \tint ret;\n \n@@ -489,7 +490,7 @@ ethdev_parse_queue_params(const char *params, bool is_rx,\n \tif (nb_queues == 1 && *end_param == '\\0')\n \t\tqid = 0;\n \telse {\n-\t\tqid_param = strtok(end_param, \",\");\n+\t\tqid_param = strtok_r(end_param, \",\", &sp);\n \t\tif (!qid_param || strlen(qid_param) == 0 || !isdigit(*qid_param))\n \t\t\treturn -EINVAL;\n \n@@ -1221,9 +1222,10 @@ static int\n eth_dev_parse_tm_params(char *params, uint32_t *result)\n {\n \tconst char *splited_param;\n+\tchar *sp = NULL;\n \tuint64_t ret;\n \n-\tsplited_param = strtok(params, \",\");\n+\tsplited_param = strtok_r(params, \",\", &sp);\n \tif (!splited_param || strlen(splited_param) == 0 || !isdigit(*splited_param))\n \t\treturn -EINVAL;\n \n", "prefixes": [ "v3", "11/22" ] }