Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134262,
    "url": "http://patches.dpdk.org/api/patches/134262/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-3-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114110006.91148-3-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-3-haijie1@huawei.com",
    "date": "2023-11-14T10:59:46",
    "name": "[v3,02/22] app/bbdev: replace strtok with reentrant version",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "cca12e2a4eb2402ba7adbb1a593cc5adde295616",
    "submitter": {
        "id": 2935,
        "url": "http://patches.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114110006.91148-3-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 30291,
            "url": "http://patches.dpdk.org/api/series/30291/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30291",
            "date": "2023-11-14T10:59:44",
            "name": "replace strtok with reentrant version",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/30291/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/134262/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/134262/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 71E7243329;\n\tTue, 14 Nov 2023 12:10:28 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0496040698;\n\tTue, 14 Nov 2023 12:10:04 +0100 (CET)",
            "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id E0837402E4\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:09:56 +0100 (CET)",
            "from kwepemd100004.china.huawei.com (unknown [172.30.72.53])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SV3Ns68jzzMmls;\n Tue, 14 Nov 2023 19:05:17 +0800 (CST)",
            "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:09:52 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "<dev@dpdk.org>, Nicolas Chautru <nicolas.chautru@intel.com>, Maxime\n Coquelin <maxime.coquelin@redhat.com>, Amr Mokhtar <amr.mokhtar@intel.com>",
        "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>",
        "Subject": "[PATCH v3 02/22] app/bbdev: replace strtok with reentrant version",
        "Date": "Tue, 14 Nov 2023 18:59:46 +0800",
        "Message-ID": "<20231114110006.91148-3-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.30.0",
        "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>",
        "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.67.165.2]",
        "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: 0acdb9866756 (\"test/bbdev: add FFT operations cases\")\nFixes: f714a18885a6 (\"app/testbbdev: add test application for bbdev\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test-bbdev/test_bbdev_vector.c | 25 +++++++++++++++----------\n 1 file changed, 15 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c\nindex c26727cd35c4..5c966e79645e 100644\n--- a/app/test-bbdev/test_bbdev_vector.c\n+++ b/app/test-bbdev/test_bbdev_vector.c\n@@ -63,8 +63,9 @@ parse_values(char *tokens, uint32_t **data, uint32_t *data_length)\n \n \tuint32_t *values, *values_resized;\n \tchar *tok, *error = NULL;\n+\tchar *sp = NULL;\n \n-\ttok = strtok(tokens, VALUE_DELIMITER);\n+\ttok = strtok_r(tokens, VALUE_DELIMITER, &sp);\n \tif (tok == NULL)\n \t\treturn -1;\n \n@@ -98,7 +99,7 @@ parse_values(char *tokens, uint32_t **data, uint32_t *data_length)\n \n \t\t*data_length = *data_length + (strlen(tok) - strlen(\"0x\"))/2;\n \n-\t\ttok = strtok(NULL, VALUE_DELIMITER);\n+\t\ttok = strtok_r(NULL, VALUE_DELIMITER, &sp);\n \t\tif (tok == NULL)\n \t\t\tbreak;\n \n@@ -299,8 +300,9 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,\n {\n \tchar *tok = NULL;\n \tuint32_t op_flag_value = 0;\n+\tchar *sp = NULL;\n \n-\ttok = strtok(tokens, VALUE_DELIMITER);\n+\ttok = strtok_r(tokens, VALUE_DELIMITER, &sp);\n \tif (tok == NULL)\n \t\treturn -1;\n \n@@ -330,7 +332,7 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,\n \n \t\t*op_flags = *op_flags | op_flag_value;\n \n-\t\ttok = strtok(NULL, VALUE_DELIMITER);\n+\t\ttok = strtok_r(NULL, VALUE_DELIMITER, &sp);\n \t\tif (tok == NULL)\n \t\t\tbreak;\n \t}\n@@ -368,9 +370,10 @@ static int\n parse_expected_status(char *tokens, int *status, enum rte_bbdev_op_type op_type)\n {\n \tchar *tok = NULL;\n+\tchar *sp = NULL;\n \tbool status_ok = false;\n \n-\ttok = strtok(tokens, VALUE_DELIMITER);\n+\ttok = strtok_r(tokens, VALUE_DELIMITER, &sp);\n \tif (tok == NULL)\n \t\treturn -1;\n \n@@ -401,7 +404,7 @@ parse_expected_status(char *tokens, int *status, enum rte_bbdev_op_type op_type)\n \t\t\treturn -1;\n \t\t}\n \n-\t\ttok = strtok(NULL, VALUE_DELIMITER);\n+\t\ttok = strtok_r(NULL, VALUE_DELIMITER, &sp);\n \t\tif (tok == NULL)\n \t\t\tbreak;\n \t}\n@@ -894,6 +897,7 @@ parse_fft_params(const char *key_token, char *token,\n \tint ret = 0, status = 0, i, shift;\n \tuint32_t op_flags = 0;\n \tchar *tok, *err = NULL;\n+\tchar *sp = NULL;\n \n \tstruct rte_bbdev_op_fft *fft = &vector->fft;\n \n@@ -922,7 +926,7 @@ parse_fft_params(const char *key_token, char *token,\n \t\tfft->output_leading_depadding = (uint32_t) strtoul(token, &err, 0);\n \t\tret = ((err == NULL) || (*err != '\\0')) ? -1 : 0;\n \t} else if (!strcmp(key_token, \"window_index\")) {\n-\t\ttok = strtok(token, VALUE_DELIMITER);\n+\t\ttok = strtok_r(token, VALUE_DELIMITER, &sp);\n \t\tif (tok == NULL)\n \t\t\treturn -1;\n \t\tfor (i = 0; i < FFT_WIN_SIZE; i++) {\n@@ -930,7 +934,7 @@ parse_fft_params(const char *key_token, char *token,\n \t\t\tfft->window_index[i / 2] |= (uint32_t) strtoul(tok, &err, 0)\n \t\t\t\t\t<< shift;\n \t\t\tif (i < (FFT_WIN_SIZE - 1)) {\n-\t\t\t\ttok = strtok(NULL, VALUE_DELIMITER);\n+\t\t\t\ttok = strtok_r(NULL, VALUE_DELIMITER, &sp);\n \t\t\t\tif (tok == NULL)\n \t\t\t\t\treturn -1;\n \t\t\t}\n@@ -995,6 +999,7 @@ static int\n parse_entry(char *entry, struct test_bbdev_vector *vector)\n {\n \tint ret = 0;\n+\tchar *sp = NULL;\n \tchar *token, *key_token;\n \tenum rte_bbdev_op_type op_type = RTE_BBDEV_OP_NONE;\n \n@@ -1004,10 +1009,10 @@ parse_entry(char *entry, struct test_bbdev_vector *vector)\n \t}\n \n \t/* get key */\n-\ttoken = strtok(entry, ENTRY_DELIMITER);\n+\ttoken = strtok_r(entry, ENTRY_DELIMITER, &sp);\n \tkey_token = token;\n \t/* get values for key */\n-\ttoken = strtok(NULL, ENTRY_DELIMITER);\n+\ttoken = strtok_r(NULL, ENTRY_DELIMITER, &sp);\n \n \tif (key_token == NULL || token == NULL) {\n \t\tprintf(\"Expected 'key = values' but was '%.40s'..\\n\", entry);\n",
    "prefixes": [
        "v3",
        "02/22"
    ]
}