Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134225,
    "url": "http://patches.dpdk.org/api/patches/134225/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-41-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114082539.1858594-41-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114082539.1858594-41-huangdengdui@huawei.com",
    "date": "2023-11-14T08:25:36",
    "name": "[40/43] raw/ifpga: use rte strerror",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "169c5c4de71045448e5b568066a960d62a96e29f",
    "submitter": {
        "id": 3066,
        "url": "http://patches.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-41-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 30285,
            "url": "http://patches.dpdk.org/api/series/30285/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30285",
            "date": "2023-11-14T08:25:01",
            "name": "replace strerror",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/30285/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/134225/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/134225/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B680D43325;\n\tTue, 14 Nov 2023 09:29:31 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B5EB42D27;\n\tTue, 14 Nov 2023 09:26:26 +0100 (CET)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 1E3924067B\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:25:47 +0100 (CET)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4STzmz4NxbzrVDl;\n Tue, 14 Nov 2023 16:22:27 +0800 (CST)",
            "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 16:25:46 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>",
        "Subject": "[PATCH 40/43] raw/ifpga: use rte strerror",
        "Date": "Tue, 14 Nov 2023 16:25:36 +0800",
        "Message-ID": "<20231114082539.1858594-41-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20231114082539.1858594-1-huangdengdui@huawei.com>",
        "References": "<20231114082539.1858594-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/raw/ifpga/afu_pmd_n3000.c      |  5 +++--\n drivers/raw/ifpga/base/ifpga_fme_rsu.c | 12 +++++++-----\n drivers/raw/ifpga/ifpga_rawdev.c       |  2 +-\n 3 files changed, 11 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c b/drivers/raw/ifpga/afu_pmd_n3000.c\nindex 67b3941265..d7302edc3f 100644\n--- a/drivers/raw/ifpga/afu_pmd_n3000.c\n+++ b/drivers/raw/ifpga/afu_pmd_n3000.c\n@@ -21,6 +21,7 @@\n #include <bus_pci_driver.h>\n #include <bus_ifpga_driver.h>\n #include <rte_rawdev.h>\n+#include <rte_errno.h>\n \n #include \"afu_pmd_core.h\"\n #include \"afu_pmd_n3000.h\"\n@@ -693,7 +694,7 @@ static int poll_interrupt(struct dma_afu_ctx *ctx)\n \tpfd.events = POLLIN;\n \tpoll_ret = poll(&pfd, 1, DMA_TIMEOUT_MSEC);\n \tif (poll_ret < 0) {\n-\t\tIFPGA_RAWDEV_PMD_ERR(\"Error %s\", strerror(errno));\n+\t\tIFPGA_RAWDEV_PMD_ERR(\"Error %s\", rte_strerror(errno));\n \t\tret = -EFAULT;\n \t\tgoto out;\n \t} else if (poll_ret == 0) {\n@@ -708,7 +709,7 @@ static int poll_interrupt(struct dma_afu_ctx *ctx)\n \t\t\tret = 0;\n \t\t} else {\n \t\t\tIFPGA_RAWDEV_PMD_ERR(\"Failed %s\", bytes_read > 0 ?\n-\t\t\t\tstrerror(errno) : \"zero bytes read\");\n+\t\t\t\trte_strerror(errno) : \"zero bytes read\");\n \t\t\tret = -EIO;\n \t\t}\n \t}\ndiff --git a/drivers/raw/ifpga/base/ifpga_fme_rsu.c b/drivers/raw/ifpga/base/ifpga_fme_rsu.c\nindex f147aaa1e8..8e8a611f9a 100644\n--- a/drivers/raw/ifpga/base/ifpga_fme_rsu.c\n+++ b/drivers/raw/ifpga/base/ifpga_fme_rsu.c\n@@ -7,6 +7,8 @@\n #include <unistd.h>\n #include \"ifpga_sec_mgr.h\"\n \n+#include <rte_errno.h>\n+\n static struct ifpga_sec_mgr *sec_mgr;\n \n static void set_rsu_control(struct ifpga_sec_mgr *smgr, uint32_t ctrl)\n@@ -112,7 +114,7 @@ static int write_flash_image(struct ifpga_sec_mgr *smgr, const char *image,\n \tif (fd < 0) {\n \t\tdev_err(smgr,\n \t\t\t\"Failed to open \\'%s\\' for RD [e:%s]\\n\",\n-\t\t\timage, strerror(errno));\n+\t\t\timage, rte_strerror(errno));\n \t\treturn -EIO;\n \t}\n \n@@ -130,14 +132,14 @@ static int write_flash_image(struct ifpga_sec_mgr *smgr, const char *image,\n \t\t\tIFPGA_RSU_DATA_BLK_SIZE : length;\n \t\tif (lseek(fd, offset, SEEK_SET) < 0) {\n \t\t\tdev_err(smgr, \"Failed to seek in \\'%s\\' [e:%s]\\n\",\n-\t\t\t\timage, strerror(errno));\n+\t\t\t\timage, rte_strerror(errno));\n \t\t\tret = -EIO;\n \t\t\tgoto end;\n \t\t}\n \t\tread_size = read(fd, buf, to_transfer);\n \t\tif (read_size < 0) {\n \t\t\tdev_err(smgr, \"Failed to read from \\'%s\\' [e:%s]\\n\",\n-\t\t\t\timage, strerror(errno));\n+\t\t\t\timage, rte_strerror(errno));\n \t\t\tret = -EIO;\n \t\t\tgoto end;\n \t\t}\n@@ -316,7 +318,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,\n \tif (fd < 0) {\n \t\tdev_err(smgr,\n \t\t\t\"Failed to open \\'%s\\' for RD [e:%s]\\n\",\n-\t\t\timage, strerror(errno));\n+\t\t\timage, rte_strerror(errno));\n \t\treturn -EIO;\n \t}\n \tlen = lseek(fd, 0, SEEK_END);\n@@ -325,7 +327,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,\n \tif (len < 0) {\n \t\tdev_err(smgr,\n \t\t\t\"Failed to get file length of \\'%s\\' [e:%s]\\n\",\n-\t\t\timage, strerror(errno));\n+\t\t\timage, rte_strerror(errno));\n \t\treturn -EIO;\n \t}\n \tif (len == 0) {\ndiff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c\nindex f89bd3f9e2..56d3ec02eb 100644\n--- a/drivers/raw/ifpga/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga/ifpga_rawdev.c\n@@ -847,7 +847,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,\n \tif (file_fd < 0) {\n \t\tIFPGA_RAWDEV_PMD_ERR(\"%s: open file error: %s\\n\",\n \t\t\t\t__func__, file_name);\n-\t\tIFPGA_RAWDEV_PMD_ERR(\"Message : %s\\n\", strerror(errno));\n+\t\tIFPGA_RAWDEV_PMD_ERR(\"Message : %s\\n\", rte_strerror(errno));\n \t\treturn -EINVAL;\n \t}\n \tret = stat(file_name, &file_stat);\n",
    "prefixes": [
        "40/43"
    ]
}