Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134207/?format=api
{ "id": 134207, "url": "http://patches.dpdk.org/api/patches/134207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-20-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114082539.1858594-20-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114082539.1858594-20-huangdengdui@huawei.com", "date": "2023-11-14T08:25:15", "name": "[19/43] crypto/caam_jr: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "322f2304a11132bcce93afd279bf5fdb6864ef73", "submitter": { "id": 3066, "url": "http://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231114082539.1858594-20-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30285, "url": "http://patches.dpdk.org/api/series/30285/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30285", "date": "2023-11-14T08:25:01", "name": "replace strerror", "version": 1, "mbox": "http://patches.dpdk.org/series/30285/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134207/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4BC8043325;\n\tTue, 14 Nov 2023 09:27:45 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3413040EE5;\n\tTue, 14 Nov 2023 09:26:06 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 77A37402EE\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:25:44 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.55])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4STzlS3HqHzMmLj;\n Tue, 14 Nov 2023 16:21:08 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 16:25:43 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH 19/43] crypto/caam_jr: use rte strerror", "Date": "Tue, 14 Nov 2023 16:25:15 +0800", "Message-ID": "<20231114082539.1858594-20-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114082539.1858594-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/crypto/caam_jr/caam_jr_uio.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c b/drivers/crypto/caam_jr/caam_jr_uio.c\nindex 583ba3b523..b612407c41 100644\n--- a/drivers/crypto/caam_jr/caam_jr_uio.c\n+++ b/drivers/crypto/caam_jr/caam_jr_uio.c\n@@ -17,6 +17,7 @@\n #include <rte_malloc.h>\n #include <rte_crypto.h>\n #include <rte_security.h>\n+#include <rte_errno.h>\n \n #include <caam_jr_config.h>\n #include <caam_jr_hw_specific.h>\n@@ -355,7 +356,7 @@ free_job_ring(int uio_fd)\n \tif (munmap(job_ring->register_base_addr, job_ring->map_size)) {\n \t\tCAAM_JR_INFO(\"cannot munmap(%p, 0x%lx): %s\",\n \t\t\tjob_ring->register_base_addr,\n-\t\t\t(unsigned long)job_ring->map_size, strerror(errno));\n+\t\t\t(unsigned long)job_ring->map_size, rte_strerror(errno));\n \t} else\n \t\tCAAM_JR_DEBUG(\"JR UIO memory is unmapped\");\n \n@@ -419,7 +420,7 @@ sec_configure(void)\n \td = opendir(SEC_UIO_DEVICE_SYS_ATTR_PATH);\n \tif (d == NULL) {\n \t\tprintf(\"\\nError opening directory '%s': %s\\n\",\n-\t\t\tSEC_UIO_DEVICE_SYS_ATTR_PATH, strerror(errno));\n+\t\t\tSEC_UIO_DEVICE_SYS_ATTR_PATH, rte_strerror(errno));\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "19/43" ] }