Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134174/?format=api
{ "id": 134174, "url": "http://patches.dpdk.org/api/patches/134174/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113170605.408281-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113170605.408281-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113170605.408281-3-stephen@networkplumber.org", "date": "2023-11-13T17:06:04", "name": "[v2,2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "07b66580eb65758ffdae1581a495c3f960b1d5cb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113170605.408281-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 30277, "url": "http://patches.dpdk.org/api/series/30277/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30277", "date": "2023-11-13T17:06:02", "name": "use static_assertion for build errors", "version": 2, "mbox": "http://patches.dpdk.org/series/30277/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134174/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6515C4331D;\n\tMon, 13 Nov 2023 18:06:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E5614026C;\n\tMon, 13 Nov 2023 18:06:21 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id 56D4F4067B\n for <dev@dpdk.org>; Mon, 13 Nov 2023 18:06:18 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1cc1ee2d8dfso41702945ad.3\n for <dev@dpdk.org>; Mon, 13 Nov 2023 09:06:18 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l4-20020a170902eb0400b001c61901ed2esm4232051plb.219.2023.11.13.09.06.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Nov 2023 09:06:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699895177;\n x=1700499977; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Xfltq0FDtOzHtfnt35/mKLL5OageXwa8xNlYP8AehBI=;\n b=Nz9YNrYa8EXiezfzSOFOZokKImXrBH/njwijtw01aHjbFXlzFHyLlUGUVjnpal63M6\n G0hV81yhB9xQ+B+uVjQB0QMxCQtB6kaBADM6MCkIjAPCJwjsbwhSNjHZKbAgrIWNSuHS\n 1KyrXp4CRJylN1kui5CavAZtxFUfH2CjZfPHx+YQZ+Fl++zRXPejV5Wr7u6guBp2dM9l\n yRdDgRleynD/b9BiOuyjegJRUK1+cdTVNfKOwY5gK6ipV8G++Y16saOnlcoPfZ13GRZ/\n 3loVRO/4SbBCMHvcUmAi8bWEkSCH8AwpgK2TDUGzgelJmcWxfE/Nrsxq1UEUeoPU38sw\n t+aA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699895177; x=1700499977;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Xfltq0FDtOzHtfnt35/mKLL5OageXwa8xNlYP8AehBI=;\n b=E0Q+09RnfzW29dJkXImYD3ub13vyoBaRxrW3pjzMNHeBMZzMxt6jS8qrXWwLu3UIHs\n y+6HGPacl3i/sgFt0B7/xUlZ0Apr9y17jUAlNWjjbhHqspxu6S0YJSm8ns8hO32RGpIV\n KyAOjg4zm/bi6f5A8GoYWXQn355F0nJ3pzrAqc1NgvbDf4iEUNg4J8qA47iPDJ+ULTcJ\n pVFkyn2uvdKIKliV4OzaaX0bRtbudug3RzvnSUlKsB/g0e7S3I/wEQxVlbx0emDgHUtx\n PlTEbB1XOqd2yMpbE4X1lKYsjG94TNrzTYq1P1f/jFdRn2fDdw7DemUrxyksFWQ8WS7E\n o5Ww==", "X-Gm-Message-State": "AOJu0YzehMBi5ZwpWAhnQQ4kvG7fFFeoAdIDvjyeG2h7sBSo9CBRLE4D\n tF4a92umKlUH3He/i+AkNYBC/5/c0j8wwKL6hVo=", "X-Google-Smtp-Source": "\n AGHT+IG0zMNkJprhj3y45r8npuncGBMZLjwVnZ0HwTa6TC99QmhMq7oLP4dlC4W0spf4XtqsBPTT/g==", "X-Received": "by 2002:a17:902:e84f:b0:1cc:c243:1cb8 with SMTP id\n t15-20020a170902e84f00b001ccc2431cb8mr148929plg.43.1699895177185;\n Mon, 13 Nov 2023 09:06:17 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, ivan.malov@oktetlabs.ru,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ivan Malov <ivan.malov@arknetworks.am>", "Subject": "[PATCH v2 2/3] net/sfc: fix non-constant expression inr\n RTE_BUILD_BUG_ON()", "Date": "Mon, 13 Nov 2023 09:06:04 -0800", "Message-Id": "<20231113170605.408281-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231113170605.408281-1-stephen@networkplumber.org>", "References": "<20231111172153.57461-1-stephen@networkplumber.org>\n <20231113170605.408281-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The macro RTE_MIN has some hidden assignments to provide type\nsafety which means the statement can not be fully evaluted in\nfirst pass of compiler. Replace RTE_MIN() with equivalent macro.\n\nThis will cause errors from checkpatch about multiple evaluations\nof same expression in macro but it is ok in this case.\n\nFixes: 4f936666d790 (\"net/sfc: support TSO for EF100 native datapath\")\nCc: ivan.malov@oktetlabs.ru\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/sfc/sfc_ef100_tx.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c\nindex 1b6374775f07..f4bcadc1e8e0 100644\n--- a/drivers/net/sfc/sfc_ef100_tx.c\n+++ b/drivers/net/sfc/sfc_ef100_tx.c\n@@ -26,6 +26,10 @@\n #include \"sfc_ef100.h\"\n #include \"sfc_nic_dma_dp.h\"\n \n+#ifndef MIN\n+/* not typesafe but is a constant */\n+#define MIN(x, y) ((x) < (y) ? (x) : (y))\n+#endif\n \n #define sfc_ef100_tx_err(_txq, ...) \\\n \tSFC_DP_LOG(SFC_KVARG_DATAPATH_EF100, ERR, &(_txq)->dp.dpq, __VA_ARGS__)\n@@ -563,8 +567,7 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m)\n \t\t * (split into many Tx descriptors).\n \t\t */\n \t\tRTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX <\n-\t\t\t\t RTE_MIN((unsigned int)EFX_MAC_PDU_MAX,\n-\t\t\t\t SFC_MBUF_SEG_LEN_MAX));\n+\t\t\t\t MIN((unsigned int)EFX_MAC_PDU_MAX, SFC_MBUF_SEG_LEN_MAX));\n \t}\n \n \tif (m->ol_flags & sfc_dp_mport_override) {\n", "prefixes": [ "v2", "2/3" ] }