Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134167/?format=api
{ "id": 134167, "url": "http://patches.dpdk.org/api/patches/134167/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113161519.242272-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113161519.242272-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113161519.242272-2-stephen@networkplumber.org", "date": "2023-11-13T16:15:15", "name": "[v6,1/5] pdump: fix setting rte_errno on mp error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6b5ea89e3b2b36626c0df7fc57296227a0afac6a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113161519.242272-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 30275, "url": "http://patches.dpdk.org/api/series/30275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30275", "date": "2023-11-13T16:15:14", "name": "dumpcap and pcapng fixes", "version": 6, "mbox": "http://patches.dpdk.org/series/30275/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134167/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134167/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 271494331C;\n\tMon, 13 Nov 2023 17:15:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 019EA406B8;\n\tMon, 13 Nov 2023 17:15:34 +0100 (CET)", "from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170])\n by mails.dpdk.org (Postfix) with ESMTP id 6FC8E402D6\n for <dev@dpdk.org>; Mon, 13 Nov 2023 17:15:32 +0100 (CET)", "by mail-pf1-f170.google.com with SMTP id\n d2e1a72fcca58-6b5cac99cfdso3844701b3a.2\n for <dev@dpdk.org>; Mon, 13 Nov 2023 08:15:32 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n hq11-20020a056a00680b00b006c69bbf03e2sm3350043pfb.192.2023.11.13.08.15.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Nov 2023 08:15:30 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1699892131;\n x=1700496931; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dzO7hXbQ2jqdDptnVyq6Ah0zFTtMVblIxZyUbi0KLfM=;\n b=vW5fzK+VqQrHtqjkYwyPj2ZYxpx8ugJtJAQDtF2a9kmsA6tgNyTcWbMoX3M84x2AZT\n UdptE53o8SGINoAxgCLxSDPfFp7k7sWc7JeY1ndWziFxSsdNVobIXLBogv0Xzc0i4JJN\n XW6lsGlBTZLBLz/UDhra5dvWQ50k/4Mi27/Ddfwf1RABROA09KnydapZxKOjSO1rNoJe\n XTk/8fH2/whTn1Cg962tIWQd96XmUQ9cGzydjprfKWcOspSla8UWMMYAjykKTMHP6H+j\n neITSACdm4qdWGswEb0ccd6b/Nad78DPMQMOHHOUY5CAl0OTw/m+mSF5xh1QXF1XWo1n\n eTKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699892131; x=1700496931;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=dzO7hXbQ2jqdDptnVyq6Ah0zFTtMVblIxZyUbi0KLfM=;\n b=hMGAM/fuhhIY9Ux6YBf6WzmexvjHzCAW9GVm70r4qCnWufUCWZXjDRujKKsbRtPZZN\n h9KIuZWwysQmO9kQpydCkPKApnxaOuEkp2KFXtEa7Q3pEw8kyA3eKs5PTAgRxWR7omSy\n RGGIT0YMTSuVE2D+1pyBSAmYQoH0jv6KIfrPg19a3G9EkyvAAdhryIVPGTeMnfgb6EUk\n eE67pRYDMFJj5vzvT0U2jMeG8FIAJpyUw3IGZRm+Qh5gCOf5RcaShrGKaCKLFKnLgLIm\n P63nS84Igt3m86AGswCaP4rPHbhjrOYpNoKd4WPi84JVNPCTyU42ywvsC9IZ9MoW0sfZ\n KIKg==", "X-Gm-Message-State": "AOJu0Ywg0rdmIuy2Li+KsOvw2kDIEIGmQUGmYgEGT3aZWDsfberhrzMK\n 9MlkeNh+0ZMDWDzDTEmc6ufBxLATOUhYmzN4o0U=", "X-Google-Smtp-Source": "\n AGHT+IGGNBTL1iXqhrB4BnTYF8JF4GE7J0rAnO7yWMcu+3+S7iGHyhVW6Gn/e4syrYLKIm7sF3VsOQ==", "X-Received": "by 2002:a05:6a00:b1d:b0:6c3:6cdc:a297 with SMTP id\n f29-20020a056a000b1d00b006c36cdca297mr4514094pfu.14.1699892131070;\n Mon, 13 Nov 2023 08:15:31 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Jianfeng Tan <jianfeng.tan@intel.com>", "Subject": "[PATCH v6 1/5] pdump: fix setting rte_errno on mp error", "Date": "Mon, 13 Nov 2023 08:15:15 -0800", "Message-Id": "<20231113161519.242272-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231113161519.242272-1-stephen@networkplumber.org>", "References": "<20230921042349.104150-1-stephen@networkplumber.org>\n <20231113161519.242272-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The response from MP server sets err_value to negative\non error. The convention for rte_errno is to use a positive\nvalue on error. This makes errors like duplicate registration\nshow up with the correct error value.\n\nFixes: 660098d61f57 (\"pdump: use generic multi-process channel\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/pdump/rte_pdump.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c\nindex 80b90c6f7d03..e94f49e21250 100644\n--- a/lib/pdump/rte_pdump.c\n+++ b/lib/pdump/rte_pdump.c\n@@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue,\n \tif (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) {\n \t\tmp_rep = &mp_reply.msgs[0];\n \t\tresp = (struct pdump_response *)mp_rep->param;\n-\t\trte_errno = resp->err_value;\n-\t\tif (!resp->err_value)\n+\t\tif (resp->err_value == 0)\n \t\t\tret = 0;\n+\t\telse\n+\t\t\trte_errno = -resp->err_value;\n \t\tfree(mp_reply.msgs);\n \t}\n \n", "prefixes": [ "v6", "1/5" ] }