Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134164/?format=api
{ "id": 134164, "url": "http://patches.dpdk.org/api/patches/134164/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113160255.124385-3-taozj888@163.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113160255.124385-3-taozj888@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113160255.124385-3-taozj888@163.com", "date": "2023-11-13T16:02:55", "name": "[v4,2/2] examples/l3fwd: relax RX Offload with option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "609396f370efdd13a3989c04938a63c2b5ec551a", "submitter": { "id": 3044, "url": "http://patches.dpdk.org/api/people/3044/?format=api", "name": "Trevor Tao", "email": "taozj888@163.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113160255.124385-3-taozj888@163.com/mbox/", "series": [ { "id": 30273, "url": "http://patches.dpdk.org/api/series/30273/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30273", "date": "2023-11-13T16:02:53", "name": "example/l3fwd: relax l3fwd rx RSS/Offload if needed", "version": 4, "mbox": "http://patches.dpdk.org/series/30273/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134164/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/134164/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ABDC34331C;\n\tMon, 13 Nov 2023 17:03:22 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F2EA1406B8;\n\tMon, 13 Nov 2023 17:03:12 +0100 (CET)", "from m15.mail.163.com (m15.mail.163.com [45.254.50.220])\n by mails.dpdk.org (Postfix) with ESMTP id 9ABFB40685\n for <dev@dpdk.org>; Mon, 13 Nov 2023 17:03:10 +0100 (CET)", "from u2204.. (unknown [180.113.199.183])\n by zwqz-smtp-mta-g0-4 (Coremail) with SMTP id\n _____wD3f86xSFJlfTY1Aw--.13827S4;\n Tue, 14 Nov 2023 00:03:02 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=bz+Y6\n eJcG66waxj9M1WZmH0O75uL//uvBkf6wXSwMpg=; b=mvluL/d8pptGTnt5W5bKc\n psanpHMh9uSynz3jneBktT3buF4O3dwjKRFSlAKfKF68TcaWoaPjIbdl5bVI0V2/\n mRky9HFbmHZvPTcmZACbNFWQXmZcsbji3wMgIUsM39PCaKwRet8nszdDdPEsmdfJ\n +LdkSMiDNqnsrlCoPEbWWY=", "From": "Trevor Tao <taozj888@163.com>", "To": "dev@dpdk.org", "Cc": "Trevor Tao <taozj888@163.com>", "Subject": "[PATCH v4 2/2] examples/l3fwd: relax RX Offload with option", "Date": "Mon, 13 Nov 2023 16:02:55 +0000", "Message-Id": "<20231113160255.124385-3-taozj888@163.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231113160255.124385-1-taozj888@163.com>", "References": "<20231113160255.124385-1-taozj888@163.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "_____wD3f86xSFJlfTY1Aw--.13827S4", "X-Coremail-Antispam": "1Uf129KBjvJXoW3Xw15ZFyxKr1rZrykAr18Zrb_yoWxXw43pr\n sxKrZ2qF1xZ3yaqF1Syan5urnxWF18uws8Cws5Z3y3tw17A34kWrW8tF15AF9Fka4kC39r\n Za4rGrWfKF1UA3JanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRGQ6XUUUUU=", "X-Originating-IP": "[180.113.199.183]", "X-CM-SenderInfo": "hwdr6yqyyyqiywtou0bp/xtbBMRsnx1c653IUDwAAsp", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now the port Rx offload mode is set to RTE_ETH_RX_OFFLOAD_CHECKSUM\nby default, but some hw and/or virtual interface does not support\nthe offload mode presupposed, e.g., some virtio interfaces in\nthe cloud may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/\nRTE_ETH_RX_OFFLOAD_TCP_CKSUM,\nbut not RTE_ETH_RX_OFFLOAD_IPV4_CKSUM, and the error msg here:\n\nEthdev port_id=0 requested Rx offloads 0xe does not match Rx offloads\ncapabilities 0x201d in rte_eth_dev_configure()\n\nSo to enable the l3fwd running in that environment, the Rx mode requirement\ncan be relaxed to reflect the hardware feature reality here with an option\nrelax_rx_offload, and the l3fwd can run smoothly then.\nA warning msg would be provided to user in case it happens here.\n\nOn the other side, enabling the software cksum check in case missing the\nhw support.\n\nThe relax action for rx cksum offload is just enabled when relax_rx_offload is\ntrue which is false by default.\n\nSigned-off-by: Trevor Tao <taozj888@163.com>\n---\n examples/l3fwd/l3fwd.h | 12 ++++++++++--\n examples/l3fwd/l3fwd_em.h | 2 +-\n examples/l3fwd/l3fwd_lpm.h | 2 +-\n examples/l3fwd/main.c | 24 ++++++++++++++++++++++++\n 4 files changed, 36 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h\nindex b55855c932..e7ae0e5834 100644\n--- a/examples/l3fwd/l3fwd.h\n+++ b/examples/l3fwd/l3fwd.h\n@@ -159,7 +159,7 @@ send_single_packet(struct lcore_conf *qconf,\n \n #ifdef DO_RFC_1812_CHECKS\n static inline int\n-is_valid_ipv4_pkt(struct rte_ipv4_hdr *pkt, uint32_t link_len)\n+is_valid_ipv4_pkt(struct rte_ipv4_hdr *pkt, uint32_t link_len, uint64_t ol_flags)\n {\n \t/* From http://www.rfc-editor.org/rfc/rfc1812.txt section 5.2.2 */\n \t/*\n@@ -170,7 +170,15 @@ is_valid_ipv4_pkt(struct rte_ipv4_hdr *pkt, uint32_t link_len)\n \t\treturn -1;\n \n \t/* 2. The IP checksum must be correct. */\n-\t/* this is checked in H/W */\n+\t/* if this is not checked in H/W, check it. */\n+\tif ((ol_flags & RTE_MBUF_F_RX_IP_CKSUM_MASK) == RTE_MBUF_F_RX_IP_CKSUM_NONE) {\n+\t\tuint16_t actual_cksum, expected_cksum;\n+\t\tactual_cksum = pkt->hdr_checksum;\n+\t\tpkt->hdr_checksum = 0;\n+\t\texpected_cksum = rte_ipv4_cksum(pkt);\n+\t\tif (actual_cksum != expected_cksum)\n+\t\t\treturn -2;\n+\t}\n \n \t/*\n \t * 3. The IP version number must be 4. If the version number is not 4\ndiff --git a/examples/l3fwd/l3fwd_em.h b/examples/l3fwd/l3fwd_em.h\nindex 7d051fc076..1fee2e2e6c 100644\n--- a/examples/l3fwd/l3fwd_em.h\n+++ b/examples/l3fwd/l3fwd_em.h\n@@ -20,7 +20,7 @@ l3fwd_em_handle_ipv4(struct rte_mbuf *m, uint16_t portid,\n \n #ifdef DO_RFC_1812_CHECKS\n \t/* Check to make sure the packet is valid (RFC1812) */\n-\tif (is_valid_ipv4_pkt(ipv4_hdr, m->pkt_len) < 0) {\n+\tif (is_valid_ipv4_pkt(ipv4_hdr, m->pkt_len, m->ol_flags) < 0) {\n \t\trte_pktmbuf_free(m);\n \t\treturn BAD_PORT;\n \t}\ndiff --git a/examples/l3fwd/l3fwd_lpm.h b/examples/l3fwd/l3fwd_lpm.h\nindex c61b969584..4ee61e8d88 100644\n--- a/examples/l3fwd/l3fwd_lpm.h\n+++ b/examples/l3fwd/l3fwd_lpm.h\n@@ -22,7 +22,7 @@ l3fwd_lpm_simple_forward(struct rte_mbuf *m, uint16_t portid,\n \n #ifdef DO_RFC_1812_CHECKS\n \t\t/* Check to make sure the packet is valid (RFC1812) */\n-\t\tif (is_valid_ipv4_pkt(ipv4_hdr, m->pkt_len) < 0) {\n+\t\tif (is_valid_ipv4_pkt(ipv4_hdr, m->pkt_len, m->ol_flags) < 0) {\n \t\t\trte_pktmbuf_free(m);\n \t\t\treturn;\n \t\t}\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex b42365ef1b..851e7e68f9 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -74,6 +74,8 @@ static int numa_on = 1; /**< NUMA is enabled by default. */\n static int parse_ptype; /**< Parse packet type using rx callback, and */\n \t\t\t/**< disabled by default */\n static int disable_rss; /**< Disable the RX RSS mode */\n+static int relax_rx_offload; /**< Relax RX offload mode, and */\n+\t\t\t /**< disabled by default */\n static int per_port_pool; /**< Use separate buffer pools per port; disabled */\n \t\t\t /**< by default */\n \n@@ -680,6 +682,7 @@ static const char short_options[] =\n #define CMD_LINE_OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n #define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n #define CMD_LINE_OPT_DISABLE_RSS \"disable-rss\"\n+#define CMD_LINE_OPT_RELAX_RX_OFFLOAD \"relax-rx-offload\"\n #define CMD_LINE_OPT_PER_PORT_POOL \"per-port-pool\"\n #define CMD_LINE_OPT_MODE \"mode\"\n #define CMD_LINE_OPT_EVENTQ_SYNC \"eventq-sched\"\n@@ -708,6 +711,7 @@ enum {\n \tCMD_LINE_OPT_HASH_ENTRY_NUM_NUM,\n \tCMD_LINE_OPT_PARSE_PTYPE_NUM,\n \tCMD_LINE_OPT_DISABLE_RSS_NUM,\n+\tCMD_LINE_OPT_RELAX_RX_OFFLOAD_NUM,\n \tCMD_LINE_OPT_RULE_IPV4_NUM,\n \tCMD_LINE_OPT_RULE_IPV6_NUM,\n \tCMD_LINE_OPT_ALG_NUM,\n@@ -731,6 +735,7 @@ static const struct option lgopts[] = {\n \t{CMD_LINE_OPT_MAX_PKT_LEN, 1, 0, CMD_LINE_OPT_MAX_PKT_LEN_NUM},\n \t{CMD_LINE_OPT_HASH_ENTRY_NUM, 1, 0, CMD_LINE_OPT_HASH_ENTRY_NUM_NUM},\n \t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, CMD_LINE_OPT_PARSE_PTYPE_NUM},\n+\t{CMD_LINE_OPT_RELAX_RX_OFFLOAD, 0, 0, CMD_LINE_OPT_RELAX_RX_OFFLOAD_NUM},\n \t{CMD_LINE_OPT_DISABLE_RSS, 0, 0, CMD_LINE_OPT_DISABLE_RSS_NUM},\n \t{CMD_LINE_OPT_PER_PORT_POOL, 0, 0, CMD_LINE_OPT_PARSE_PER_PORT_POOL},\n \t{CMD_LINE_OPT_MODE, 1, 0, CMD_LINE_OPT_MODE_NUM},\n@@ -857,6 +862,11 @@ parse_args(int argc, char **argv)\n \t\t\tparse_ptype = 1;\n \t\t\tbreak;\n \n+\t\tcase CMD_LINE_OPT_RELAX_RX_OFFLOAD_NUM:\n+\t\t\tprintf(\"Relax rx offload mode is enabled\\n\");\n+\t\t\trelax_rx_offload = 1;\n+\t\t\tbreak;\n+\n \t\tcase CMD_LINE_OPT_DISABLE_RSS_NUM:\n \t\t\tprintf(\"Disable RX RSS\\n\");\n \t\t\tdisable_rss = 1;\n@@ -1278,6 +1288,20 @@ l3fwd_poll_resource_setup(void)\n \t\t\t\tlocal_port_conf.rx_adv_conf.rss_conf.rss_hf);\n \t\t}\n \n+\t\t/* relax the rx offload requirement */\n+\t\tif ((local_port_conf.rxmode.offloads & dev_info.rx_offload_capa) !=\n+\t\t\tlocal_port_conf.rxmode.offloads) {\n+\t\t\tprintf(\"Port %u requested Rx offloads 0x%\"PRIx64\" does not\"\n+\t\t\t\t\" match Rx offloads capabilities 0x%\"PRIx64\"\\n\",\n+\t\t\t\tportid, local_port_conf.rxmode.offloads,\n+\t\t\t\tdev_info.rx_offload_capa);\n+\t\t\tif (relax_rx_offload) {\n+\t\t\t\tlocal_port_conf.rxmode.offloads &= dev_info.rx_offload_capa;\n+\t\t\t\tprintf(\"warning: modified the rx offload to 0x%\"PRIx64\" based on device\"\n+\t\t\t\t\" capability\\n\", local_port_conf.rxmode.offloads);\n+\t\t\t}\n+\t\t}\n+\n \t\tret = rte_eth_dev_configure(portid, nb_rx_queue,\n \t\t\t\t\t(uint16_t)n_tx_queue, &local_port_conf);\n \t\tif (ret < 0)\n", "prefixes": [ "v4", "2/2" ] }