Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134151/?format=api
{ "id": 134151, "url": "http://patches.dpdk.org/api/patches/134151/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-21-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113104550.2138654-21-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113104550.2138654-21-haijie1@huawei.com", "date": "2023-11-13T10:45:49", "name": "[20/21] examples/l2fwd-crypto: replace strtok with strtok_r", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4e716eae25a9a8d06ce2522e144d21fd157aa4e1", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113104550.2138654-21-haijie1@huawei.com/mbox/", "series": [ { "id": 30264, "url": "http://patches.dpdk.org/api/series/30264/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30264", "date": "2023-11-13T10:45:29", "name": "replace strtok with strtok_r", "version": 1, "mbox": "http://patches.dpdk.org/series/30264/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134151/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134151/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 12477430AB;\n\tMon, 13 Nov 2023 11:52:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D08A40EE4;\n\tMon, 13 Nov 2023 11:51:19 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 5294640A8B\n for <dev@dpdk.org>; Mon, 13 Nov 2023 11:51:06 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4STR6Y1FPtzWhCW;\n Mon, 13 Nov 2023 18:50:45 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Mon, 13 Nov 2023 18:51:04 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>, Fan Zhang\n <fanzhang.oss@gmail.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH 20/21] examples/l2fwd-crypto: replace strtok with strtok_r", "Date": "Mon, 13 Nov 2023 18:45:49 +0800", "Message-ID": "<20231113104550.2138654-21-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231113104550.2138654-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant function.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n examples/l2fwd-crypto/main.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex efe7eea2a768..06e296776b95 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -1105,12 +1105,12 @@ static int\n parse_bytes(uint8_t *data, char *input_arg, uint16_t max_size)\n {\n \tunsigned byte_count;\n-\tchar *token;\n+\tchar *token, *sp = NULL;\n \n \terrno = 0;\n-\tfor (byte_count = 0, token = strtok(input_arg, \":\");\n+\tfor (byte_count = 0, token = strtok_r(input_arg, \":\", &sp);\n \t\t\t(byte_count < max_size) && (token != NULL);\n-\t\t\ttoken = strtok(NULL, \":\")) {\n+\t\t\ttoken = strtok_r(NULL, \":\", &sp)) {\n \n \t\tint number = (int)strtol(token, NULL, 16);\n \n", "prefixes": [ "20/21" ] }