Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134130/?format=api
{ "id": 134130, "url": "http://patches.dpdk.org/api/patches/134130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231113080158.3872440-1-krzysztof.karas@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231113080158.3872440-1-krzysztof.karas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231113080158.3872440-1-krzysztof.karas@intel.com", "date": "2023-11-13T08:01:57", "name": "[v2] crypto/ipsec_mb: do not dequeue ops after flush", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e170cc9aa5bdbef86950e93747bf682f79cd04b6", "submitter": { "id": 2905, "url": "http://patches.dpdk.org/api/people/2905/?format=api", "name": "Krzysztof Karas", "email": "krzysztof.karas@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231113080158.3872440-1-krzysztof.karas@intel.com/mbox/", "series": [ { "id": 30262, "url": "http://patches.dpdk.org/api/series/30262/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30262", "date": "2023-11-13T08:01:57", "name": "[v2] crypto/ipsec_mb: do not dequeue ops after flush", "version": 2, "mbox": "http://patches.dpdk.org/series/30262/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134130/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/134130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A85943319;\n\tMon, 13 Nov 2023 09:04:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B14D140633;\n\tMon, 13 Nov 2023 09:04:27 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 9EB9940279;\n Mon, 13 Nov 2023 09:04:26 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Nov 2023 00:04:25 -0800", "from unknown (HELO fedora38.localdomain) ([10.211.11.138])\n by orsmga001.jf.intel.com with ESMTP; 13 Nov 2023 00:04:22 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1699862667; x=1731398667;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=6oClffUVeoVs+Drhq61kI+zlsVwyhq+ovMrHEI4nWzM=;\n b=HsOI8irp+88MI3N9/LWsevNCIG46nL/CheCOU6ueMAkpBDHd29KEdtBg\n NuiTpbo8C6jD6UcaddGqYaK1Bnq5E4+sAp4FhSmO00LQmjsCJTARSdbw7\n tk13iD8H54V5WsGKtcvNrJkZShANmjR7LtwupScElXEnZJJfKSsHBzGUE\n YwXf9ZWNQnuIn4Ijf4tTSysMyTggBp60VYkdiHufoQs9Hf/3OSmLNcDJ3\n q0WpFcaTEA8NMGBhiqQRW3bEKC8m0sQJRX0AaZ4F9ObRs6U4OV3rXVp6N\n daX1x52TTvFSrSeKcYxNReZ6ldR0Yb2RZAHKyS/teGOtqs8+m+mBXENJQ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10892\"; a=\"389260301\"", "E=Sophos;i=\"6.03,298,1694761200\"; d=\"scan'208\";a=\"389260301\"", "E=McAfee;i=\"6600,9927,10892\"; a=\"799125448\"", "E=Sophos;i=\"6.03,298,1694761200\"; d=\"scan'208\";a=\"799125448\"" ], "X-ExtLoop1": "1", "From": "Krzysztof Karas <krzysztof.karas@intel.com>", "To": "Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Marcel Cornu <marcel.d.cornu@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Cc": "dev@dpdk.org, Krzysztof Karas <krzysztof.karas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush", "Date": "Mon, 13 Nov 2023 08:01:57 +0000", "Message-ID": "<20231113080158.3872440-1-krzysztof.karas@intel.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Previously it was possible to increment `processed_jobs` to a value\ngreater than requested `nb_ops`, because after flushing at most\n`nb_ops` jobs the while loop continued, so `processed_jobs` could\nstill be incremented and it was possible for this variable to be\ngreater than `nb_ops`. If `ops` provided to the function were\nonly `nb_ops` long, then the `aesni_mb_dequeue_burst()` would\nwrite to the memory outside of `ops` array.\n\nFixes: b50b8b5b38f8 (\"crypto/ipsec_mb: use burst API in AESNI\")\nCc: stable@dpdk.org\n\nSigned-off-by: Krzysztof Karas <krzysztof.karas@intel.com>\n---\n\nv2:\n * Shortened title to fit in the limit.\n * Changed nb_ops decrementing from 'nb_jobs' to 'i'.\n\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 9e298023d7..aa08490e0c 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -2056,7 +2056,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\tuint16_t n = (nb_ops / burst_sz) ?\n \t\t\tburst_sz : nb_ops;\n \n-\t\twhile (unlikely((IMB_GET_NEXT_BURST(mb_mgr, n, jobs)) < n)) {\n+\t\tif (unlikely((IMB_GET_NEXT_BURST(mb_mgr, n, jobs)) < n)) {\n \t\t\t/*\n \t\t\t * Not enough free jobs in the queue\n \t\t\t * Flush n jobs until enough jobs available\n@@ -2074,6 +2074,8 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n+\t\t\tnb_ops -= i;\n+\t\t\tcontinue;\n \t\t}\n \n \t\t/*\n", "prefixes": [ "v2" ] }