Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134112/?format=api
{ "id": 134112, "url": "http://patches.dpdk.org/api/patches/134112/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231111071347.71824-1-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231111071347.71824-1-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231111071347.71824-1-getelson@nvidia.com", "date": "2023-11-11T07:13:47", "name": "app/testpmd: add size validation to token parsers", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "3b834cd3f4b343e7eab0129c1b45dd60ec4bd6be", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231111071347.71824-1-getelson@nvidia.com/mbox/", "series": [ { "id": 30250, "url": "http://patches.dpdk.org/api/series/30250/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30250", "date": "2023-11-11T07:13:47", "name": "app/testpmd: add size validation to token parsers", "version": 1, "mbox": "http://patches.dpdk.org/series/30250/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134112/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134112/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE5D1432FF;\n\tSat, 11 Nov 2023 08:14:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B19940281;\n\tSat, 11 Nov 2023 08:14:20 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68])\n by mails.dpdk.org (Postfix) with ESMTP id A2B194003C;\n Sat, 11 Nov 2023 08:14:18 +0100 (CET)", "from BL0PR1501CA0004.namprd15.prod.outlook.com\n (2603:10b6:207:17::17) by DM6PR12MB4893.namprd12.prod.outlook.com\n (2603:10b6:5:1bd::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.21; Sat, 11 Nov\n 2023 07:14:16 +0000", "from BL6PEPF0001AB71.namprd02.prod.outlook.com\n (2603:10b6:207:17:cafe::ca) by BL0PR1501CA0004.outlook.office365.com\n (2603:10b6:207:17::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19 via Frontend\n Transport; Sat, 11 Nov 2023 07:14:15 +0000", "from mail.nvidia.com (216.228.117.161) by\n BL6PEPF0001AB71.mail.protection.outlook.com (10.167.242.164) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6977.16 via Frontend Transport; Sat, 11 Nov 2023 07:14:15 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 10 Nov\n 2023 23:14:05 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 10 Nov\n 2023 23:14:02 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Zzt11yATmRjtPwXRbbY70cPJTLYnIdTGbupn/AxgxvCyEVG297rvkl2NqiorkJZhZ0PGGRdyi+y2AbCgnrJt3SqvGcfICae11BqOAQOJqF0iZny1qqkpQqmyAdKhLloVFVEhlofaJCZkqS9GzSJbyyDzOogIPA5CI4OsyTVIJ5RTHfmKeBvpl7nZ23Mvu2MKDO1k37rQTgTkk6favfJTaiXb1NGkVsyFXF8JdfPjzBGr9DV7xRiw7lYn1aYDQcn6dkogNIb8QNs52x8XAY45YfkawBwJ6M66diMNKzSB+acj74MBtqoZemTGEgZ+DGbaH7ZxIIuCsMZij8d/C+Y8PA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=THiTKli3qC7Kd+XG3vY2U2sC6Tqy75Kzqyg1qBnzfyM=;\n b=LLNtdpymVyicFsjThUf7EYYeoxL8D1duNpYwYd4/71FKHZXohy9iZqulqLrjg7QYl0+w7OUiJJjMqAmBVUrMdvfHtcnF8cstfFzHMVVJnEUBryfTM29LnGck+9emHwed5RG3GBzPjWkXDs+oXi+kvjQa39tlk059wQWXEBSOA6Htp0lq3NhAMena44puAyFHjXttkrKueFvfzx9ZtP8X12lRYH7eXd97FH9pcfz6ffMA5TpaE/enZUV1HvJgQhxcK+vt3gDNC8F2KsIr9/AmXUZJMw98EA7lb1uqD9L7bQAdOXNEGIICsu6vwTXYwuYVp3iBjjYsc76wjvakyJieTQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=THiTKli3qC7Kd+XG3vY2U2sC6Tqy75Kzqyg1qBnzfyM=;\n b=nnQwspnKh0xotREObszhV4t6gofa3/Ct7qNCUBDVFZlAL5VBAc+/YWcdb7mwn5JHSnft5JsxmITbw49WnoRbwyXMd1oLsn9MmZfd73q+OOmN+N343lT66wrf8MlBABpuUlm15sohmTURD6ik4TL7eUNDiwJ2lSwda10X1X8JIDiKYfyTfOul8riW3m8x4rdTUxthN1CLrSdUzJBuROXuLoG0MJNGYjKPL22+kkRJws+yM2ts/U/c2vzq/G1JFJBx59P2im+tGybHLq7WLMWo3OiCEeWLemF3DBMOmuYj7BFYN8A/xXlGhPqMRAGYu4S6lxEKjR7rGH9ti8cCZsYIjg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <ferruh.yigit@amd.com>,\n <stable@dpdk.org>, Ori Kam <orika@nvidia.com>, Aman Singh\n <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, \"Olga\n Shern\" <olgas@nvidia.com>, Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Subject": "[PATCH] app/testpmd: add size validation to token parsers", "Date": "Sat, 11 Nov 2023 09:13:47 +0200", "Message-ID": "<20231111071347.71824-1-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB71:EE_|DM6PR12MB4893:EE_", "X-MS-Office365-Filtering-Correlation-Id": "4835a24c-03a9-4853-f4b8-08dbe285d06f", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 6UCHWgx/r7kCb8OISSAY60Gf8sjjLnwgDe6ZyoRt1+LLeBJXKQ4HQXstGmi9+2vf+z5/FZ3rkxXJIEMRKJs14RhydIiHx7vjunJULyxSgjY/EAXAqr9S9WzdNhEfOINC5SLV6XaFoEd3DAgo4jOqbLD5KCblJ1D9VWa2hl8W9WAmYXsa6jwEzsv5ECYTLYEC4LhrYyJkTK3G79YkY6FAbfeU38SpxbY9/jGHne2D0q59PqR8vNHX6zy1c/DAyQTe5TJxVImosnDi2xAEtRvzkiRyTsIumjFN6b8Ek0Eem9zeyUGIEY6t+RaWGgtWAJRlYU3fFQhc4BO61Lxvy7D1LJnWiaR1h7bvdRlYJjwoFj4/opFF6NT+lMNDc1a//TdDUHTDetnYy1llqSe+S8IU0Vb4llm9Mv4gL5m5+BOgMLMLPWA3/53/3G8am7NLOqjU+pidAHzmM4xPZ1KADn4wl7m8QNPY9GcO7aSQpZmh2G4NGksRkDsISvH3ysICzJ0WBl64UaeKIDJFiZ0mrjTYvwFnmn0SGIm4/UDEBcvt2vf2S/9BAXONDRGbnxVAE8fI5KUt1Wp/jgg5XolwOh68DdiiGkab5pZaIC70HeQM208Go3BG/ufUQsh3kQ4Eb8ovt7UN6BiyrjG2qzplDpnH4h1kYnbdVE6isXTf+vON3AAWeuFlDp2cF2ze1n1tA0SUd797PrNBYUyHBqA37Mc8YT+iTR84UwrJh+0fm3InshBWXlmmAkSIHrtJq0Bv4SPoDud2aR4YC+dhCt43pGYqyA==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(136003)(396003)(376002)(346002)(230922051799003)(186009)(451199024)(64100799003)(82310400011)(1800799009)(40470700004)(46966006)(36840700001)(336012)(426003)(40460700003)(41300700001)(6666004)(2906002)(36860700001)(47076005)(82740400003)(478600001)(356005)(7636003)(6916009)(316002)(54906003)(36756003)(86362001)(70206006)(70586007)(8936002)(4326008)(8676002)(5660300002)(7696005)(2616005)(26005)(55016003)(40480700001)(6286002)(16526019)(1076003)(309714004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Nov 2023 07:14:15.6551 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4835a24c-03a9-4853-f4b8-08dbe285d06f", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB71.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4893", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "parse_prefix(), parse_int(), parse_mac_addr(),\nparse_ipv4_addr() and parse_ipv6_addr() unconditionally overwrite\nthe `size` parameter with token size.\nThe `size` parameter references a buffer where the parser functions\nwill store their result.\n\nIf the `size` value was less than token size, parser will corrupt\nmemory outsite of target buffer.\n\nThe patch adds sizes validation.\n\nFixes: d3f61b7bad20 (\"app/testpmd: add flow item spec prefix length\")\nFixes: 8a03ab58cc0a (\"app/testpmd: support flow integer\")\nFixes: 6df81b325fa4 (\"app/testpmd: add items eth/vlan to flow command\")\nFixes: ef6e38550f07 (\"app/testpmd: add items ipv4/ipv6 to flow command\")\n\nCc: stable@dpdk.org\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex ce71818705..87541d2c46 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -7715,6 +7715,8 @@ parse_prefix(struct context *ctx, const struct token *token,\n \t}\n \tbytes = u / 8;\n \textra = u % 8;\n+\tif (size < arg->size)\n+\t\tgoto error;\n \tsize = arg->size;\n \tif (bytes > size || bytes + !!extra > size)\n \t\tgoto error;\n@@ -10806,6 +10808,8 @@ parse_int(struct context *ctx, const struct token *token,\n \t\treturn len;\n \t}\n \tbuf = (uint8_t *)ctx->object + arg->offset;\n+\tif (size < arg->size)\n+\t\tgoto error;\n \tsize = arg->size;\n \tif (u > RTE_LEN2MASK(size * CHAR_BIT, uint64_t))\n \t\treturn -1;\n@@ -11093,6 +11097,8 @@ parse_mac_addr(struct context *ctx, const struct token *token,\n \t/* Argument is expected. */\n \tif (!arg)\n \t\treturn -1;\n+\tif (size < arg->size)\n+\t\tgoto error;\n \tsize = arg->size;\n \t/* Bit-mask fill is not supported. */\n \tif (arg->mask || size != sizeof(tmp))\n@@ -11134,6 +11140,8 @@ parse_ipv4_addr(struct context *ctx, const struct token *token,\n \t/* Argument is expected. */\n \tif (!arg)\n \t\treturn -1;\n+\tif (size < arg->size)\n+\t\tgoto error;\n \tsize = arg->size;\n \t/* Bit-mask fill is not supported. */\n \tif (arg->mask || size != sizeof(tmp))\n@@ -11181,6 +11189,8 @@ parse_ipv6_addr(struct context *ctx, const struct token *token,\n \t/* Argument is expected. */\n \tif (!arg)\n \t\treturn -1;\n+\tif (size < arg->size)\n+\t\tgoto error;\n \tsize = arg->size;\n \t/* Bit-mask fill is not supported. */\n \tif (arg->mask || size != sizeof(tmp))\n", "prefixes": [] }