Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134110/?format=api
{ "id": 134110, "url": "http://patches.dpdk.org/api/patches/134110/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231111045944.46378-4-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231111045944.46378-4-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231111045944.46378-4-lihuisong@huawei.com", "date": "2023-11-11T04:59:43", "name": "[v2,3/3] app/testpmd: fix unnecessary change when set tunnel TSO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "83ff22f23639e5d3278809c1d2548d1447a56ef7", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231111045944.46378-4-lihuisong@huawei.com/mbox/", "series": [ { "id": 30249, "url": "http://patches.dpdk.org/api/series/30249/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30249", "date": "2023-11-11T04:59:42", "name": "app/testpmd: fix the command to set tunnel TSO", "version": 2, "mbox": "http://patches.dpdk.org/series/30249/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/134110/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/134110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56910432FA;\n\tSat, 11 Nov 2023 05:59:41 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0269402B1;\n\tSat, 11 Nov 2023 05:59:36 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 4992F4027E\n for <dev@dpdk.org>; Sat, 11 Nov 2023 05:59:34 +0100 (CET)", "from kwepemm000004.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SS3LT5S6szrTrn;\n Sat, 11 Nov 2023 12:56:17 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Sat, 11 Nov 2023 12:59:32 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, Aman Singh\n <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Shahaf\n Shuler <shahafs@nvidia.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>", "CC": "<andrew.rybchenko@oktetlabs.ru>, <liuyonglong@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH v2 3/3] app/testpmd: fix unnecessary change when set tunnel\n TSO", "Date": "Sat, 11 Nov 2023 12:59:43 +0800", "Message-ID": "<20231111045944.46378-4-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231111045944.46378-1-lihuisong@huawei.com>", "References": "<20231110081925.14142-1-lihuisong@huawei.com>\n <20231111045944.46378-1-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemm000004.china.huawei.com (7.193.23.18)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, there are two conditions to set tunnel TSO, like \"parse tunnel\"\nand \"outer IP checksum\". If these conditions are not satisfied, testpmd\nshould not change their configuration, like tx_offloads on port and per\nqueue, and no need to request \"reconfig device\".\n\nFixes: 597f9fafe13b (\"app/testpmd: convert to new Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test-pmd/cmdline.c | 25 ++++++++++++++-----------\n 1 file changed, 14 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 7a85cb0024..a37fbe07c2 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -5096,12 +5096,6 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,\n \t\t\t\tres->port_id);\n \t\t\treturn;\n \t\t}\n-\t\tcheck_tunnel_tso_nic_support(res->port_id, dev_info.tx_offload_capa);\n-\n-\t\tports[res->port_id].dev_conf.txmode.offloads |=\n-\t\t\t(all_tunnel_tso & dev_info.tx_offload_capa);\n-\t\tprintf(\"TSO segment size for tunneled packets is %d\\n\",\n-\t\t\tports[res->port_id].tunnel_tso_segsz);\n \n \t\t/* Below conditions are needed to make it work:\n \t\t * (1) tunnel TSO is supported by the NIC;\n@@ -5114,14 +5108,23 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,\n \t\t * is not necessary for IPv6 tunneled pkts because there's no\n \t\t * checksum in IP header anymore.\n \t\t */\n-\n-\t\tif (!ports[res->port_id].parse_tunnel)\n+\t\tif (!ports[res->port_id].parse_tunnel) {\n \t\t\tfprintf(stderr,\n-\t\t\t\t\"Warning: csum parse_tunnel must be set so that tunneled packets are recognized\\n\");\n+\t\t\t\t\"Error: csum parse_tunnel must be set so that tunneled packets are recognized\\n\");\n+\t\t\treturn;\n+\t\t}\n \t\tif (!(ports[res->port_id].dev_conf.txmode.offloads &\n-\t\t RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM))\n+\t\t RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM)) {\n \t\t\tfprintf(stderr,\n-\t\t\t\t\"Warning: csum set outer-ip must be set to hw if outer L3 is IPv4; not necessary for IPv6\\n\");\n+\t\t\t\t\"Error: csum set outer-ip must be set to hw if outer L3 is IPv4; not necessary for IPv6\\n\");\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tcheck_tunnel_tso_nic_support(res->port_id, dev_info.tx_offload_capa);\n+\t\tports[res->port_id].dev_conf.txmode.offloads |=\n+\t\t\t\t(all_tunnel_tso & dev_info.tx_offload_capa);\n+\t\tprintf(\"TSO segment size for tunneled packets is %d\\n\",\n+\t\t\tports[res->port_id].tunnel_tso_segsz);\n \t}\n \n \tcmd_config_queue_tx_offloads(&ports[res->port_id]);\n", "prefixes": [ "v2", "3/3" ] }