Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133956/?format=api
{ "id": 133956, "url": "http://patches.dpdk.org/api/patches/133956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1699400300-22545-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1699400300-22545-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1699400300-22545-4-git-send-email-roretzla@linux.microsoft.com", "date": "2023-11-07T23:38:16", "name": "[v3,3/7] member: use abstracted bit count functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "099dcf13ea1261c1dc7ecb9ee5f8314a7cc88ac5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1699400300-22545-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 30193, "url": "http://patches.dpdk.org/api/series/30193/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30193", "date": "2023-11-07T23:38:13", "name": "use abstracted bit count functions", "version": 3, "mbox": "http://patches.dpdk.org/series/30193/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133956/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E38F5432CC;\n\tWed, 8 Nov 2023 00:38:40 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3F67442D45;\n\tWed, 8 Nov 2023 00:38:28 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8A4EF4026D\n for <dev@dpdk.org>; Wed, 8 Nov 2023 00:38:22 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id D6AB220B74C3; Tue, 7 Nov 2023 15:38:21 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com D6AB220B74C3", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1699400301;\n bh=ZcskPol9UlP6RkArgRTmBSIESOZHxbyLSA6ELh/ZVJU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=mOvyjXh+mvli49vmumKa9t0lcPo0G1So39kutTKYeGaQzpclkBJhHhWplmMmII8xU\n ZoVI+F59wvGaaF1QU7qgbm2nwtPD0HmHAB5OrfITC0+esJbnWXGq0wlwBcLAifVGBr\n wzKoIxrN5HqGiZEi0L6nXjqvzI2r9/6xO+K0xgmQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, mb@smartsharesystems.com", "Subject": "[PATCH v3 3/7] member: use abstracted bit count functions", "Date": "Tue, 7 Nov 2023 15:38:16 -0800", "Message-Id": "<1699400300-22545-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1698887132-5347-1-git-send-email-roretzla@linux.microsoft.com>\n <1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl\ndepending on the resultant type of the expression passed as an argument\n\nFixes: 18898c4d06f9 (\"eal: use abstracted bit count functions\")\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/member/rte_member_vbf.c | 12 ++++++------\n lib/member/rte_member_x86.h | 6 +++---\n 2 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/member/rte_member_vbf.c b/lib/member/rte_member_vbf.c\nindex 9df4620..5a0c51e 100644\n--- a/lib/member/rte_member_vbf.c\n+++ b/lib/member/rte_member_vbf.c\n@@ -108,8 +108,8 @@\n \t * div_shift is used for division shift, to be divided by number of bits\n \t * represented by a uint32_t variable\n \t */\n-\tss->mul_shift = __builtin_ctzl(ss->num_set);\n-\tss->div_shift = __builtin_ctzl(32 >> ss->mul_shift);\n+\tss->mul_shift = rte_ctz32(ss->num_set);\n+\tss->div_shift = rte_ctz32(32 >> ss->mul_shift);\n \n \tRTE_MEMBER_LOG(DEBUG, \"vector bloom filter created, \"\n \t\t\"each bloom filter expects %u keys, needs %u bits, %u hashes, \"\n@@ -174,7 +174,7 @@\n \t}\n \n \tif (mask) {\n-\t\t*set_id = __builtin_ctzl(mask) + 1;\n+\t\t*set_id = rte_ctz32(mask) + 1;\n \t\treturn 1;\n \t}\n \n@@ -207,7 +207,7 @@\n \t}\n \tfor (i = 0; i < num_keys; i++) {\n \t\tif (mask[i]) {\n-\t\t\tset_ids[i] = __builtin_ctzl(mask[i]) + 1;\n+\t\t\tset_ids[i] = rte_ctz32(mask[i]) + 1;\n \t\t\tnum_matches++;\n \t\t} else\n \t\t\tset_ids[i] = RTE_MEMBER_NO_MATCH;\n@@ -233,7 +233,7 @@\n \t\tmask &= test_bit(bit_loc, ss);\n \t}\n \twhile (mask) {\n-\t\tuint32_t loc = __builtin_ctzl(mask);\n+\t\tuint32_t loc = rte_ctz32(mask);\n \t\tset_id[num_matches] = loc + 1;\n \t\tnum_matches++;\n \t\tif (num_matches >= match_per_key)\n@@ -272,7 +272,7 @@\n \tfor (i = 0; i < num_keys; i++) {\n \t\tmatch_cnt_t = 0;\n \t\twhile (mask[i]) {\n-\t\t\tuint32_t loc = __builtin_ctzl(mask[i]);\n+\t\t\tuint32_t loc = rte_ctz32(mask[i]);\n \t\t\tset_ids[i * match_per_key + match_cnt_t] = loc + 1;\n \t\t\tmatch_cnt_t++;\n \t\t\tif (match_cnt_t >= match_per_key)\ndiff --git a/lib/member/rte_member_x86.h b/lib/member/rte_member_x86.h\nindex 74c8e38..d115151 100644\n--- a/lib/member/rte_member_x86.h\n+++ b/lib/member/rte_member_x86.h\n@@ -22,7 +22,7 @@\n \t\t_mm256_load_si256((__m256i const *)buckets[bucket_id].sigs),\n \t\t_mm256_set1_epi16(tmp_sig)));\n \tif (hitmask) {\n-\t\tuint32_t hit_idx = __builtin_ctzl(hitmask) >> 1;\n+\t\tuint32_t hit_idx = rte_ctz32(hitmask) >> 1;\n \t\tbuckets[bucket_id].sets[hit_idx] = set_id;\n \t\treturn 1;\n \t}\n@@ -38,7 +38,7 @@\n \t\t_mm256_load_si256((__m256i const *)buckets[bucket_id].sigs),\n \t\t_mm256_set1_epi16(tmp_sig)));\n \twhile (hitmask) {\n-\t\tuint32_t hit_idx = __builtin_ctzl(hitmask) >> 1;\n+\t\tuint32_t hit_idx = rte_ctz32(hitmask) >> 1;\n \t\tif (buckets[bucket_id].sets[hit_idx] != RTE_MEMBER_NO_MATCH) {\n \t\t\t*set_id = buckets[bucket_id].sets[hit_idx];\n \t\t\treturn 1;\n@@ -59,7 +59,7 @@\n \t\t_mm256_load_si256((__m256i const *)buckets[bucket_id].sigs),\n \t\t_mm256_set1_epi16(tmp_sig)));\n \twhile (hitmask) {\n-\t\tuint32_t hit_idx = __builtin_ctzl(hitmask) >> 1;\n+\t\tuint32_t hit_idx = rte_ctz32(hitmask) >> 1;\n \t\tif (buckets[bucket_id].sets[hit_idx] != RTE_MEMBER_NO_MATCH) {\n \t\t\tset_id[*counter] = buckets[bucket_id].sets[hit_idx];\n \t\t\t(*counter)++;\n", "prefixes": [ "v3", "3/7" ] }