Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133955/?format=api
{ "id": 133955, "url": "http://patches.dpdk.org/api/patches/133955/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1699400300-22545-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1699400300-22545-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1699400300-22545-5-git-send-email-roretzla@linux.microsoft.com", "date": "2023-11-07T23:38:17", "name": "[v3,4/7] rcu: use abstracted bit count functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7e123b9d62d97a2362a7dfe3caf1f9665834adf0", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1699400300-22545-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 30193, "url": "http://patches.dpdk.org/api/series/30193/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30193", "date": "2023-11-07T23:38:13", "name": "use abstracted bit count functions", "version": 3, "mbox": "http://patches.dpdk.org/series/30193/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133955/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42C2C432CC;\n\tWed, 8 Nov 2023 00:38:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EAFE540041;\n\tWed, 8 Nov 2023 00:38:26 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 9C0AB40DDC\n for <dev@dpdk.org>; Wed, 8 Nov 2023 00:38:22 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E4EA820B74C4; Tue, 7 Nov 2023 15:38:21 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E4EA820B74C4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1699400301;\n bh=uKEGi0ejpYKKgvp84kKllYei9w9cTolmgccmjfgGSL8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Rbbe+aB4sTvwEMYRaea08y4ajXnlz7wccgN2ZJ6ysS+TkcUi7Uw2BUgUsrLm2mUlF\n VpgBJRWa+Rbt7dmIE/n0IOPsH4Be5+perxaJG34zYns4obifHiuYwy1tdF9DXM7MZi\n uCkZRIpUOBVsLoRlGVa+rsaw87fktMaIJQ9+Mwuo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, mb@smartsharesystems.com", "Subject": "[PATCH v3 4/7] rcu: use abstracted bit count functions", "Date": "Tue, 7 Nov 2023 15:38:17 -0800", "Message-Id": "<1699400300-22545-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1698887132-5347-1-git-send-email-roretzla@linux.microsoft.com>\n <1699400300-22545-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl\ndepending on the resultant type of the expression passed as an argument\n\nFixes: 18898c4d06f9 (\"eal: use abstracted bit count functions\")\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/rcu/rte_rcu_qsbr.c | 4 ++--\n lib/rcu/rte_rcu_qsbr.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c\nindex 4dc7714..a9f3d6c 100644\n--- a/lib/rcu/rte_rcu_qsbr.c\n+++ b/lib/rcu/rte_rcu_qsbr.c\n@@ -231,7 +231,7 @@\n \t\t\t\t\trte_memory_order_acquire);\n \t\tid = i << __RTE_QSBR_THRID_INDEX_SHIFT;\n \t\twhile (bmap) {\n-\t\t\tt = __builtin_ctzl(bmap);\n+\t\t\tt = rte_ctz64(bmap);\n \t\t\tfprintf(f, \"%u \", id + t);\n \n \t\t\tbmap &= ~(1UL << t);\n@@ -252,7 +252,7 @@\n \t\t\t\t\trte_memory_order_acquire);\n \t\tid = i << __RTE_QSBR_THRID_INDEX_SHIFT;\n \t\twhile (bmap) {\n-\t\t\tt = __builtin_ctzl(bmap);\n+\t\t\tt = rte_ctz64(bmap);\n \t\t\tfprintf(f, \"thread ID = %u, count = %\" PRIu64 \", lock count = %u\\n\",\n \t\t\t\tid + t,\n \t\t\t\trte_atomic_load_explicit(\ndiff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h\nindex 9f4aed2..13461f8 100644\n--- a/lib/rcu/rte_rcu_qsbr.h\n+++ b/lib/rcu/rte_rcu_qsbr.h\n@@ -530,7 +530,7 @@ struct rte_rcu_qsbr_dq_parameters {\n \t\tid = i << __RTE_QSBR_THRID_INDEX_SHIFT;\n \n \t\twhile (bmap) {\n-\t\t\tj = __builtin_ctzl(bmap);\n+\t\t\tj = rte_ctz64(bmap);\n \t\t\t__RTE_RCU_DP_LOG(DEBUG,\n \t\t\t\t\"%s: check: token = %\" PRIu64 \", wait = %d, Bit Map = 0x%\" PRIx64 \", Thread ID = %d\",\n \t\t\t\t__func__, t, wait, bmap, id + j);\n", "prefixes": [ "v3", "4/7" ] }