Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133949/?format=api
{ "id": 133949, "url": "http://patches.dpdk.org/api/patches/133949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com", "date": "2023-11-07T20:00:16", "name": "eal: fix msvc conditional compile of rte atomic thread fence", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "15c857d5039c46d1bec3c01b6efe1f9e9fb144ec", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 30190, "url": "http://patches.dpdk.org/api/series/30190/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30190", "date": "2023-11-07T20:00:16", "name": "eal: fix msvc conditional compile of rte atomic thread fence", "version": 1, "mbox": "http://patches.dpdk.org/series/30190/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133949/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96AFA432CA;\n\tTue, 7 Nov 2023 21:00:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 859E940698;\n\tTue, 7 Nov 2023 21:00:19 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8DDC64025E\n for <dev@dpdk.org>; Tue, 7 Nov 2023 21:00:18 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DF90120B74C0; Tue, 7 Nov 2023 12:00:17 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DF90120B74C0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1699387217;\n bh=2wkgH7eWTjNknu9zUyo6HUrM1Hw0xMu4NY7Mi23x0EI=;\n h=From:To:Cc:Subject:Date:From;\n b=nsJk+7mESHj/p5ks96BjWvWPieZheY4QsIfs0eE60Eg7NvgpBxgxTCxiCcqTb6hKr\n E+XTD6MmvXJz9rU2/tCbOonf0bB+WnwyY1R8PN5BLzBSOJv6DV5fl4ikR6jzTlHF19\n 2vy6ctCWaEJ9SY1oM8kCKnqswB8rD9CaRzHmXpSg=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH] eal: fix msvc conditional compile of rte atomic thread fence", "Date": "Tue, 7 Nov 2023 12:00:16 -0800", "Message-Id": "<1699387216-21396-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC does not expose legacy atomics. When the legacy atomics were\nexcluded rte_atomic_thread_fence was also unintentionally excluded\n\nAdjust the conditional compilation check to expose\nrte_atomic_thread_fence.\n\nFixes: 27da6a123414 (\"eal: hide legacy atomics API for MSVC\")\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/x86/include/rte_atomic.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/x86/include/rte_atomic.h b/lib/eal/x86/include/rte_atomic.h\nindex f754423..74b1b24 100644\n--- a/lib/eal/x86/include/rte_atomic.h\n+++ b/lib/eal/x86/include/rte_atomic.h\n@@ -83,8 +83,6 @@\n \n #define rte_io_rmb() rte_compiler_barrier()\n \n-#ifndef RTE_TOOLCHAIN_MSVC\n-\n /**\n * Synchronization fence between threads based on the specified memory order.\n *\n@@ -101,6 +99,8 @@\n \t\t__rte_atomic_thread_fence(memorder);\n }\n \n+#ifndef RTE_TOOLCHAIN_MSVC\n+\n /*------------------------- 16 bit atomic operations -------------------------*/\n \n #ifndef RTE_FORCE_INTRINSICS\n", "prefixes": [] }