Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133928/?format=api
{ "id": 133928, "url": "http://patches.dpdk.org/api/patches/133928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231107041117.23285-2-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231107041117.23285-2-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231107041117.23285-2-lihuisong@huawei.com", "date": "2023-11-07T04:11:16", "name": "[v3,1/2] app/testpmd: remove useless code for TSO setting command", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3c6c8e684f56ea89cba672bb16b8ac6bbc40db99", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231107041117.23285-2-lihuisong@huawei.com/mbox/", "series": [ { "id": 30176, "url": "http://patches.dpdk.org/api/series/30176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30176", "date": "2023-11-07T04:11:15", "name": "app/testpmd: fix UDP cksum error for UFO enable", "version": 3, "mbox": "http://patches.dpdk.org/series/30176/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133928/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31B10432C0;\n\tTue, 7 Nov 2023 05:11:17 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5214940DCB;\n\tTue, 7 Nov 2023 05:11:08 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id C930B4028C\n for <dev@dpdk.org>; Tue, 7 Nov 2023 05:11:04 +0100 (CET)", "from kwepemm000004.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SPZRK40dDzPncw;\n Tue, 7 Nov 2023 12:06:53 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 7 Nov 2023 12:11:01 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang\n <yuying.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Shahaf Shuler\n <shahafs@nvidia.com>", "CC": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>, <zhichaox.zeng@intel.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH v3 1/2] app/testpmd: remove useless code for TSO setting\n command", "Date": "Tue, 7 Nov 2023 12:11:16 +0800", "Message-ID": "<20231107041117.23285-2-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231107041117.23285-1-lihuisong@huawei.com>", "References": "<20230728021310.15970-1-lihuisong@huawei.com>\n <20231107041117.23285-1-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemm000004.china.huawei.com (7.193.23.18)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Testpmd has added the check of TSO offload capability of port, please see\nthe commit 3926dd2b6668 (\"app/testpmd: enforce offload capabilities check\")\n\nSo the code following the check code memtioned above to display warning\nwhen port doesn't support TSO offload doesn't access to forever.\n\nFixes: 3926dd2b6668 (\"app/testpmd: enforce offload capabilities check\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test-pmd/cmdline.c | 13 -------------\n 1 file changed, 13 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 912bf3355c..1c57e07d41 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -4967,19 +4967,6 @@ cmd_tso_set_parsed(void *parsed_result,\n \t\t\tports[res->port_id].tso_segsz);\n \t}\n \tcmd_config_queue_tx_offloads(&ports[res->port_id]);\n-\n-\t/* display warnings if configuration is not supported by the NIC */\n-\tret = eth_dev_info_get_print_err(res->port_id, &dev_info);\n-\tif (ret != 0)\n-\t\treturn;\n-\n-\tif ((ports[res->port_id].tso_segsz != 0) &&\n-\t\t(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {\n-\t\tfprintf(stderr,\n-\t\t\t\"Warning: TSO enabled but not supported by port %d\\n\",\n-\t\t\tres->port_id);\n-\t}\n-\n \tcmd_reconfig_device_queue(res->port_id, 1, 1);\n }\n \n", "prefixes": [ "v3", "1/2" ] }