Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133796/?format=api
{ "id": 133796, "url": "http://patches.dpdk.org/api/patches/133796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231102230307.6138-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231102230307.6138-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231102230307.6138-3-stephen@networkplumber.org", "date": "2023-11-02T23:02:06", "name": "[2/2] crypto/openssl: remove unnecessary NULL checks before free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "025de4f3b03a8ee1332bbd26c4d033d599dde44f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231102230307.6138-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 30125, "url": "http://patches.dpdk.org/api/series/30125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30125", "date": "2023-11-02T23:02:04", "name": "remove unnecessary null checks in OpenSSL usage", "version": 1, "mbox": "http://patches.dpdk.org/series/30125/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133796/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED11B4324A;\n\tFri, 3 Nov 2023 00:03:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 155C142D7B;\n\tFri, 3 Nov 2023 00:03:17 +0100 (CET)", "from mail-il1-f177.google.com (mail-il1-f177.google.com\n [209.85.166.177])\n by mails.dpdk.org (Postfix) with ESMTP id 0F4CD402CE\n for <dev@dpdk.org>; Fri, 3 Nov 2023 00:03:14 +0100 (CET)", "by mail-il1-f177.google.com with SMTP id\n e9e14a558f8ab-35961c61febso1007975ab.1\n for <dev@dpdk.org>; Thu, 02 Nov 2023 16:03:13 -0700 (PDT)", "from fedora.. ([38.142.2.14]) by smtp.gmail.com with ESMTPSA id\n a24-20020a63cd58000000b005bd3d6e270dsm223192pgj.68.2023.11.02.16.03.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Nov 2023 16:03:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698966193;\n x=1699570993; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4DcHsZZy0nSgqGVb7rSrFR3hEAK7gZREZ3JF6J9bVVY=;\n b=R4gV6mvb8YnkRGnDTry1hFiVPM3lCN1xIzn6XqObZW5xVP9u1L4lqVNyWq0Ll1U+WT\n /T+2NW/bZfLDR0rgSHPbPm6uocLKRK8JN8aSMbPG6nM5MnhiFPbQ3BAtNUW/6DKPgLY8\n zIDkMlJ4saoOD97DCQt2ykB2mvRpVa4m+NLEGGRJBuOdGbFPaeiNj+UqXluOrwa0s9qm\n AByfcqxe1AhIghiqsVTXn8KWHH3uTru3VeO3wwXcwR5e4ltRwvJdltzeoQ2TWjoNdq3h\n VImUE6FWiPp7JlCrE6oeWvdSbpFN0GE4qfnE4Bv6nd/h+wvxz5Q7R3RuPUuVzzNpPQy5\n Aqqw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1698966193; x=1699570993;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=4DcHsZZy0nSgqGVb7rSrFR3hEAK7gZREZ3JF6J9bVVY=;\n b=B+c24OJbrtIoYZ1AfCMhOTycG7Sx77eRfwPRCNOjCSHCIgJ0qu4rykpoAlCIglp+G8\n JHOgqU7mSQzzbunpcQAZVSxh2CFiCu3QUkS44hlyC1E9+ZtXRjVWrOqDLrybde0J+RMp\n l9b9d6ku/h8hZpDXDSR1xxrzR0C7yhaL9ROp35IkAO5hsSJKRNBBL40PKYdkg1cpkE1b\n yAJ0kLltUjEJHr8snUbyh+oCJf/pEaeXo4MvBBjJJYO27BRCdWezlkYjVGKMolaVsOyy\n qadoTZOdA9v03seGCq59+6hGXHMyfkM23xkAmmpi+dR6BpKLSeZz3aE4J836ep3bYxZX\n 4rwQ==", "X-Gm-Message-State": "AOJu0Yw6dv/U9Wbs3v7IV+IebxF6Fa/jmwy+lZAYlE3uat6g5RsSrQQD\n 0bzZzTdE087su31a5pwHi9T8hDKr+IwrotIVKyOB26S2", "X-Google-Smtp-Source": "\n AGHT+IEKNISW2RRCryRSWpS/cnOViCfYD/gR9Zr97jUhjeyiU8PyM0zZPCy4Qgp6ogWVInC9yiwPgw==", "X-Received": "by 2002:a05:6e02:1526:b0:357:f72d:ad1d with SMTP id\n i6-20020a056e02152600b00357f72dad1dmr23719247ilu.30.1698966193051;\n Thu, 02 Nov 2023 16:03:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, Kai Ji <kai.ji@intel.com>", "Subject": "[PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before\n free", "Date": "Thu, 2 Nov 2023 16:02:06 -0700", "Message-ID": "<20231102230307.6138-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20231102230307.6138-1-stephen@networkplumber.org>", "References": "<20231102230307.6138-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Found with nullfree.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/crypto/openssl/rte_openssl_pmd.c | 36 +++++++-------------\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +-\n 2 files changed, 13 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex c234882417..090320602d 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1957,10 +1957,8 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop,\n err_dsa_sign:\n \tif (params)\n \t\tOSSL_PARAM_free(params);\n-\tif (key_ctx)\n-\t\tEVP_PKEY_CTX_free(key_ctx);\n-\tif (dsa_ctx)\n-\t\tEVP_PKEY_CTX_free(dsa_ctx);\n+\tEVP_PKEY_CTX_free(key_ctx);\n+\tEVP_PKEY_CTX_free(dsa_ctx);\n \treturn -1;\n }\n \n@@ -2039,10 +2037,8 @@ process_openssl_dsa_verify_op_evp(struct rte_crypto_op *cop,\n \t\tDSA_SIG_free(sign);\n \tif (params)\n \t\tOSSL_PARAM_free(params);\n-\tif (key_ctx)\n-\t\tEVP_PKEY_CTX_free(key_ctx);\n-\tif (dsa_ctx)\n-\t\tEVP_PKEY_CTX_free(dsa_ctx);\n+\tEVP_PKEY_CTX_free(key_ctx);\n+\tEVP_PKEY_CTX_free(dsa_ctx);\n \n \treturn ret;\n }\n@@ -2294,16 +2290,12 @@ process_openssl_dh_op_evp(struct rte_crypto_op *cop,\n \tret = 0;\n \n err_dh:\n-\tif (pub_key)\n-\t\tBN_free(pub_key);\n-\tif (priv_key)\n-\t\tBN_free(priv_key);\n+\tBN_free(pub_key);\n+\tBN_free(priv_key);\n \tif (params)\n \t\tOSSL_PARAM_free(params);\n-\tif (dhpkey)\n-\t\tEVP_PKEY_free(dhpkey);\n-\tif (peerkey)\n-\t\tEVP_PKEY_free(peerkey);\n+\tEVP_PKEY_free(dhpkey);\n+\tEVP_PKEY_free(peerkey);\n \n \tEVP_PKEY_CTX_free(dh_ctx);\n \n@@ -2880,17 +2872,13 @@ process_openssl_sm2_op_evp(struct rte_crypto_op *cop,\n \tret = 0;\n \tcop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;\n err_sm2:\n-\tif (kctx)\n-\t\tEVP_PKEY_CTX_free(kctx);\n+\tEVP_PKEY_CTX_free(kctx);\n \n-\tif (sctx)\n-\t\tEVP_PKEY_CTX_free(sctx);\n+\tEVP_PKEY_CTX_free(sctx);\n \n-\tif (cctx)\n-\t\tEVP_PKEY_CTX_free(cctx);\n+\tEVP_PKEY_CTX_free(cctx);\n \n-\tif (pkey)\n-\t\tEVP_PKEY_free(pkey);\n+\tEVP_PKEY_free(pkey);\n \n \treturn ret;\n }\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex 2862c294a9..419a767817 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -1431,8 +1431,7 @@ static void openssl_reset_asym_session(struct openssl_asym_session *sess)\n \tswitch (sess->xfrm_type) {\n \tcase RTE_CRYPTO_ASYM_XFORM_RSA:\n #if (OPENSSL_VERSION_NUMBER >= 0x30000000L)\n-\t\tif (sess->u.r.ctx)\n-\t\t\tEVP_PKEY_CTX_free(sess->u.r.ctx);\n+\t\tEVP_PKEY_CTX_free(sess->u.r.ctx);\n #else\n \t\tif (sess->u.r.rsa)\n \t\t\tRSA_free(sess->u.r.rsa);\n", "prefixes": [ "2/2" ] }