Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 133791,
    "url": "http://patches.dpdk.org/api/patches/133791/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231102181148.56930-1-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231102181148.56930-1-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231102181148.56930-1-bruce.richardson@intel.com",
    "date": "2023-11-02T18:11:48",
    "name": "eal: add const to init function parameter",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "7280e66f7f5c5fb78c1c7492da8eefeff2264fd8",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231102181148.56930-1-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 30121,
            "url": "http://patches.dpdk.org/api/series/30121/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30121",
            "date": "2023-11-02T18:11:48",
            "name": "eal: add const to init function parameter",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/30121/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/133791/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/133791/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5834E43270;\n\tThu,  2 Nov 2023 19:12:05 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DAD5A40262;\n\tThu,  2 Nov 2023 19:12:04 +0100 (CET)",
            "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 0AB7040144\n for <dev@dpdk.org>; Thu,  2 Nov 2023 19:12:02 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Nov 2023 11:12:01 -0700",
            "from silpixa00401385.ir.intel.com ([10.237.214.164])\n by orsmga001.jf.intel.com with ESMTP; 02 Nov 2023 11:12:00 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1698948723; x=1730484723;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=wsoUpX8e79UHgqQLxPJyCKJdQR5JIjlinRaDLDsIYuM=;\n b=mp7tO0rBxR8GjqaDDm12nPpJfPGudEJodOspn2y4pNXyk1fCKgv39BUA\n UUc778h3Uo8oYNBujcEfR0tIC8G8yRl+arfQVQO8uVmMHACjB4hSfafKT\n PeEJj5UB9APmF2yhcoJ0KfgBuP/339JkQyB5izvbosjsU2NRoahZcUsjT\n NsVcKZds61uI8g0LtYm75pEx5JUIwPpqj5XKa8g55bmwLDWpX4spDJ+Go\n cYKQEY88/f983fqS3KcyIYADHXnpijhzKh7thBRVGw8AwNCRWD8O1qdqw\n 7tWooGz8Yp3HYZK9qPJDGp9eadXStu4xjSfVKndu0gyNns/K6YCIqBLtQ g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10882\"; a=\"392663861\"",
            "E=Sophos;i=\"6.03,272,1694761200\"; d=\"scan'208\";a=\"392663861\"",
            "E=McAfee;i=\"6600,9927,10882\"; a=\"796337229\"",
            "E=Sophos;i=\"6.03,272,1694761200\"; d=\"scan'208\";a=\"796337229\""
        ],
        "X-ExtLoop1": "1",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "stephen@networkplumber.org, Bruce Richardson <bruce.richardson@intel.com>",
        "Subject": "[PATCH] eal: add const to init function parameter",
        "Date": "Thu,  2 Nov 2023 18:11:48 +0000",
        "Message-Id": "<20231102181148.56930-1-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.39.2",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Change the parameter type of argv parameter to rte_eal_init from\n\"char **\" to \"char * const *\", since we don't modify the argv pointers\npassed in.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eal/common/eal_common_options.c | 2 +-\n lib/eal/common/eal_options.h        | 2 +-\n lib/eal/freebsd/eal.c               | 4 ++--\n lib/eal/include/rte_eal.h           | 2 +-\n lib/eal/linux/eal.c                 | 4 ++--\n lib/eal/windows/eal.c               | 4 ++--\n 6 files changed, 9 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex a6d21f1cba..7927eb1f1d 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -206,7 +206,7 @@ handle_eal_info_request(const char *cmd, const char *params __rte_unused,\n }\n \n int\n-eal_save_args(int argc, char **argv)\n+eal_save_args(int argc, char * const *argv)\n {\n \tint i, j;\n \ndiff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h\nindex 3cc9cb6412..21ab2492fc 100644\n--- a/lib/eal/common/eal_options.h\n+++ b/lib/eal/common/eal_options.h\n@@ -105,7 +105,7 @@ int eal_check_common_options(struct internal_config *internal_cfg);\n void eal_common_usage(void);\n enum rte_proc_type_t eal_proc_type_detect(void);\n int eal_plugins_init(void);\n-int eal_save_args(int argc, char **argv);\n+int eal_save_args(int argc, char * const *argv);\n int handle_eal_info_request(const char *cmd, const char *params __rte_unused,\n \t\tstruct rte_tel_data *d);\n \ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 568e06e9ed..f241e7dd5e 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -365,7 +365,7 @@ eal_get_hugepage_mem_size(void)\n \n /* Parse the arguments for --log-level only */\n static void\n-eal_log_level_parse(int argc, char **argv)\n+eal_log_level_parse(int argc, char * const *argv)\n {\n \tint opt;\n \tchar **argvopt;\n@@ -577,7 +577,7 @@ static void rte_eal_init_alert(const char *msg)\n \n /* Launch threads, called at application init(). */\n int\n-rte_eal_init(int argc, char **argv)\n+rte_eal_init(int argc, char * const *argv)\n {\n \tint i, fctret, ret;\n \tstatic uint32_t run_once;\ndiff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h\nindex cd318ee141..e0a74865ad 100644\n--- a/lib/eal/include/rte_eal.h\n+++ b/lib/eal/include/rte_eal.h\n@@ -109,7 +109,7 @@ int rte_eal_iopl_init(void);\n  *\n  *     ENOEXEC indicates that a service core failed to launch successfully.\n  */\n-int rte_eal_init(int argc, char **argv);\n+int rte_eal_init(int argc, char * const *argv);\n \n /**\n  * Clean up the Environment Abstraction Layer (EAL)\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 57da058cec..a56b85f2ce 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -548,7 +548,7 @@ eal_parse_vfio_vf_token(const char *vf_token)\n \n /* Parse the arguments for --log-level only */\n static void\n-eal_log_level_parse(int argc, char **argv)\n+eal_log_level_parse(int argc, char * const *argv)\n {\n \tint opt;\n \tchar **argvopt;\n@@ -964,7 +964,7 @@ eal_worker_thread_create(unsigned int lcore_id)\n \n /* Launch threads, called at application init(). */\n int\n-rte_eal_init(int argc, char **argv)\n+rte_eal_init(int argc, char * const *argv)\n {\n \tint i, fctret, ret;\n \tstatic RTE_ATOMIC(uint32_t) run_once;\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 7ec2152211..1abb2eb2f7 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -98,7 +98,7 @@ eal_usage(const char *prgname)\n \n /* Parse the arguments for --log-level only */\n static void\n-eal_log_level_parse(int argc, char **argv)\n+eal_log_level_parse(int argc, char * const *argv)\n {\n \tint opt;\n \tchar **argvopt;\n@@ -273,7 +273,7 @@ rte_eal_cleanup(void)\n \n /* Launch threads, called at application init(). */\n int\n-rte_eal_init(int argc, char **argv)\n+rte_eal_init(int argc, char * const *argv)\n {\n \tint i, fctret, bscan;\n \tconst struct rte_config *config = rte_eal_get_configuration();\n",
    "prefixes": []
}